Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glXSj-0000i3-7y for pgadmin-hackers@arkaria.postgresql.org; Mon, 21 Jan 2019 11:09:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1glXSh-0003iy-OX for pgadmin-hackers@arkaria.postgresql.org; Mon, 21 Jan 2019 11:09:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glXSh-0003ir-Fv for pgadmin-hackers@lists.postgresql.org; Mon, 21 Jan 2019 11:09:51 +0000 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glXSZ-0004DU-W9 for pgadmin-hackers@postgresql.org; Mon, 21 Jan 2019 11:09:50 +0000 Received: by mail-qk1-x731.google.com with SMTP id y78so11977902qka.12 for ; Mon, 21 Jan 2019 03:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=md1DIFhe2SQ2sE8RZtFHyPL6Y/HZudt+BRJOYntuGhE=; b=poNzpTslAdbuL5URe6KFxnY2D3Q9i+m+hPm+wrIwXicbG7FmxuSSFLVYAnb47kvVR+ OPGHw2wAYkCGkjo6UKhCIvMplTUefjgjXH6lik/uB8Aru0VosjP4zCyqEc0irg0NdM3W hkpkfNDgMfFnV0GWNMXf2bvu3y3CzlaE5Pg7w5oddL1H8PGKDD7uk1JFFoADFc0NWv9W fgBEx3gqlEK2gcrWC8QE+pSSY0X/Ed48++yVmZXlbI+6HiOUUkf5fFDU+jyFiisVkqzF xUcbamKYQ3ljwv+SbUn6RHG0io9e3lHeFaGqMUkdmron+fhq9Ll2PhxqBXYFOh0kGcFh 37Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=md1DIFhe2SQ2sE8RZtFHyPL6Y/HZudt+BRJOYntuGhE=; b=Bd8OGRAkYpDmCqZSx43VRUdWFpotA/n+YIaRr6T5KfLi65sMjOkvIcQyYt3ua3wkpa wnX3IardqKxFS2Iayw2WdDvpiEQeF+7HMKWlkMmVgyq8Rg+JDP1HE19CRBZbvxmxw+CZ MrMX9oEOC4aRgRxvthjJ7j+8QJZNp6OpCDk14N/UecuOZvz909tp9LCnbzRvwYRYOR9T 4PG7q8DMiF0QRPsgtPt8HZdQBWWw4ZOUdO4kPl7g0v71+gaEXaFgqmTHnLAPmlg2LyBP MS3kGSIv5Iz4iIyW6AjoTqGJaat1Oczevhc7290AAwvOuFOMAR19ET2oiEwN6qZ5fHiC HV7g== X-Gm-Message-State: AJcUukfIdO7Z+3YNTL95NJW5wATffnloVo36t1v5mM82p0K0JwmhBCak qaHXM75SqyJHMrLBFJvgxEwWdtJH7Z0aiYJOUg+WjQiU X-Google-Smtp-Source: ALg8bN4z95At/SkiEDsx9s9dWZTMwU8RqGtWAh9lA+ttNZ29YohTUB5CYdS2mQcX5Oqc2diSPG12Fp22pZ2EgztOAXQ= X-Received: by 2002:a37:8307:: with SMTP id f7mr23564986qkd.4.1548068982736; Mon, 21 Jan 2019 03:09:42 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 21 Jan 2019 16:39:32 +0530 Message-ID: Subject: Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation To: Harshal Dhumal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000cde032057ff5e5fb" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000cde032057ff5e5fb Content-Type: text/plain; charset="UTF-8" Hi Khushboo Can you please review it. On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch. > In this patch I have fixed two issues: > i. Dialog tab navigation should work even if focus is on footer buttons > (Save, Cancel, etc..) > ii. Focus should be set to first editable element of dialog when tab cycle > goes through all editable footer buttons. > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> This patch fixes Dialog tabset keyboard navigation. >> This regression was caused due to bootstrap 4 changes. >> Also I have added jasmine test cases for the same >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000cde032057ff5e5fb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo=C2=A0

Can you please review= it.

On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com&g= t; wrote:
Hi,

Please find attached updated patch.
=
In this patch I have fixed two issues:
i. Dialog tab navigat= ion should work even if focus is on footer buttons (Save, Cancel, etc..)
ii. Focus should be set to first editable element of dialog when ta= b cycle goes through all editable footer buttons.

=
--=C2=A0
Harshal Dhumal
S= r. Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>


On = Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--000000000000cde032057ff5e5fb--