Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kluVz-00024M-9O for pgadmin-hackers@arkaria.postgresql.org; Sun, 06 Dec 2020 13:55:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kluVy-0006qP-8B for pgadmin-hackers@arkaria.postgresql.org; Sun, 06 Dec 2020 13:55:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kluVx-0006qI-Tg for pgadmin-hackers@lists.postgresql.org; Sun, 06 Dec 2020 13:55:50 +0000 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kluVu-0001bc-2z for pgadmin-hackers@postgresql.org; Sun, 06 Dec 2020 13:55:48 +0000 Received: by mail-io1-xd29.google.com with SMTP id t8so10721080iov.8 for ; Sun, 06 Dec 2020 05:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oABCmvniRgSGd3ZkGzbzyN7aP4yyf6fwFzhSmZyRn2g=; b=vC2UN5JKtTFGRGrbzLfmjRdZTGKXuRS3+dpyp/61lvgZ6ZRsTjuZYrhzjAy3Wb2edG OWYbMEn7vkfDU3kbFgHFiCqSF7KCGv8pBqMgYr6accVMpT5MIwoX+ExirXrGnmDhW+72 utTN/uVcNQd0ZHWeqorU+3fKEBcRuwMI2AnbosWIrBA38xzEfu97RX0vnO5d6QOO8Eha tFJSkcGlrXS+OCpTxLtzGjOBxSkW56LHzUBZTGCjtGvq37hiHagfhyoLHvuRMxAGyw92 5PAW8JPlGIFsrDlInvbiWnIvAUIRHnDmbyi3klyi4GZVB4JJlNUs7rMJ0w4U2Ntrko5V 2DAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oABCmvniRgSGd3ZkGzbzyN7aP4yyf6fwFzhSmZyRn2g=; b=XFCcvX40x/peR8fmNzmdIk86IMRyF22qGMBES8WQFVCchBt1+wNz1MKfkaUwVO6n7/ eHhZgUCHccbTjezgl2ffOpW/JZRsST4RKeerUgwVf3ZVelWpOOxSgNeX2Xhxar2mRc12 RWcxx5EItjvQo0FEbtK01H5k5a/nsXg/L+zysvyEDHv+9bE1mGRnmsaxuMJQvxkKV6Yp aQkSoIcUBZy3YnWDDzgyU9gZ7Z29DNxQK3E7j2Ygw4cKbZLGPwH5g6goVCQ8mYRLqmed BxAqjaHMyiB5k+xKx1CKd/6XxkOsQrhZccyyCAwCE5GmTZ1LVwdRdkACCOtZhr5biBer 8E5A== X-Gm-Message-State: AOAM530X04XbdMhooljiMAjGS1wfQVvkHU4e2o3Te/NtoFmSLZSaYgVE +hgnegz7g14FRFI+U9VXM+wL6Wyb5bGEcXGCQzmqJ0kRP3mcCmg6xW6DD0RDGzWzMRglQhwNwy1 7MsSzb+YqSKJQYju2TJie+nQGEBahDQb0IM0rVvxxdZBkH4D5KLF2V6FYsbARz6oGnYMZbDLTNP j/Oln0GH2DoLGg+1KIwU7hV+shh3T3WfZLm7CJBk/DhxnBBjbfr0cPt3r7NlBYV3E= X-Google-Smtp-Source: ABdhPJwUls7KrhpT4Su2Jkfp9l8E4VMN+8WGifKNPgCKlRRvE8cdopJW3V3MWukSQ0B1A/kMQpA+DBSPzZeHYKtBsgo= X-Received: by 2002:a5d:958c:: with SMTP id a12mr14351651ioo.18.1607262945259; Sun, 06 Dec 2020 05:55:45 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Sun, 6 Dec 2020 19:25:34 +0530 Message-ID: Subject: Re: [pgAdmin[RM6062] Code coverage does not cover function or class definitions To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e9cfe005b5cc1088" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e9cfe005b5cc1088 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Fri, Dec 4, 2020 at 3:26 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached code will remove the existing code coverage code and recommend to > use the "coverage" command line instead. > Existing coverage does not cover class and function declarations. > > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000e9cfe005b5cc1088 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Fri, Dec 4, 2020 at 3:26 PM Adity= a Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached code will = remove the existing code coverage code and recommend to use the "cover= age" command line instead.
Existing coverage does not cover class and = function declarations.

Please review.

--
Thanks,
Aditya Toshn= iwal
pgAdmin hacker=C2=A0| Sr. Software Engineer= | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000e9cfe005b5cc1088--