Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j6Zl4-0005oU-5u for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 Feb 2020 12:56:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j6Zl2-0004ob-Vl for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 Feb 2020 12:56:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j6Zl2-0004oU-Ia for pgadmin-hackers@lists.postgresql.org; Tue, 25 Feb 2020 12:56:16 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j6Zkz-0004aX-AM for pgadmin-hackers@postgresql.org; Tue, 25 Feb 2020 12:56:16 +0000 Received: by mail-io1-xd42.google.com with SMTP id h8so1294882iob.2 for ; Tue, 25 Feb 2020 04:56:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hnmI8c6eWceNxFmab6O9oYrvTpvWgEQQ9i46mrwdU6U=; b=1A8tBt720KIdletGCT1vBOIs8UDNEVsLFd1Ov13IiWYtRm+nUhO0UqqkjNORNg0+jm xpPkMfEF/SB3HvzBEQxm1Fe9JP2N14Vzyun4/iXDU+BrB+g5OsOT/jBQk6GRQ8950D0S P2FatuUilQzy+hmFFCc2gNT3JmE2xE1KdujznTi4e+YSQGfgWxFz65dqMxWtuhF4Vkmh BsBWVsYJZ7pZ104shkgGa569IAy19JYPDaET2DDa58bT9tAoe8anNhyOBxqxDo0a6CT0 gdU5RYieAQs0sQehhI/602vNhbo7Zu9GIL2fx30S9D6g6bToSjWmYET/51rx+7CbwuYh rfUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hnmI8c6eWceNxFmab6O9oYrvTpvWgEQQ9i46mrwdU6U=; b=rvHyFSZsowcO2OEK6ziQpWNrwlTAzqHj2Oc1zNBUcIWFPygx+iVwLj20+a8u2x8phr bKroRwadx4nw41oajx/b9LyYelSemoS/3U1aKqE7o3CE72/fWDw9niyUfrlCqOJ67xio rje9vma+PyLbRIdeXPSdxNZzu49Qo8tIMh+7zaH3mwcOC14GEJ7aapY4SKojlsMOhgw2 4mUW3G3woCI6lQ+ov3ltHL2bm7QSUqtXV7SzgcNBX+N+1RWM9nDxFx7E3F85yPb18p9+ OEUqbNPYIqLltYJmmVIyuNUCVebJNp4J/5tchjdVmXKmegQBK7KgqkLKe/2VA+fejlkq CRug== X-Gm-Message-State: APjAAAWiMdH5Uhbvrdk4phSEbn+eDkrDy5aBz8g1+adKFFdAdY3JhVnr Zn/mpy5MxX8PPiVUTiC8KaQItylNeaklFDonp79cg+h3UNVZ/nR1F5vWXRanI+6Y4Yd47vcPR8+ C+GU9FWOcbrLgipVWwqnf3AP3axTmFbJIBKtEFK7vRMQSCkwhxH1tfGCmA4Oafaq+IxsFSDTFH7 jlfFPmbtGDscqZXU1O7cGQMD6g0/i7W4rmaoGiMY91bLaKGwaIoxU= X-Google-Smtp-Source: APXvYqxG5oaFPbGKGdZZ2BEQIX5oPgFBRUD1krsWeV7rRz1PmRw7y2Y5S3xz8cetVxMjfGMAsYayFeucBY8kYGsZ8O4= X-Received: by 2002:a5d:9a05:: with SMTP id s5mr54366452iol.252.1582635371188; Tue, 25 Feb 2020 04:56:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 25 Feb 2020 18:26:00 +0530 Message-ID: Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify To: Pradip Parkale Cc: Aditya Toshniwal , Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001be83b059f660381" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001be83b059f660381 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Feb 25, 2020 at 3:32 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay/Aditya, > > Please find the updated patch. I have accommodated all the changes. > > > On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Pradip, >> >> - >> commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content >> div.active')); >> + >> $(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus(); >> >> Use the same common function with >> commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will >> handle the focus. >> > Fixed. > >> Also, make the required changes mentioned on the pull request - >> https://github.com/EnterpriseDB/AlertifyJS/pull/1 >> > Fixed. > >> >> >> On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Can you please review this patch. >>> >>> On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale < >>> pradip.parkale@enterprisedb.com> wrote: >>> >>>> Please find the attached patch. >>>> >>>> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi < >>>> ashesh.vashi@enterprisedb.com> wrote: >>>> >>>>> Forgot to attach the patch? >>>>> >>>>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < >>>>> pradip.parkale@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is a patch for accessibility issue related Alertifyjs. >>>>>> >>>>>> 1. Added hidden label to satisfy accessibility. >>>>>> 2. Added label with sr-only class. >>>>>> 3. Added tabindex to move the mouse control to the maximize >>>>>> button using the tab key. >>>>>> >>>>>> >>>>>> Please note that this patch also includes the fix for the >>>>>> RM-5143 Accessibility issue to maximize the panel for backup and restore >>>>>> windows and all other places. >>>>>> -- >>>>>> Thanks & Regards, >>>>>> Pradip Parkale >>>>>> QMG, EnterpriseDB Corporation >>>>>> >>>>> -- >>>>> >>>>> -- >>>>> >>>>> Thanks & Regards, >>>>> >>>>> Ashesh Vashi >>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>> >>>>> >>>>> >>>>> *http://www.linkedin.com/in/asheshvashi* >>>>> >>>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> Pradip Parkale >>>> QMG, EnterpriseDB Corporation >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000001be83b059f660381 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks,=C2=A0patch applied.

On Tue, Feb 25, 2020 at 3:32 PM= Pradip Parkale <prad= ip.parkale@enterprisedb.com> wrote:
Hi Akshay/Adit= ya,

Please find the updated patch. I have accommodated= =C2=A0all the changes.


On Mon, Feb 24, 2020 at 2:34 PM = Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
=
Hi Pradip,

- =C2=A0 = =C2=A0commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('= ;.tab-content div.active'));
+ =C2=A0 =C2=A0$(alertifyDialog.element= s.dialog).find('[tabindex]:not([tabindex=3D"-1"]').first(= ).focus();

Use the same co= mmon function with commonUtils.findAndSetFocus(alertifyDialog.elements.dial= og)). It will handle the focus.
Fixed.=C2=A0<= /div>
Also, make the required change= s mentioned on the pull request -=C2=A0https://github.co= m/EnterpriseDB/AlertifyJS/pull/1
Fixed.=C2= =A0


On Fri, Feb 21, 2020 at 11:19 AM Akshay Josh= i <ak= shay.joshi@enterprisedb.com> wrote:
Hi Aditya

Ca= n you please review this patch.

<= div dir=3D"ltr" class=3D"gmail_attr">On Wed, Feb 19, 2020 at 5:04 PM Pradip= Parkale <pradip.parkale@enterprisedb.com> wrote:
Please find the atta= ched patch.

On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <ashesh.vashi@enterprise= db.com> wrote:
Forgot to attach the patch?
On Wed, = 19 Feb 2020 at 16:58, Pradip Parkale <pradip.parkale@enterprisedb.com> = wrote:
Hi Hackers,

Attached=C2=A0is a patch=C2=A0for= accessibility issue related Alertifyjs.
  1. Added hidden lab= el to satisfy accessibility.
  2. Added label with sr-only class.
  3. Added tabindex to move the mouse control to the maximize button u= sing the tab key.

Please note that t= his patch also includes the fix for the RM-5143=C2=A0Accessibility issue to= maximize the panel for backup and restore windows and all other places.
--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation
--

--

<= span style=3D"font-family:"courier new",monospace">Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000001be83b059f660381--