Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTOD1-0007nz-1L for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jun 2018 09:06:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fTOCz-0003nm-FZ for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jun 2018 09:06:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTOCz-0003nc-6I for pgadmin-hackers@lists.postgresql.org; Thu, 14 Jun 2018 09:06:21 +0000 Received: from mail-pl0-x22d.google.com ([2607:f8b0:400e:c01::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fTOCu-0000BZ-GP for pgadmin-hackers@postgresql.org; Thu, 14 Jun 2018 09:06:20 +0000 Received: by mail-pl0-x22d.google.com with SMTP id f1-v6so3183690plt.6 for ; Thu, 14 Jun 2018 02:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wfbcsQKamix3JUROONlQ25P3v7YNVwlOinKVkuMPXfI=; b=z0AfUUbcMj+QACx68/ZCLogUZ5swQcef5S5YN28r7BK+DzsIZIEnY7cDWSFehGH1Uj XQv1SVsM7oInJMA9GH/muEM3syeu5jmJ+agtXShKoCml3inN7P/LZbfX+7hwnska4fR8 P+irPS+6b3g+1zkso5p9hcOz284vzMl1gONMrCtlpe1Teo5lrkIoQEFEBInuoAWErwgU ZTTxAEUU3h9f/U+dhYfvxlPyRpg7lExNjKssP4xdg1pE9dX8vRq8BneIBLMrSgJi1Xxb IHOmqAG4pwbjkC85ZKAcpu+wApMvvOkecvGPW8q/9cp8EU3VbejLpyw5bXsi4iaon2kY tNlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wfbcsQKamix3JUROONlQ25P3v7YNVwlOinKVkuMPXfI=; b=ryTxrT0LYHbp/g9Y5B7nFbWHbm9hY0EejFByQVGEw8Jm9+IBH+zF0ZfawDLzMoI+Yo kHcs7KSIU0TGa/urtIDuB+IaGzJ0zQ/g5ghzs/cjc8Trqgr2GEgGiLhXBaKIAztlEqYb KMcTPol7SrySJ2p6rWqQUTh9eeYteB7EOJsO+dShWKM3EHAetQgYnaQyZ6MotRpAsEUC RjN8geHCjSY1Qb2Wabe/Zvj4jhv1dlnAbosKMUBdwkIhKsXsi+/Av3agY9Yj7ijbKy5i ZEpBGm6DJh55BsZscZOfgfN3YqQmqCsW3fdZ6XxS0m0G9ASFt4VuEvnoeHMuSD4oEBgb aVgw== X-Gm-Message-State: APt69E2RJsyJ5a/0un349CbS3oi6WsXyHddTBq1NJI72EIN4WumMSUXy JlqOINpl0GPAay6op9nxyc3bejXGJ6FLraxCBaQm7g== X-Google-Smtp-Source: ADUXVKJSi8Ju93hKFA9fYv4F2cytXW/StBjT08tsVKSY3/Ti9z7nTS+hQ2wZRM9DmmN8/KwMmySNm3PBSnoO+UvOuVc= X-Received: by 2002:a17:902:7b95:: with SMTP id w21-v6mr2102300pll.150.1528967172903; Thu, 14 Jun 2018 02:06:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:90a:8c86:0:0:0:0 with HTTP; Thu, 14 Jun 2018 02:06:12 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Thu, 14 Jun 2018 14:36:12 +0530 Message-ID: Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000036ea45056e9669b8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000036ea45056e9669b8 Content-Type: text/plain; charset="UTF-8" On Thu, Jun 14, 2018 at 1:14 PM, Dave Page wrote: > Hi > > On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for the Feature #2686 Property to switch >> lower/upper case auto completion. I have added new preferences settings >> "Keywords in uppercase" if it is set to True then all the keywords are >> shown in upper case in auto completion. >> >> I have also implemented the second request in the RM to change the >> selected text to upper/lower case. For that I have added new keyboard >> shortcut "Toggle case of selected text" in preferences dialog. Default >> key is "Ctrl + Shift + u". >> >> Please review it. >> > > I don't see any doc updates in the patch - seems like that was forgotten? > You mean to say ".rst" files? If yes, then sorry I forgot to update that. Will do it and send the modified patch. > > Any opportunities to re-factor the code in that area into more testable > functions? > I have modified the files which are already re-factored. I haven't seen any logic that can be re-factored. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --00000000000036ea45056e9669b8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Jun 14, 2018 at 1:14 PM, Dave Page <dpage@pgadmin.org><= /span> wrote:
Hi

On T= hu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <akshay.joshi@enterp= risedb.com> wrote:
Hi Hackers,

Attached is the patch for the = Feature=C2=A0#2686 Property to switch lower/upper case auto completion. I h= ave added new preferences settings "Keywords in uppercase" if it = is set to True then all the keywords are shown in upper case in auto comple= tion.

I have also implemented the second request i= n the RM to change the selected text to upper/lower case. For that I have a= dded new keyboard shortcut "Toggle case of selected text" in pref= erences dial= og. Default key is "Ctrl + Shift + u".

Please review it.=C2=A0

I don't see any doc updates in the patch - seems like that was forgott= en?

=C2=A0 =C2=A0 Y= ou mean to say ".rst" files? If yes, then sorry I forgot to updat= e that. Will do it and send the modified patch.=C2=A0

Any opportunities to re-factor the code in t= hat area into more testable functions?=C2=A0

=C2=A0 =C2=A0 I have modified the files which are= already re-factored. I haven't seen any logic that can be re-factored.= =C2=A0 =C2=A0

=
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany



--
Akshay Joshi
Sr. Software Architect
=

<= /font>

Phone: +91 20-3058-9517
Mob= ile: +91 976-788-8246
--00000000000036ea45056e9669b8--