public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Dave Page <[email protected]>
Cc: Robert Eckhardt <[email protected]>
Cc: Sarah McAlear <[email protected]>
Cc: Joao Pedro De Almeida Pereira <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Matthew Kleiman <[email protected]>
Subject: Re: [patch] Dependents and Dependencies in GreenPlum
Date: Mon, 8 May 2017 16:54:16 +0530
Message-ID: <CANxoLDfGtTEyfwb=2snvRYN5qAr_CiC5s4J-_NMeSY8hUk8M7A@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfcwCnw8ZRaVzT8TO4be1tmT1XSfOUrD=zMiud-cHLybA@mail.gmail.com>
References: <CAE+jjam5JoMt9+Ue-O_qpgEJO_wAGJfGoaLCJg-1VzVc+AqB_w@mail.gmail.com>
<CA+OCxoxOaYKi6j5dwgwEP7VtP-8XDiee101kjnO3e6SJc4Mp1g@mail.gmail.com>
<CAG7mmoyg2nbVHtYJVd1RA4e2orMv6nsaPoSbUeupy9akrz-z_w@mail.gmail.com>
<CAE+jja=8s-x82BVuBD4THq5V=07F_rJn0+Sa8vUGc=rOtxwWLA@mail.gmail.com>
<CAE+jja=dpFAAxavzJupBjcKQNZjox+grCiqd53AC2EO2G-FGdg@mail.gmail.com>
<CAGRPzo-pSDrQwXOHcy1aPbe==nNqRQpJeK6h2qr8_rsGiidRHg@mail.gmail.com>
<CAAtBm9V77+cbV5fbOkwrPg6JNDuVxQq5=ug7vdChAuTDY0Wj8Q@mail.gmail.com>
<CA+OCxozvcTmYOBrdXMi=b3w4f3LaBSYUMyJiTaUhz-uLuOAWiA@mail.gmail.com>
<CA+OCxozwGCNHJ1d58Huoc=zWGkvH3yWhrzRE9kE7oKm-LdQdYQ@mail.gmail.com>
<CANxoLDfcwCnw8ZRaVzT8TO4be1tmT1XSfOUrD=zMiud-cHLybA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi All
I have reviewed the code and have following questions:
- Why do we have empty __init__.py file in sql and templates/<module>
folder. In this patch we have couple of occurrences one of them is web/
pgadmin/browser/server_groups/servers/databases/schemas/table/templates/trigger
and web/pgadmin/browser/server_groups/servers/databases/schemas
/table/templates/trigger/sql
- Why do we have tests folder inside sql folder as we already have tests
folder in respective module. For example we have tests folder in
*web/pgadmin/browser/server_groups/servers/databases/schemas/table/column
*then
why do we need it in
*web/pgadmin/browser/server_groups/servers/databases/schemas/table/templates/column/sql/tests*
Apart from above code looks good to me.
On Mon, May 8, 2017 at 2:20 PM, Akshay Joshi <[email protected]>
wrote:
>
>
> On Mon, May 8, 2017 at 1:46 PM, Dave Page <[email protected]> wrote:
>
>> Akshay, as Ashesh is unavailable today, can you please review/commit this
>> ASAP?
>>
>
> Sure.
>
>>
>> Thanks.
>>
>> On Fri, May 5, 2017 at 1:18 PM, Dave Page <[email protected]> wrote:
>>
>>> Can you get this polished off on Monday please Ashesh?
>>>
>>> On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt <[email protected]>
>>> wrote:
>>>
>>>> All,
>>>>
>>>> This change in the xss testing is preventing our CI from going green
>>>> and is also preventing the Dependents and Dependencies tabs in Greenplum
>>>> from being useful.
>>>>
>>>> Can we either merge this or provide feedback as to what needs to change
>>>> so that it can be merged.
>>>>
>>>> Thank you
>>>> Rob
>>>>
>>>> On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi Hackers & Ashesh!
>>>>>
>>>>> Is there anything else we can do for this?
>>>>>
>>>>> Thanks!
>>>>> Matt & Sarah
>>>>>
>>>>> On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Thanks for reviewing, Ashesh.
>>>>>>
>>>>>> We have updated the patch. The headers are all consistent and we
>>>>>> removed the __init__.py files in directories containing only .sql.
>>>>>>
>>>>>> Thanks!
>>>>>> Joao & Matt
>>>>>>
>>>>>> On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hello Ashesh,
>>>>>>>
>>>>>>> Thanks for reviewing the patch.
>>>>>>>
>>>>>>> We added the __init__.py files into templates to convert them into
>>>>>>> packages so that the tests inside of them can be found by the test runner.
>>>>>>>
>>>>>>> Thanks!
>>>>>>> Joao & Sarah
>>>>>>>
>>>>>>> On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Ashesh, can you review/commit this please?
>>>>>>>>>
>>>>>>>>> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Hackers,
>>>>>>>>>>
>>>>>>>>>> We found out that when you are connected to a GreenPlum database
>>>>>>>>>> and try to get Dependents and Dependencies of an object the application was
>>>>>>>>>> returning a SQL error.
>>>>>>>>>>
>>>>>>>>>> This patch splits the SQL query used to retrieve the Dependents,
>>>>>>>>>> Dependencies, and Roles SQL file into multiple versioned files.
>>>>>>>>>> Add Unit Tests for each file.
>>>>>>>>>> Also added __init__.py files to other test directories to run the
>>>>>>>>>> tests in them.
>>>>>>>>>>
>>>>>>>>> Hi Joao & Sarah,
>>>>>>>>
>>>>>>>> Why do we need to add __init__.py in the template directory?
>>>>>>>> I didn't understand the purpose of the adding __init__.py files in
>>>>>>>> the template directories.
>>>>>>>>
>>>>>>>> NOTE: The headers in those files are not consistent with the other
>>>>>>>> project files.
>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>> Thanks & Regards,
>>>>>>>>
>>>>>>>> Ashesh Vashi
>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>>>> <http://www.enterprisedb.com/;
>>>>>>>>
>>>>>>>>
>>>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>>>>
>>>>>>>>> Add ORDER BY into Copy Selection Feature test to ensure the
>>>>>>>>>> results are retrieved always in the same order
>>>>>>>>>> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and
>>>>>>>>>> skip it for versions less than 9.1
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>>
>>>>>>>>>> Joao & Sarah
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>>>>> [email protected])
>>>>>>>>>> To make changes to your subscription:
>>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>
>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sent via pgadmin-hackers mailing list ([email protected]
>>>>>> )
>>>>>> To make changes to your subscription:
>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (27+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [patch] Dependents and Dependencies in GreenPlum
In-Reply-To: <CANxoLDfGtTEyfwb=2snvRYN5qAr_CiC5s4J-_NMeSY8hUk8M7A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox