Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b03u6-0003VO-0o for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 May 2016 09:24:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b03u5-0000x9-Hv for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 May 2016 09:24:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b03u4-0000x3-TO for pgadmin-hackers@postgresql.org; Tue, 10 May 2016 09:24:33 +0000 Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b03ty-0004ok-GC for pgadmin-hackers@postgresql.org; Tue, 10 May 2016 09:24:32 +0000 Received: by mail-oi0-x234.google.com with SMTP id x201so7673002oif.3 for ; Tue, 10 May 2016 02:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=IAyyjWxdKlvwXYB9xNNkxr9jXbicsPadVHDkw8V8hsc=; b=i0L3FtgAL7JxZN7eDVq9bL5SiSRAu+GpQddCfLS8SCcVh/lrOEk6TlA9NMzFUm7UNN obAvkBwGc9JyOoiTMxkFaeChu8Ie5C0lyZi/qingOLaX86YrAQldxcu/8ACP+kL+5TZI h5R1+6HHHRIbxEdDDDpE3OKa6T0c59cky2Dq/v9Geqo5RO92+f2uKuQU6TgBzigvbE04 sX2ddekN/BtmqrLMuZTIP0aRwnsE+5ozW6dWsHwPaVVCqmFezH/GEVhoDz1HYRzvPuE8 xZFM+4cifxJtqH4NaxxqauFTrF5CtmO0aW/M17WS9m3uXNWup5hUQu0d1++yGub9BoVp 4peQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=IAyyjWxdKlvwXYB9xNNkxr9jXbicsPadVHDkw8V8hsc=; b=WOAbLqZcGDQy+g1wazF1kuAzG2JAEarA1QXvHmNFc2Zi4zsiJ4WaTaJw9LgX4M5M57 WVwF0EJKP6UDXBkFEV+SE136HKYoeVHVBzlkX3QIDxTYSLDBkHCYGb465hNtAlKkdKy5 X4xs+7sVAr+sjTMjeyU/Pmj5b6YH8ISDytvB2g2IRBr9VCPiz7TBJ+P4aU6nhJuzXAsu CWWybutCiEfIZzxBRzK1uKAmFM8Bky9Whye6AXPVjYwCUlAQO8aBk3kmvR1aScWNoeBY GbPLZyUbW60VEb1OUhf+sKS/M5fPy/7NUQWKR+yWGo7M0o0Nzfoukdg+94xGZlvmmbVy fIjQ== X-Gm-Message-State: AOPr4FUBVVRXObxZWd/ASyYW3i6AhO78Z+yLdaDaSKUYdPzqw0gvw5ei1CQi9flm28/7GB4kTT5Q59IaYnLu/qe/ MIME-Version: 1.0 X-Received: by 10.202.86.215 with SMTP id k206mr17712049oib.115.1462872264495; Tue, 10 May 2016 02:24:24 -0700 (PDT) Received: by 10.202.175.148 with HTTP; Tue, 10 May 2016 02:24:24 -0700 (PDT) In-Reply-To: References: Date: Tue, 10 May 2016 14:54:24 +0530 Message-ID: Subject: Re: PATCH: Graphincal explain integrated in sql editor From: Akshay Joshi To: Sanket Mehta Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113d7ba6ad65f00532797d48 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113d7ba6ad65f00532797d48 Content-Type: text/plain; charset=UTF-8 Hi Sanket On Tue, May 10, 2016 at 12:21 PM, Sanket Mehta wrote: > Hi, > > As previous patch was not applicable to latest pgadmin4 source code, here > is the new patch accommodating latest code. > Please do review it and send comments. > Following is my review comments - Remove Demo and sample code which you have used for testing before integration. - Facing issue to open QueryTool as there is some problem in require module. - Please add 'codemirror/addon/fold/foldgutter', 'codemirror/addon/fold/foldcode', 'codemirror/addon/fold/pgadmin-sqlfoldcode' files which has been removed from your patch. - Remove below code from sqleditor.js which is duplicated in _execute function - - self.trigger( - 'pgadmin-sqleditor:loading-icon:show', - '{{ _('Initializing the query execution!') }}' - ) - Clear the existing contents of the Explain tab when execute the query without explain. - If schema name is exists then please prefix the schema name to the node. - Please check the data is available before working on it in sqleditor.js at line no 1043 inside _render(). In case of "View Data" it throws an error. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Mon, May 9, 2016 at 11:56 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> Hi, >> >> Please ignore previous patch as there was an error in it. >> >> Error: >> Tooltip was not getting disappear when user moves cursor out of image. >> >> I have attached a proper patch with this mail. >> Please consider it for testing. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Mon, May 9, 2016 at 8:49 PM, Sanket Mehta < >> sanket.mehta@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA revised patch according to Ashesh's comments. >>> Please find my response inline. >>> >>> I am currently adding minimap feature in graphical explain. >>> I will send a new patch for the same. >>> >>> Regards, >>> Sanket Mehta >>> Sr Software engineer >>> Enterprisedb >>> >>> On Mon, Apr 25, 2016 at 4:36 PM, Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Hi Sanket, >>>> >>>> Please find the review comments. >>>> - Please add the missing 'explain.css'. >>>> >>> Done >>> >>>> - The application should be smart enough to handle conflict in options. >>>> i.e. >>>> Buffer is not a valid options without EXPLAIN ANALYZE. >>>> >>> Done >>> >>>> - A statement having EXPLAIN keywords with different format should at >>>> least render the output in the data-grid. >>>> i.e. EXPLAIN (FORMAT xml) SELECT * FROM xyz; >>>> >>> Done >>> >>>> - Please use the keywords used in the EXPLAIN statement in capital. >>>> >>> Done >>> >>>> - Explain should not work with empty string. >>>> >>> Done >>> >>>> - Font size in the tooltip is very small. >>>> >>> Done >>> >>>> >>>> >>> - Smoothing the zoom functionality. >>>> >>> Minimap will be added and zoom functionality will be removed. So it is >>> ignored. >>> >>> - Arrow marker is hardly visible. >>>> >>> Done. >>> >>>> >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>>> On Mon, Apr 25, 2016 at 3:06 PM, Sanket Mehta < >>>> sanket.mehta@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> This patch includes the patch sent earlier for stand alone graphical >>>>> explain. >>>>> >>>>> And also "horizontal lines are not proper" bug is fixed in the same >>>>> which was reported by Dave in previous patch. >>>>> >>>>> Regards, >>>>> Sanket Mehta >>>>> Sr Software engineer >>>>> Enterprisedb >>>>> >>>>> On Thu, Apr 21, 2016 at 8:38 PM, Sanket Mehta < >>>>> sanket.mehta@enterprisedb.com> wrote: >>>>> >>>>>> Hi Team, >>>>>> >>>>>> PFA the first patch for graphical explain integrated in sql editor. >>>>>> >>>>>> Below are the few things which are different from previous patch >>>>>> which was sent for stand alone graphical explain. >>>>>> >>>>>> - Now user can select Explain/Explain Analyze with four optional >>>>>> properties (Verbose, costs, timing and buffers) >>>>>> >>>>>> - Initially graph will be scale (according to only its width not >>>>>> height) to fit to screen so no blank space will be there in case of very >>>>>> large graph. >>>>>> >>>>>> - Along with zoom in/out button, "zoom to original" button is also >>>>>> provided, by clicking on which graph will be scale to its original size >>>>>> (not same as initial one which is according to screen size). >>>>>> >>>>>> Please do review this patch and let me know in case you have any >>>>>> comments. >>>>>> >>>>>> >>>>>> Regards, >>>>>> Sanket Mehta >>>>>> Sr Software engineer >>>>>> Enterprisedb >>>>>> >>>>> >>>>> >>>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a113d7ba6ad65f00532797d48 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Sanket

On Tue, May = 10, 2016 at 12:21 PM, Sanket= Mehta <sanket.mehta@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);pa= dding-left:1ex">
Hi,

As previous patch w= as not applicable to latest pgadmin4 source code, here is the new patch acc= ommodating latest code.
Please do review it and send comments.

=C2=A0 =C2=A0 Following is my rev= iew comments=C2=A0
  • Remove Demo and sample code which you = have used for testing before integration.
  • Facing issue to open=C2= =A0QueryTool=C2=A0as there is some problem= in require module.
  • Please add=C2=A0'codemirror/addon/fold/foldgutter', 'codemirror/addon/fold/foldcode', 'codemirror/addon/fold/pgadmin-sqlfoldcode' files which has been removed from your patch.
  • R= emove below code from=C2=A0<= span class=3D"" id=3D":2wq.12" tabindex=3D"-1">sqleditor.js=C2=A0which is = duplicated in _execute function
    • self.trigger(
    • =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'pgadmin-sqle= ditor:loading-icon:show',
    • =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 '{{ _('Initializing the query execution!')= }}'
    • =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 )
  • Cle= ar the existing contents of the Explain tab when execute the query without = explain.
  • If schema name is exists then please prefix the schema nam= e to the node.=C2=A0
  • Please check the data is available before work= ing on it in=C2=A0sqleditor.js=C2=A0at line no 1043= inside _render().=C2=A0 In case of "View Data" it throws an erro= r.
=C2=A0

Regards,=
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, May 9,= 2016 at 11:56 PM, Sanket Mehta <sanket.mehta@enterprisedb.com= > wrote:
Hi,

Please ignore previous patch as there was an error in it.

Error:
Tooltip was not getting disappear when use= r moves cursor out of image.

I have attached a pro= per patch with this mail.
Please consider it for testing.

= Regards,
Sanket Mehta
Sr Software engineer
Enterpri= sedb

On Mon, May 9, 2016 at 8:49= PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA re= vised patch according to Ashesh's comments.
Please find my re= sponse inline.

I am currently adding minimap featu= re in graphical explain.
I will send a new patch for the same.

Regards,
Sanket Mehta
Sr Software engineer
En= terprisedb

On Mon, Apr 25, 2016 at 4:36 PM= , Ashesh Vashi <ashesh.vashi@enterprisedb.com> w= rote:
Hi Sanket,

Pl= ease find the review comments.
- Please add the missing 'expl= ain.css'.
Done=C2=A0
- The application should be smart enoug= h to handle conflict in options.
=C2=A0 =C2=A0i.e.
=C2= =A0 =C2=A0Buffer is not a valid options without EXPLAIN ANALYZE.
Done=C2=A0
- A statement having EXPLAIN keywords with different format s= hould at least render the output in the data-grid.
=C2=A0 i.e. EX= PLAIN (FORMAT xml) SELECT * FROM xyz;
D= one=C2=A0
- Please use th= e keywords used in the EXPLAIN statement in capital.
Done=C2=A0
= - Explain should not work with empty string.
Done=C2=A0
- Font s= ize in the tooltip is very small.
Done= =C2=A0
=C2=A0
=
- Smoothing the zoom fu= nctionality.
Minimap will be added and = zoom functionality will be removed. So it is ignored.

<= /div>
- Arrow marker is hardly visibl= e.
Done.=C2=A0

--<= /p>

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQ= L Company


http://www.linkedin.com/in/asheshvashi


On Mon, Apr 25, 2016 at 3:06 PM, Sanket Meht= a <sanket.mehta@enterprisedb.com> wrote:
Hi,

This patch includes th= e patch sent earlier for stand alone graphical explain.

And also "horizontal lines are not proper" bug is fixed in = the same which was reported by Dave in previous patch.

Regard= s,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, Apr 21, 2016 at 8:3= 8 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi Team,

= PFA the first patch for graphical explain integrated in sql editor.

Below are the few things which are different from previou= s patch which was sent for stand alone graphical explain.

=C2=A0- =C2=A0Now user can select Explain/Explain Analyze with four= optional properties (Verbose, costs, timing and buffers)

=C2=A0- Initially graph will be scale (according to only its width = not height) to fit to screen so no blank space will be there in case of ver= y large graph.

- Along with zoom in/out button, &q= uot;zoom to original" button is also provided, by clicking on which gr= aph will be scale to its original size (not same as initial one which is ac= cording to screen size).

Please do review this pat= ch and let me know in case you have any comments.

=
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb







--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Aks= hay Joshi
Principal Software Engineer=C2=A0


Phone: +91 20-3058-9517
Mobile: +91 976-7= 88-8246
--001a113d7ba6ad65f00532797d48--