Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSara-0004Hs-E8 for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 08:43:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nSarY-0006d9-Vr for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 08:43:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSarY-0006d0-A6 for pgadmin-hackers@lists.postgresql.org; Fri, 11 Mar 2022 08:43:04 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nSarU-0001SK-H7 for pgadmin-hackers@postgresql.org; Fri, 11 Mar 2022 08:43:02 +0000 Received: by mail-io1-xd33.google.com with SMTP id 195so9438511iou.0 for ; Fri, 11 Mar 2022 00:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pPuvzvs2rjWqd2VPLml5uwRq0wxiVdI3HlhRP/fuPfM=; b=f6E4Fvo9Kv70CsrIphtj1SSfSymhkUJDA9PDeBjXPB23P4zGvMCR901R3TfITbyRW1 Z/lD0IKRNtTZGOBXKR0yjBcQJSVUODxgSudqjcAROJjTnCAwkF+7SvmdzcM6HyC33Vic j4woAkr/vbgXN9WyLn39Kr2i5SyAd2QlNRldWuHnKYoKTBc8apgxmXHlGD6gfH6+78K8 UnSR/tAzKzI4+UzSICZGU1y/9C4nYwDgTWekD5SfHR1owJv7xhVBlzeueICrBUO9T2fG YcGjxUsvTqU+dYS/pG1yz26its+cA8dgLdiixA/InzFX0m0Yb6Z+HI/OCU4cwoY2j3uQ GG7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pPuvzvs2rjWqd2VPLml5uwRq0wxiVdI3HlhRP/fuPfM=; b=uexAL+YKqY59dYByrEAPR1u443pYIzaouTs9MP80v447TgY71CeZn2BIWE9xSv+Jn5 4veWQP5aaOjnLaK64Zqka+v5EhSpp6QtQxw/YFNC4eaqYed56f/7dAiTWCvbAjlWk568 vgfzUPLUpa1867gl+s7YWe9Gz5uf+n9Byt8/xIHGq5mhAmoqN1HEfencgrMOxTj+IIOd 6GVDVPSVKhtyxXDQZswVw4h4IN4C9DDfK3rJUR0VlJTVO/v0b7bZHpmqghKH0yofi0wl TbOCbc0HkkEYha2oKMSldho/up60Sc4AC/bzfcpkEVNLU0d13fWl1JpIs9Zg4wUUNlWi cqLA== X-Gm-Message-State: AOAM531y02UVHLAvLFOH5kd7bwXggWawD3Mjsxf2GqWYP4a5PVwioixc 0OHPpktkk65PAxYGAWa6+cPOmrz0eTKE42XXaMLB1F+ifJdV2r5SqASDJ+QNXl0pbBxdpufmV20 w7/vbBDBjFGN5/sxECle1SQNW7A7zsyDznvDdRBBnyHH6HpzkgC9HyGTIh0OXow/iDoeEu7ozJH ecVLsUT2VPcHrrLK6xknOVAEhqnC4AhDVBIeDpAgGkxvz/0pmZnav8MekcPWgQXWhALw== X-Google-Smtp-Source: ABdhPJwfcVqEN/2qH9FyYUe7HrCuAspP7RSSQy4shbEONuEoO0rgsPkfkE7D2CVaAJi4xxhC2Wz0huTbp3/KVVlZlOk= X-Received: by 2002:a05:6638:150d:b0:319:a297:49a6 with SMTP id b13-20020a056638150d00b00319a29749a6mr7586327jat.128.1646988179352; Fri, 11 Mar 2022 00:42:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 11 Mar 2022 14:12:48 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment To: Khushboo Vashi Cc: Yogesh Mahajan , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000061471605d9ed5180" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000061471605d9ed5180 Content-Type: text/plain; charset="UTF-8" Isn't it possible to define it at a common location? These types of duplicate code are error-prone since sometimes we fix an issue at one place and forget to fix it at another. On Fri, Mar 11, 2022 at 11:56 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > One is for pgacloud standalone code for background process and one for > pgadmin module. > > On Fri, 11 Mar 2022, 10:11 Akshay Joshi, > wrote: > >> Hi Khushboo >> >> Why there are two identical functions (def get_my_ip) in two different >> files, can you please make it generic in one place only and send the patch. >> >> On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan < >> yogesh.mahajan@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Patch looks fine. IP Addresses are prefixed by 32 and 128 for IPv4 and >>> IPv6 respectively. >>> >>> Thanks, >>> Yogesh Mahajan >>> EnterpriseDB >>> >>> >>> On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached patch to fix the default Public IP range issue >>>> in AWS deployment. >>>> >>>> @Yogesh Mahajan , please test. >>>> >>>> >>>> Thanks, >>>> Khushboo >>>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000061471605d9ed5180 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Isn't it possible to define it at a common locati= on? These types of duplicate code are error-prone since sometimes we fix an= issue at one place and forget to fix it at another.

On Fri, Mar 11, 2= 022 at 11:56 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
One is for pgac= loud standalone code for background process and one for pgadmin module.
On F= ri, 11 Mar 2022, 10:11 Akshay Joshi, <akshay.joshi@enterprisedb.com> wrot= e:
Hi Khushboo

Why there are two identical f= unctions (def=C2=A0get_my_ip)=C2=A0in two different files= , can you please make it generic in one place only and send the patch.
<= /div>

On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan <yogesh= .mahajan@enterprisedb.com> wrote:
Hi,
Patch looks=C2=A0fine. IP Addresses are prefixed by 32 a= nd 128 for IPv4 and IPv6 respectively.
=C2=A0
Thanks,
Yogesh Mahajan
EnterpriseDB


On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Pl= ease find the attached patch to fix the default Public IP range issue in AW= S deployment.

@Yogesh Mahajan,= please test.


Thanks,
Khu= shboo


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Postgres
Mobile: +91 976-788-8246
<= br>


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000061471605d9ed5180--