Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXHoq-0004yl-9s for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Oct 2020 05:46:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kXHop-0001RB-77 for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Oct 2020 05:46:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXHop-0001R4-0N for pgadmin-hackers@lists.postgresql.org; Tue, 27 Oct 2020 05:46:51 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kXHom-0000Y8-HQ for pgadmin-hackers@lists.postgresql.org; Tue, 27 Oct 2020 05:46:50 +0000 Received: by mail-io1-xd44.google.com with SMTP id z5so262191iob.1 for ; Mon, 26 Oct 2020 22:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xpN7vkOLaRVX4eNlNFrSgykidScZXO6G8pYbOJ6+o+4=; b=HVi+/IfRZOGPNuZfeW+kLyOlBHsw7flAilbHBzNVM65bfQoyxTOpGfPS0pIjP7PD6E hSiVghJ+excU6dKUyJ871SqhIVTaS2z7jr/Mc4webwmpfjNLy/hOu6C9ZZJIY7Awzgmd Xtd89ePsUdNICPsFKjkFbtPBYqIVq+UFLr6OLZmQP4r/68inFjQc327kZKrlPAApjLCX B1A8p1Y/Gl+uGRrjKT/alSa3LhSBaju8fgyZ5oVJ03O8rodCUY8QJXuxvVfrg5cpHLTB tusAqWdjI4uFQZh+eCQJbZWwx2P0CpPNEY3cfxnX+UybnR2LgliHTPU8HaKwOaaretQB Ltzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xpN7vkOLaRVX4eNlNFrSgykidScZXO6G8pYbOJ6+o+4=; b=j/0Its4c1EHNpBmPcT7/a1sx2to9ih09wOh6t8/l7ODNBsZshY/egx9AJJsIvqfVdQ 8qMPzoOgdFRZGZbTVED5Cf3LOQILfoKvZbY+xtyo50xkExosEH+3MQFYpLUeNOdj99ZN qQfUQJWzymH9HMsWL4wHx26Rupe0LWeETRSGHlE+77nm52cAe7F1gzRMxZa1FQUxZ9Vs tnvh52hkhNyrFHfksJVo16RyvF3JGoerj+OLK6zfi77J7QaKRM2KtQ+J3GNY2G/uM+Tt nNo8dbSrhw+x8mLO452BPFLibaJJaggVaEn+D2f0seVkABcEe8zrbhKJCY3nnunTqZHj d58Q== X-Gm-Message-State: AOAM532+641sWvLPBr6qoaB93wkjIW2KM472vMv7UE7eKkedv++Vhpzq uq2V9vNQU9x3ETUp4S5W6C+wkUaXbBrU9X5I+8ngbDJgOx/KlgY0fPQkMrHafRCS3dXiCsBcYm8 YfrOk4c5aSubvfC/nuqV9jgnlMhP044nmGtODmryej0TuE+Tkc+ZtIYCKVs9PFQyeaPWHbIQA/v rvGj1e9FlndGGEayPUzh6VfXflsDUSO5vYZs0RLPCNYl9KCabeestW4EmcOKAs5hIq4F5UByP17 w== X-Google-Smtp-Source: ABdhPJzaqDwVR5lqsWD78z/o+Yft6Za8MT1s2Ssxp2ngJlF4d5d72W2lStcDNIzBcAOpnSTuYcx6rNy9+F3pxi77sbg= X-Received: by 2002:a5e:8b0b:: with SMTP id g11mr575949iok.140.1603777606883; Mon, 26 Oct 2020 22:46:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 27 Oct 2020 11:16:36 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Added support to download utility files at the client To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008eb5c905b2a0920d" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008eb5c905b2a0920d Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Oct 26, 2020 at 6:24 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA minor patch to remove dead code which was introduced with this patch. > > -- > Regards, > Murtuza Zabuawala > *EDB* > *POWER TO POSTGRES* > https://www.edbpostgres.com > > > On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Added support to download utility files at the client-side. Fixes #3318 >> >> Branch >> ------ >> master >> >> Details >> ------- >> >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2ad97d0ab761ad57cf98b192ffe75e9a0d2605a >> Author: Rahul Shirsat >> >> Modified Files >> -------------- >> docs/en_US/release_notes_4_28.rst | 1 + >> web/pgadmin/misc/bgprocess/processes.py | 58 +++- >> .../misc/bgprocess/static/css/bgprocess.css | 4 + >> .../misc/bgprocess/static/img/storage_manager.svg | 13 + >> web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 44 ++- >> web/pgadmin/misc/file_manager/__init__.py | 17 +- >> .../misc/file_manager/static/js/file_manager.js | 6 +- >> .../misc/file_manager/static/js/select_dialogue.js | 3 +- >> .../file_manager/static/js/storage_dialogue.js | 45 +++ >> web/pgadmin/misc/file_manager/static/js/utility.js | 76 ++++- >> web/pgadmin/tools/backup/__init__.py | 5 + >> .../tools/backup/tests/test_backup_message.py | 34 +- >> web/pgadmin/tools/import_export/__init__.py | 93 ++++-- >> .../import_export/tests/test_batch_process.py | 244 ++++++++++++++ >> .../import_export/tests/test_create_export_job.py | 149 +++++++++ >> .../import_export/tests/test_create_import_job.py | 241 ++++++++++++++ >> .../test_import_export_create_job_unit_test.py | 353 >> +++++++++++++++++++++ >> .../tests/test_import_export_message.py | 135 ++++++++ >> .../tests/test_import_export_utils.py | 194 +++++++++++ >> web/pgadmin/tools/storage_manager/__init__.py | 75 +++++ >> .../storage_manager/static/js/storage_manager.js | 93 ++++++ >> .../javascript/file_manager/file_manager_specs.js | 18 ++ >> web/webpack.config.js | 1 + >> web/webpack.shim.js | 1 + >> 24 files changed, 1842 insertions(+), 61 deletions(-) >> >> -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000008eb5c905b2a0920d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Oct 26, 2020 at 6:24 PM = Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to remove dead cod= e which was introduced with this patch.

=
--
Regards,
Murtuza Zabua= wala
EDB
POWER TO POSTGRES


On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi <akshay.jos= hi@enterprisedb.com> wrote:
Added support to download utility files at the client-si= de. Fixes #3318

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdi= ff;h=3Dc2ad97d0ab761ad57cf98b192ffe75e9a0d2605a
Author: Rahul Shirsat <rahul.shirsat@enterprisedb.com>

Modified Files
--------------
docs/en_US/release_notes_4_28.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01 +
web/pgadmin/misc/bgprocess/processes.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 58 +++-
.../misc/bgprocess/static/css/bgprocess.css=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 =C2=A04 +
.../misc/bgprocess/static/img/storage_manager.svg=C2=A0 |=C2=A0 13 +
web/pgadmin/misc/bgprocess/static/js/bgprocess.js=C2=A0 |=C2=A0 44 ++-
web/pgadmin/misc/file_manager/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= |=C2=A0 17 +-
.../misc/file_manager/static/js/file_manager.js=C2=A0 =C2=A0 |=C2=A0 =C2=A0= 6 +-
.../misc/file_manager/static/js/select_dialogue.js |=C2=A0 =C2=A03 +-
.../file_manager/static/js/storage_dialogue.js=C2=A0 =C2=A0 =C2=A0|=C2=A0 4= 5 +++
web/pgadmin/misc/file_manager/static/js/utility.js |=C2=A0 76 ++++-
web/pgadmin/tools/backup/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 =C2=A05 +
.../tools/backup/tests/test_backup_message.py=C2=A0 =C2=A0 =C2=A0 |=C2=A0 3= 4 +-
web/pgadmin/tools/import_export/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 93 ++++--
.../import_export/tests/test_batch_process.py=C2=A0 =C2=A0 =C2=A0 | 244 +++= +++++++++++
.../import_export/tests/test_create_export_job.py=C2=A0 | 149 +++++++++
.../import_export/tests/test_create_import_job.py=C2=A0 | 241 +++++++++++++= +
.../test_import_export_create_job_unit_test.py=C2=A0 =C2=A0 =C2=A0| 353 +++= ++++++++++++++++++
.../tests/test_import_export_message.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 135 ++++++++
.../tests/test_import_export_utils.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | 194 +++++++++++
web/pgadmin/tools/storage_manager/__init__.py=C2=A0 =C2=A0 =C2=A0 |=C2=A0 7= 5 +++++
.../storage_manager/static/js/storage_manager.js=C2=A0 =C2=A0|=C2=A0 93 +++= +++
.../javascript/file_manager/file_manager_specs.js=C2=A0 |=C2=A0 18 ++
web/webpack.config.js=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01 +
web/webpack.shim.js=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01 + 24 files changed, 1842 insertions(+), 61 deletions(-)



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--0000000000008eb5c905b2a0920d--