Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Wfl-0002np-Ls for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 09:54:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l2Wfk-0002SL-JX for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 09:54:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Wfk-0002SE-D5 for pgadmin-hackers@lists.postgresql.org; Thu, 21 Jan 2021 09:54:36 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2Wff-00035Z-O4 for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2021 09:54:34 +0000 Received: by mail-io1-xd32.google.com with SMTP id y19so2836155iov.2 for ; Thu, 21 Jan 2021 01:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6WNZs6Gskybzagpiv1WKL+6p3xnjKOSZfie520owNmE=; b=fNSQlYmARMwa8L1C2NNuvWptHU1FCPEK14C5WEbLUwvT6mTaNYJOvv8gnYgXvjpH+J zG4u/BDLyumij6rhUDHeRjJeov/d0dbFcOg6TJ5upnIwFa5oCRxG7i1exPPruVj8oIjE 8NGSB7g7fUnNGsDsosXH6PyhCB9JO/hPiL1HM9tnJSbovkMWLUEW6fewo6WJQ120C4BN xEgcE9hcjceCEGb+2U9YbZ7VPnMfEY9IRwF62CMKbHgHMT/RgOYJjqRCFvsc1O/PPxs1 cuMAkdmpQyx780H53tN0gt1Uz+5fZJyxsDQHJWtDbltP44vILVdsLmO+aU5+umWm7t+o te7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6WNZs6Gskybzagpiv1WKL+6p3xnjKOSZfie520owNmE=; b=ky6Qx36RwKknM+59g3vgMbExmp10N0uvPCvsSefEE5gKdTaGyVbfoGXobD3TXjB0fU 1ukBbJG/drjDZNR3a639zA/op/mKfIOHHXwXxI1YZO1zFrjg5wlsZTKjYOnIY45C2GlM F5pv4uqhpWVnwq4Nd1knpMrgkEuMR7jp+BSqUSz+1dxsBBJ0Yo3uSjiX06b7m5z5KKf9 IBcPkoGF/jACmABjCzXgeEdYBdGan+Zm/sJYbhNDfR+3oe6YSo7yfJnjGVT0hagIWT6H /KhhpqhtWonWl0Z93RHtSxPoNrfRWIlicO44sp3m0QgKsIukfDWqoEWzLDnLJ9SIBT5j uCDw== X-Gm-Message-State: AOAM5315hiGJT+th0J49bYh1oV8ZzQx7PFQbeJLSk2hvvaRzcqN4MTCf IJIHfOYOnurRyCgtmUVhmh7ItfwV9CVpkIxvmwMvf3fM+dwNxXNyvJfWDBo5jxVLNAFbwFrNEUC iJg3DU8HhIO79/JawniogqrmJ/G7SoawolwBDvyLe4/EkfDdJo5jBdGdHdbcCODVisrG9aMbWnj 33vE6McA9Wlmcm0OHeK07AgA/l+nzvxPA6ORXV6/GTa2YReCsaaiO0CZc8HnybH4E= X-Google-Smtp-Source: ABdhPJzDc2bYPGF1caduzkMQhXylFP7khmrsSNHoLaeI88tARa5mrpmlcOhFglyVV+YdngNcCh8fb4qzZ4O105r2f8A= X-Received: by 2002:a02:3844:: with SMTP id v4mr11103004jae.1.1611222868997; Thu, 21 Jan 2021 01:54:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 21 Jan 2021 15:24:18 +0530 Message-ID: Subject: Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted. To: Dave Page Cc: Nikhil Mohite , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c2d29905b9660e99" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c2d29905b9660e99 Content-Type: text/plain; charset="UTF-8" Reverted the commit. On Thu, Jan 21, 2021 at 3:13 PM Dave Page wrote: > This seems like a very bad idea. What if the user that has left was the > user that setup 50 connections used by everyone else? > > Deleting those shared entries is (I would guess) most likely *not* what > the majority of users would want, and the current behaviour is definitely > safest. > > We should make this optional; i.e. ask the use if they want shared servers > created by the user to be deleted. If they say no, they should be > reassigned to another user; either the admin that's deleting the user, or > their choice of user (a little more complex of course, but more flexible). > > Please revert this, until the deletion is made optional. > > On Thu, Jan 21, 2021 at 9:23 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Thu, Jan 21, 2021 at 12:18 PM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Please find the attached patch for RM-6143 >>> : Shared server entries not >>> getting deleted. >>> Added code to delete shared server entries if the admin deletes the user >>> from user management. >>> >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Software Engineer.* >>> *EDB Postgres* >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000c2d29905b9660e99 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Reverted the commit.

<= div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 21, 2021 at 3:13 PM Dave P= age <dpage@pgadmin.org> wrot= e:
This seems like a very bad idea. What if the user that has left was the= user that setup 50 connections used by everyone else?

D= eleting those shared entries is (I would guess) most likely=C2=A0*not* what= the majority of users would want, and the current behaviour is definitely = safest.

We should make this optional; i.e. ask the= use if they want shared servers created by the user to be deleted. If they= say no, they should be reassigned to another user; either the admin that&#= 39;s deleting the user, or their choice of user (a little more complex of c= ourse, but more flexible).

Please revert this, unt= il the deletion is made optional.=C2=A0

On Thu, Jan 21, 2021 at 9:23 A= M Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch app= lied.

On Thu, Jan 21, 2021 at 12:18 PM Nikhil Mohite <nikhil.mohite@enterprisedb= .com> wrote:
Hi Team,

Please find the attached p= atch for RM-6143:=C2=A0Shared server entries not getting deleted.
Added code to delete shared server entries if the admin deletes the user= from user management.


--
Thanks & Regard= s,
Nikhil Mohite
Software Engineer.
=
Mob.No: +91-7798364578.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000c2d29905b9660e99--