Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDRRu-00084t-8t for pgadmin-hackers@arkaria.postgresql.org; Wed, 02 Sep 2020 12:01:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kDRRt-0001f0-4u for pgadmin-hackers@arkaria.postgresql.org; Wed, 02 Sep 2020 12:01:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDRRs-0001eZ-Rn for pgadmin-hackers@lists.postgresql.org; Wed, 02 Sep 2020 12:01:08 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kDRRo-0003E0-1J for pgadmin-hackers@postgresql.org; Wed, 02 Sep 2020 12:01:07 +0000 Received: by mail-io1-xd2f.google.com with SMTP id d18so5415794iop.13 for ; Wed, 02 Sep 2020 05:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tWbof8kLmmZrmgpcfwdZ8ON/vfPISHyUpXEMabrt7YQ=; b=N9cbKhaZsOGs7ixdkJts7SaDRp9rhk7w9yauSaEDem6A7uOmOZmNy3N3VMy1UK6kfx qQ3DYiF8mamZ5IniAXQ/hGhZTCQxTmhX9H9BAhXY07rRST+giKN2kj/VzcY7OzVw6jTB fkQx1CJ4tMqKc9vv7FhriifKPw9ROVlLssK3NauRCxZmszQXpS77cbBhWxytNJ5Q6qaZ WlAP7Po34AfKuPo55ufjqVCH55gEBVPUGBJDWBcf8dDl2QZBPtOLk/vNeUbDfksf7/0b 9GvnYD9MvW87bZUvBisoe+6MPSJD1FmaHJW0cMCcB44/qRHpfPg9xMsuouK+TQ0qowN7 tqBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tWbof8kLmmZrmgpcfwdZ8ON/vfPISHyUpXEMabrt7YQ=; b=HgPrde4HjQ1HCtVhsBqC6Nu7L5LXz/wAwcr/v/vLZqlNVmvoSGyFQ21zIsXxI19sDh +PmJTEyMl6LsxvMCJYitkgj0uzDBDOKNfEFbWs0/fj4A6ykfI2B61UuN86HLD96BDgJt W2NaRkZwTn8aI9mP/Y4QCcLC2h09Td7i1KT9Ixz6ba6i0jUhlcIzRsJF4z8Flz7FH2/2 NYXUKMM/5qWmdH0++pfk1S67P4CUNITE+JS+z4XMcNcVo2aVprJFHsVNha82PN6xROYO cayPexAx+qGET11W08y4wY4utlAQYEifjUfwatuWRB9fTWgG9hhuIgNZc7bnRPk2ror0 Kkog== X-Gm-Message-State: AOAM530wJsorc+kkS+zA6S8yGcDN72xoduCU4A8Jb4l8cpGQ2F+NeKrk 9Gz0TRN95Cnc2c3LPxP3lILUSHOdL6MheOQM34T2VZA6+c4NHjyG+vuuSyO8vW3nYGsbpSfi8cF qi1hCN3+42frOs/IqQrAv/dxgbyleRets+sgyVjlCoXuTSOpmBFmPRAGdFTpDZSXCn8Vh4dfQMC CoeCNUxEgM6y7LKHz2NA7lf9HKBKzZZ+doSLuxy8W0RBHQ94ULLMOZ1w7lBw== X-Google-Smtp-Source: ABdhPJzm3FxThbleJfsxMqf0Yb1EiuKCDL4zUi5zfAvKEZ9+BrPvYOTiSSRyYYAxaCA/sxuuLSCzJ++CLgKEYgguAfI= X-Received: by 2002:a6b:194:: with SMTP id 142mr3157406iob.18.1599048061290; Wed, 02 Sep 2020 05:01:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 2 Sep 2020 17:30:49 +0530 Message-ID: Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000adb32005ae5363a7" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000adb32005ae5363a7 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Sep 1, 2020 at 3:34 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch reduces cognitive complexity as below: > > web/.../server_groups/servers/pgagent/__init__.py - 23 to 15 > web/pgadmin/utils/driver/psycopg2/__init__.py - 23 to 15, 17 to 15 > web/setup.py 77 to 15 > > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000adb32005ae5363a7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Sep 1, 2020 at 3:34 PM A= ditya Toshniwal <ad= itya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch reduces cognitive complexity as below:
=

web/.../server_groups/servers/pga= gent/__init__.py - 23 to 15
web/pgadmin/utils/driver/psycopg2/__init__.p= y - 23 to 15, 17 to 15
web/setup.py 77 to 15

Please review.
=
--
=
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbp= ostgres.com
"Don't Complain about Heat, P= lant a TREE"


--
Thanks & Regards
Akshay Joshi
<= div>pgAdmin Hacker | = Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

<= /div>
--000000000000adb32005ae5363a7--