Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKeZT-0001Sd-38 for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Sep 2020 09:26:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kKeZQ-0002LJ-VH for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Sep 2020 09:26:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKeZQ-0002KU-Gi for pgadmin-hackers@lists.postgresql.org; Tue, 22 Sep 2020 09:26:44 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kKeZM-0002Fs-Ue for pgadmin-hackers@postgresql.org; Tue, 22 Sep 2020 09:26:42 +0000 Received: by mail-il1-x131.google.com with SMTP id y2so5915700ila.0 for ; Tue, 22 Sep 2020 02:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7KiEAEI6QFW/W+bDv4CkFnuLSthmpR0rZDL8gHeP5l0=; b=2JD36TdzHDyvt9vL+jp5aPbbU9FxcblRwsfiC4SPyc9HOMPzySefSnJ+6Wu0grdBUM 7tbswBKJRZfSdZAnBpL5fXtfY/ZvL9t1G59RCLSIDAz0k4oNJ78m7HtascHRwT2GNq5S Osmk40jyu7UyZHBN22KdgQNsBfMzavQjXMJiL34/hZDPjgr59+I3Ztll0zD7BCEbPBbU cHFTDBKU4CJ7lSjr1EB4G78of1l8AHqWbH1JpcDzRhF3ZFhA0D25JoCSNzsGDvmfVvby 7wYT7xb3/IFtjyL2aEA+8/gXtQZcQ1LvCbhz19EdM3MeE+4otsudCrv9+ZDi7LAbNlxq uOoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7KiEAEI6QFW/W+bDv4CkFnuLSthmpR0rZDL8gHeP5l0=; b=EHirV6Y6QsI+fQ5qKxrPO/hYg0FKta3P86BlYHG4uppBD7cxD/wM3hvQXPvpuEsaeV LL6vRh2Gq4SmMk8gsZUOkezvb15Md8RvZYcXMtRsOI7Mj8fG+eY2FtPd+F4ZFwOmWzcL 5V0yoJ+MA4PiILK7jf9UkIOyPoJkbCVog7e1NTQTSALawDntckGdfcWdR+1oavNNcCfm Q4acdNqzfquKgYZ0qpB4HOZqK3j+STV55PnfW/rZQuDgfRP+dp39yzgOn+29m/2hyd1d QfPeAxQoBpuXJl3WB4/dEkXZHvdKGzUF/MMpN/PL7fge6uss6LWlz597EmHu+6XrrTxf bbVA== X-Gm-Message-State: AOAM530vGHcabkj/+NTcy+/UlQ5dim8vurITdnr7iHkjT3prlxmswvUb 4RbbDHNEFLs8ZZXg4MmqspV36oZTE0lHhV1m26kfW/CxGKeru1zejYbMjsqU+cwz+cFJ4eOM/CM Z2DiddO4r6eX+7pt5oZSSJze56doPrPN5ewJua59CNjMPBmwjXedvL66LQnLrS3tUje/GSLw7HS ls8ZQ4aC0j0iKqid49aUXsL36+AbzsPsqSH6pTNH4epiWjPdxzGv38Cb8XmB3rv4E= X-Google-Smtp-Source: ABdhPJyTeQ6p22L5EZ6iXaYcI7tLW6cTXzwf0uhvQeNd/atHUxknhK+2uSRxx+Zaa26DZ0hI/S+haGcrMHmRVuWCoBU= X-Received: by 2002:a92:cd06:: with SMTP id z6mr3390511iln.252.1600766800036; Tue, 22 Sep 2020 02:26:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 22 Sep 2020 14:56:29 +0530 Message-ID: Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000007c26b405afe3905f" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000007c26b405afe3905f Content-Type: text/plain; charset="UTF-8" Hi Aditya The patch fixes only 1 code smell and introduce 1 new. Please fix those and resend the patch. On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached path will reduce the cognitive complexity as below:web/pgadmin/misc/file_manager/__init__.py > 40 to 15; 43 to 15 > > Please review. > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000007c26b405afe3905f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya

The patch fixes only 1 code s= mell and introduce 1 new. Please fix those and resend the patch.

On Tu= e, Sep 22, 2020 at 11:04 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:=
Hi Hackers,

Attached path will reduce the cognitive complexity as below:we= b/pgadmin/misc/file_manager/__init__.py 40 to 15; 43 to 15

Please review.


--
Thanks,
Aditya Toshniw= al
pgAdmin hacker=C2=A0| Sr. Software Engineer | <= /font>edbpostgres.com=
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--0000000000007c26b405afe3905f--