Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJbjp-0000oL-Tr for pgadmin-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 11:40:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jJbjo-0006sd-QM for pgadmin-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 11:40:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJbjo-0006r6-Fa for pgadmin-hackers@lists.postgresql.org; Wed, 01 Apr 2020 11:40:52 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jJbjl-0006sD-JT for pgadmin-hackers@postgresql.org; Wed, 01 Apr 2020 11:40:51 +0000 Received: by mail-io1-xd41.google.com with SMTP id o3so19694017ioh.2 for ; Wed, 01 Apr 2020 04:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8XkGgpPCOi53pM7IeOqLwGhBK0XF102K6EDS9t06APE=; b=1u3rgRxXFkLeehUx+jLyANCpETBRfCmEZ1WBYLdGpIw0w1dSsGu9XrEx55HQm9RnRF HWZAzgoqR0HPIjT6dSoB0oB3WDT1/jQXjpO47/jtlPjVvISvYNu3924fhV/poWkdC+/7 Z2jcJBpbj43mQ6fMPjdLAQYG/Gkx/+/urUpjhpFiPQLBRimlMdr4Qq1nE1n845xe6Gvh 9LHU8glyLFt2AZWPirikt37JfelDhhVGwV5LfpXnapBC+scW1I2WmhsDpWMPrmJAKUke JMBPrenoJp534JC7yhzo4Q2B7Bt4nNLH2ab0k+c2cQ1sOGflpOriFN2PaRfg2c2wfAl4 Qzgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8XkGgpPCOi53pM7IeOqLwGhBK0XF102K6EDS9t06APE=; b=OdPlYQJiJ4SfWDIKc7zKKPkuDRlgdXZfHEvNrDXIr15DPcWFCcysMRYCRuEECcT9Qk X1fu7T2yh4o40EmJWILN1z4g7zdSrrOwjr2RXWLpRGf0wP8gwuMwMogna54HKd/8lThX RjWPOrOhXgR1n6aPLo2COgyjWC9uh57sMllmnGWVbyVfqv/qq6JItaILBtCuBd/BNXLk WdQpfD2C3A2wmYwLHXAtHiqlbvtmuYUMpeoBjAAMGcnmgeASh8dCQy4UID8/8v8RTvHg uNLAariACiO0OPwCWkRCLTTtfm+i5VexLMjKpeKEiQTwf3Ok/dcVPV518eDhP9s0LdQk UQKA== X-Gm-Message-State: ANhLgQ3IeDZat+oYp0xACR7iTv9IRxqm/+vUG62NiBM+fxB8B3fyRbAl eQAePCRHiBn0nYtc25nZsMzqe/OIief46bZwfFaFaACMQr4/FdjMX4FRkZYLtHkuyuMfqkTuNt0 dbDNd1HVcXU0X0FadCyH62f4a+h0IlqjlnaDRxmsLyfrCMWjU/Ehy9wpa+JDH5lUQMGKACb9wqe P4e3ZwKzZFKiUG0mY3OLoAgivl0Ae6XDE+YVmyo3OWb4I4/zXZI5Y= X-Google-Smtp-Source: ADFU+vueu/ZlY2KLBLLrPoBkpKGIEg3n0FKm0Q2JBRZOAC+ATaFU6tLWFuA5rzxODYNosxamIW9GfEbHm/4iMwK+i+A= X-Received: by 2002:a02:708c:: with SMTP id f134mr19335624jac.1.1585741246428; Wed, 01 Apr 2020 04:40:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 1 Apr 2020 17:10:35 +0530 Message-ID: Subject: Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b329ec05a2392703" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b329ec05a2392703 Content-Type: text/plain; charset="UTF-8" Hi Aditya Tested on 9.6, test cases are fixed but wrong SQL generated for tables: CREATE TABLE public.test ( col1 bigint ) WITH ( OIDS = FALSE,, parallel_workers = 56 autovacuum_enabled = TRUE, Also parameter parallel_workers is not showing until we enabled the autovacuum parameters. Please fix and resend the patch. On Wed, Apr 1, 2020 at 3:35 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Akshay, > > On Wed, Apr 1, 2020 at 2:51 PM Akshay Joshi > wrote: > >> Hi Aditya >> >> API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above. Please >> fix and resend the patch. >> > The SQL is corrected for 9.6 versions. Others seems to be working fine. > Attached is the updated patch. > Please review. > >> >> On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is a patch to add support for parameters toast_tuple_target (PG >>> v11+) and parallel_workers(PG 9.6+) of table. Refer - >>> https://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS >>> . >>> >>> Both the parameters are added in the advanced tab of table dialog. >>> >>> The patch also fixes a related issue - RM5180, where autovacuum_enabled >>> parameter is added automatically in the RE-SQL when table has been created >>> with WITH parameter. >>> >>> Please review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000b329ec05a2392703 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya=C2=A0

Tested on 9.6, test cas= es are fixed but wrong SQL generated for tables:
CREATE TABLE pub= lic.test
(
=C2=A0 =C2=A0 col1 bigint
)
WITH (
=C2=A0 =C2=A0 = OIDS =3D FALSE,,
=C2=A0 =C2=A0 parallel_workers =3D 56 =C2=A0 =C2=A0auto= vacuum_enabled =3D TRUE,

Also parameter=C2=A0p= arallel_workers is not showing until we enabled the autovacuum parameters.<= /div>

Please fix and resend the patch.

On Wed, Apr = 1, 2020 at 3:35 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

On Wed, Apr 1, 2020 at 2:51 PM Akshay Joshi <akshay.jos= hi@enterprisedb.com> wrote:
Hi Aditya

API/RESQL = test cases are failing for EPAS/PG 9.6 and maybe above. Please fix and rese= nd the patch.
The SQL is corrected for 9.6 version= s. Others seems to be working fine. Attached is the updated patch.
Please review.=C2=A0

On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal <aditya.toshniwal@en= terprisedb.com> wrote:
Hi Hackers,

=
Attached is a=C2=A0patch to add sup= port for parameters toast_tuple_target (PG v11+) and parallel_workers(PG 9.= 6+) of table. Refer -=C2=A0ht= tps://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREATETABLE-STORA= GE-PARAMETERS.

=
Both the parameters ar= e added in the advanced tab of table dialog.

The patch also fixes a related issue - RM5180, where=C2=A0autovacuum_en= abled parameter is added automatically in the RE-SQL when table has been cr= eated with WITH parameter.

Please review.=

--
<= div dir=3D"ltr">
Th= anks and Regards,
Aditya = Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2= =A0Pune
<= div>"D= on't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000b329ec05a2392703--