public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][RM6239] Explain plan and geometry viewer is not working
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM6239] Explain plan and geometry viewer is not working
@ 2021-02-19 08:34  Aditya Toshniwal <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2021-02-19 08:34 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached patch fixes explain plan and geometry viewer issues.
Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM6239.patch (1.6K, 3-RM6239.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index d9ffd27ca..85d5956ef 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -6,9 +6,10 @@
 // This software is released under the PostgreSQL Licence
 //
 //////////////////////////////////////////////////////////////
-/* This is used to change publicPath of webpack at runtime for loading chunks */
 /* eslint-disable */
-let __webpack_public_path__ = window.resourceBasePath;
+/* This is used to change publicPath of webpack at runtime for loading chunks */
+/* Do not add let, var, const to this variable */
+__webpack_public_path__ = window.resourceBasePath;
 /* eslint-enable */
 
 import {launchDataGrid} from 'tools/datagrid/static/js/show_query_tool';
diff --git a/web/webpack.config.js b/web/webpack.config.js
index 642b508cb..e81ffc01a 100644
--- a/web/webpack.config.js
+++ b/web/webpack.config.js
@@ -47,6 +47,8 @@ const providePlugin = new webpack.ProvidePlugin({
   pgAdmin: 'pgadmin',
   'moment': 'moment',
   'window.moment':'moment',
+  process: 'process/browser',
+  Buffer: ['buffer', 'Buffer'],
 });
 
 // Helps in debugging each single file, it extracts the module files
@@ -534,11 +536,6 @@ module.exports = [{
           ],
         },
       },
-    }, {
-      test: require.resolve('snapsvg'),
-      use: {
-        loader: 'imports-loader?this=>window,fix=>module.exports=0',
-      },
     }].concat(themeCssRules('standard')),
     // Prevent module from parsing through webpack, helps in reducing build time
     noParse: [/moment.js/],


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM6239] Explain plan and geometry viewer is not working
@ 2021-02-19 09:00  Akshay Joshi <[email protected]>
  parent: Aditya Toshniwal <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2021-02-19 09:00 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Thanks, patch applied.

On Fri, Feb 19, 2021 at 2:05 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached patch fixes explain plan and geometry viewer issues.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2021-02-19 09:00 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 08:34 [pgAdmin][RM6239] Explain plan and geometry viewer is not working Aditya Toshniwal <[email protected]>
2021-02-19 09:00 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox