Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9joN-000410-Gc for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Feb 2021 07:21:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l9joM-0008Bc-EE for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Feb 2021 07:21:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9joM-0008BV-7z for pgadmin-hackers@lists.postgresql.org; Wed, 10 Feb 2021 07:21:18 +0000 Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9joG-0008Of-Hw for pgadmin-hackers@postgresql.org; Wed, 10 Feb 2021 07:21:17 +0000 Received: by mail-il1-x129.google.com with SMTP id m20so930217ilj.13 for ; Tue, 09 Feb 2021 23:21:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HkdCaUX9D+o0I5V+hAIDXw0gw4Z4l2PsCv9LtHBr9JQ=; b=KSI9daqqVtTvIXc0B8KPtaRRpFKa1ULANw7SqZE0BDQ/1eMRzn7Fz9HzbxfzQZNA8A f73oLrejrbzIC9JJDMpur3TMv9LKJDVeY60bBg466m6Z7IpNmVn9Za2cIwyCZAiiFq7h I041CGpq7aAt06jGXEz6G5BnrRM/5R7iZhpDQBTTwvHUU3VeXhR7XoRFViyWIC3A86SA XfFp5BheXZ2QukxMeZbvd3lHhTCJC3asWaY43dMldTvV+PUnRZIvTodAjXubMnMNtptU zy2ZbewPDfQTijH9G6fuaWEL6ZkO19eqNWm0EDw8SWorgIlbCxnHYU5luvhgjcV6+hXr wztw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HkdCaUX9D+o0I5V+hAIDXw0gw4Z4l2PsCv9LtHBr9JQ=; b=HWO6/vjKddR0BsJROzs2x0C5o9jTyxyGlq8NgKwtzEo70I2avvLlM5wnvksZYcGVfU ze6eb8DxvRzZckO6ZRsv5ZYVyV/47gn8hIMUIVilCbmL4Jn9NXkJRA5DHZuwEABbaibx +APaN6GpP+f3HTizc8ko3glVOCNZwOoVr8N6k69geDV2InLapow252DXP0aqqX9RHnpc eZPx+teVoZOIelQ+rHqckjuQDbyUBoh0tX6IIbaby0uHYmtuEWFVUlRwYff+WMhu5MiL mrbGBOxSEd0x8+/OZ92bIm1joRhCpnNhDy5wiMaPSaSu3sNp8/F3IOUGfEpLAiSyDOJr EatA== X-Gm-Message-State: AOAM533kjthAgYqCzLLgBuVnR8eZ80aG7ATmdgqKj/JvY+r/wTZWqk83 yFG15u2OPsgCCilK9JhCabgx05YV2E+fZBko6PdXfO251657QG5YV18LGVLx6J9umJRQhz57Yfq 7H94kW+NCjHWeIZGcGlInHqNK9xMcokFXU4SCjQIMNa9bJGfC768+OMHClV8/Gz9IZ0r1RGcjfD Px9kRfvH8onHkn+FZdxD955RFucfUL43LTbHsOQWQV1mjE91C1w5MtJwmkAg== X-Google-Smtp-Source: ABdhPJydlUYaaMYJ3Acu7B/+VyR4sEgyBBSl5O8vSZN3AuawDwzGOR1DRmyaRSc9pJewOnbStKgSW45hmac5F86ZOCQ= X-Received: by 2002:a05:6e02:1a4d:: with SMTP id u13mr1798513ilv.176.1612941670519; Tue, 09 Feb 2021 23:21:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 10 Feb 2021 12:50:59 +0530 Message-ID: Subject: Re: [pgAdmin][RM6207] Update JS dependencies To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000050b07d05baf63f3f" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000050b07d05baf63f3f Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi > wrote: > >> Hi Aditya >> >> One jasmine test is failing, please fix that and resend the patch. >> > It was failing because of a side effect of some other test case. Fixed. > > Please review. > >> >> On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to update the JS dependencies to latest. Changes >>> include: >>> 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking >>> changes, so updated multiple webpack plugins and changed the config >>> accordingly. >>> 2) Replaced iconfont-webpack-plugin with a more maintained >>> webfonts-loader. >>> 3) Replaced deprecated babel-eslint with @babel/eslint-parser >>> 4) Replaced optimize-css-assets-webpack-plugin with a more maintained >>> css-minimizer-webpack-plugin >>> 5) Updated all other JS packages and made the required code changes. >>> >>> Note, there is an update available for slickgrid and I tried to update >>> it. But it was not working as expected. So without wasting time, I've not >>> updated slickgrid, and can be updated as a separate task. >>> >>> Please review. >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000050b07d05baf63f3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Feb 10, 2021 at 12:08 PM Adi= tya Toshniwal <adit= ya.toshniwal@enterprisedb.com> wrote:
Hi,

On= Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi <akshay.joshi@enterprisedb.com>= wrote:
Hi=C2=A0Aditya

One jasmine test is failing, ple= ase fix that and resend the patch.
It was failing = because of a side effect of some other test case. Fixed.
<= span class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">
<= /span>
Please review.=C2=A0

On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi Hackers,
Attached is the patch to update = the JS dependencies to latest. Changes include:
1) Migrate from webpack = 4 to webpack 5. This had a lot of breaking changes, so updated multiple web= pack plugins and changed the config accordingly.
2) Replaced iconfont-we= bpack-plugin with a more maintained =C2=A0webfonts-loader.
3) =C2=A0Rep<= span class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">laced deprecated babel-eslint with @babel/eslint-parser
4) =C2=A0Repla= ced optimize-css-assets-webpack-plugin with a more maintained css-minimizer= -webpack-plugin
5) Updated all other JS packages and made the required c= ode changes.

Note, there is an update available for= slickgrid and I tried to update it. But it was not working as expected. So= without wasting time, I've not updated slickgrid, and can be updated a= s a separate task.

Please review.=

--
Thanks,
<= span style=3D"color:rgb(34,34,34)">Aditya Toshniwal
pgAdmin = hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
"Don't Complain abo= ut Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000050b07d05baf63f3f--