Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwf2Z-0000dB-PX for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Jun 2021 06:10:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lwf2Y-0000dz-Nn for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Jun 2021 06:10:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwf2Y-0000dm-C2 for pgadmin-hackers@lists.postgresql.org; Fri, 25 Jun 2021 06:10:10 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lwf2W-0000mB-4c for pgadmin-hackers@postgresql.org; Fri, 25 Jun 2021 06:10:09 +0000 Received: by mail-io1-xd2e.google.com with SMTP id o5so11329079iob.4 for ; Thu, 24 Jun 2021 23:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aowJ/HCpEfGubhfWbHys9A8C8meQmqKCVXW0A0Z51og=; b=r3agaSqZhk032MN2WRcG7UzvTwFqevR8EwYjbpl9oGMiTLY9wjZPrEDG58SglkfGdM DeY3m0jnb5VT0L9TxaX+Azx8IxWZyLGEauyo2V++/iJ84lZx6T2ZeGt2/TniCWC73BIo LE9OKlDKWh64DsAT84sd094gbB2TsVKf31FpgEPLYvRPpoglrJMRzdyA1iLg/axrIuTu I/oET/5ArGK7hgAw3cnGrPmocHKkxKHfVCmP5pxIplk6W24RIuEnJHAVweAQHKK885tL CmuThcSVjSBfRpfti/12ZKaLZHF1Yed5JdlnDt0hffIKmdWN+qls5qPA2auDgne+JuG8 PZGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aowJ/HCpEfGubhfWbHys9A8C8meQmqKCVXW0A0Z51og=; b=sk1f39lEeoseZ9gTNTCjjowApltEczI7ne6ufzDv3ycX+QAgKFHy2wHuYk3tmxf/LM sdPJa3NB6yqrXCmutG1D8ZbCW318MlQhg24dGzCIUHJjt0ZbLB89xVLWdF42Vof0Pbfr 8oZDHj6AlIgooEpg+vc6dXZ4cH+F3XOY6x1ZI/HWZZSLwwUywtAXFO9U8gb3Xu0bYYhI kroWb0WzXQCsJusp0GUoHxwaiBwV0lC6r4gQvcRa+rCA18alAKEAC+QeSF8RpsBUTAeS WevtYvE7EgXB3GNcLyhD9vh8juLhY+GlWRG3V3iq7r7XvlXmi3nR6Bdx3YcI6sViznkU Jvwg== X-Gm-Message-State: AOAM533pcLwHILq8wTK8LQLb1h38F/Ci5uit0RvijlR2VPFXoFikqZzy iwgrxTPecUfT6aOITcQdTo9KXnvbjO6maeugE0h0Y5s6nkkhTzSSOH3u4RAaqFqefZ6Gcg8BfCe 9aA+kcz72CX03pTEu1e6EvfHIq0p9yHcSYDneretHCtiCwJBwoKPJ08vNVv45gB15ge33ddKU20 OzEJmDdl1Crj0CiyP1dR54s245wVgLWoaEHl47Wx34Ht9aV6aO+X+GW7OxXA== X-Google-Smtp-Source: ABdhPJw53idvO74CpCqdz13qAJJMmFq3fI1m3frGqqR95kcEl0VBBI/iZRSleH5UMQqSkaClirQFwKfEcTO1tAJ3Irs= X-Received: by 2002:a5d:9d55:: with SMTP id k21mr7068938iok.57.1624601407391; Thu, 24 Jun 2021 23:10:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 25 Jun 2021 11:39:56 +0530 Message-ID: Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ca201a05c590fd88" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000ca201a05c590fd88 Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Thu, Jun 24, 2021 at 9:16 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch. I have moved the function into the utility > file now. > > On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Pradip >> >> I have seen that we have duplicated code for resize_the_queryTool, >> resize_the_erdtool, resize_the_psql, and in debugger_ui.js file. I would >> suggest making a common function somewhere in the utils and call that >> function. In the future, if we need to change the code we will have to >> change it in four different places. >> >> Please resend the patch after fixing the above issue. >> >> On Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Please find attached for debugger and ERD tool which was missing in >>> my previous patch. >>> >>> On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks, the patch applied. >>>> >>>> On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale < >>>> pradip.parkale@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Please find the attached patch for #6398.Detaching query editor panel >>>>> gives a blank white panel. >>>>> >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> Pradip Parkale >>>>> Software Engineer | EnterpriseDB Corporation >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000ca201a05c590fd88 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Thu, Jun 24, 2021 at 9:16= PM Pradip Parkale <p= radip.parkale@enterprisedb.com> wrote:
Hi Akshay,
Please find t= he updated patch. I have moved the function into the utility file now.

On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
Hi=C2=A0Pradip

I have seen that we have dup= licated=C2=A0code for=C2=A0resize_the_queryTool,=C2=A0resize_the_erdtool,=C2=A0resize_the_psql, and in debugger_= ui.js file.=C2=A0I would suggest making a common function somewhere = in the utils and call that function. In the future, if we need to change th= e code we will have to change it in four different places.
Please resend the patch after fixing the above issue.

On = Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,

Please find=C2=A0attached=C2= =A0for debugger and ERD tool which was missing in my=C2=A0previous patch.

On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
=
Thanks, the patch applied.

On Wed, Jun 16, 2021 at 11:29 PM= Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for #6398= .Detaching query editor panel gives a blank white panel.


--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000ca201a05c590fd88--