Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGgOy-0007ld-Hx for pgadmin-hackers@arkaria.postgresql.org; Mon, 01 Mar 2021 11:07:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lGgOw-0002gZ-FP for pgadmin-hackers@arkaria.postgresql.org; Mon, 01 Mar 2021 11:07:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGgOw-0002gS-9h for pgadmin-hackers@lists.postgresql.org; Mon, 01 Mar 2021 11:07:46 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lGgOr-0004XP-RS for pgadmin-hackers@postgresql.org; Mon, 01 Mar 2021 11:07:45 +0000 Received: by mail-io1-xd32.google.com with SMTP id g27so15879284iox.2 for ; Mon, 01 Mar 2021 03:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xHVaSczGu/FO2MZUCmxAhSijJFUcR6+1d9x0DrmGLYQ=; b=UgiiSGIgfWnqV3Wg94APwvz75fynhgJXWCDoZBDr5Bbbs+REsVvhL8CbtQa9Wkb7tv ZawK6hx7eKTzT9hfrmC53na7OmrvuP5Hl+hptkUerYb1ta8IOBxX2LrDXr5cVCIKQXx0 Fo7yWNIzcnYSEFtwvRyIJR08RmeVC9/naL9LUKhHBrpe9N0MrOOhdq1Oq9+5rQ9Kfu7Y RxPore4WJqniPq1pJn3m3agakoa0LWR1PZZM+xdLtcYftCLj7IUZT0bQCXK2KmGbfc9R jnmT9QytWSX5XiKAv54h9tQ0fi8cImlKf9szVstDtwVa+AtSrI2uV/ja0s5ZgVLmqyFM bc6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xHVaSczGu/FO2MZUCmxAhSijJFUcR6+1d9x0DrmGLYQ=; b=QLC2Rx2C9yrfXFWDW22LkHZ6wYeAoDtgaxXsylWvSHwMXQev6g2f5csiExBXepZ+Qt Y7R+WOhNT3reyuCrxcKTn3pVZ367g4uz/PnJK40nqXdbe547JXR2bX82VEB9sF0sBk8D 83pbjuXo5tDTeKmqw/CalpOfTOreDGakLfupuYH1E+aiZAtERzKF53atOsjkPrX2BEYk D9Yi6JSd9SEXwkp8VcIwRS+pzr1w1wkzGSvyquJf1ovrYSRZL1W2lYe6bye8i9UQmrDF F1t4jiDtMB36rv9nabu8xr8T1hx4UW9pORl5zuphXosuEG3sm8YBu26aEYZLG9wB1LTv s1eA== X-Gm-Message-State: AOAM533+VvTOs4R/SAKCYCewo7G7FaLblrdnTNHywWKE9yGKR0llxRY6 iAx2Kfk07KWNnf/KiOiRdaWKGSjEpb7Ou7ciCN8CPd1/jcFZbuUgizaXWrKsqirbwQKR171/Jol bdx09+d5Bnr8kogMALuN062ofLw5GtHNXuVQgIP+isIjY7D2QyyUzD4OoQcJ7Bl8c4tNbO/YkCH RSOEWgE5WOgDoq1kid+m0LkblW8oukMJ3EmPG5lmryYcnNbmZaB7Uh+qaiFAdIZoc= X-Google-Smtp-Source: ABdhPJyJLGjnrDatT3+QQohUUmVwnd9VlowfY/ue9DchMvdmZfzb8tv5qSrU4+esCxeAMAQ79iN8BPKpc7VKGoNhqFw= X-Received: by 2002:a05:6638:190d:: with SMTP id p13mr15492385jal.53.1614596859620; Mon, 01 Mar 2021 03:07:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 1 Mar 2021 16:37:28 +0530 Message-ID: Subject: Re: [pgAdmin]: Patch for SonarQube fixes. To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000046045905bc77a0dc" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000046045905bc77a0dc Content-Type: text/plain; charset="UTF-8" Hi Nikhil You forgot to attach the patch :) On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > 1. Back-form (backform.pgadmin.js): > > - TypeError can be thrown as "$tabContent" might be null or undefined > here. > > 2. User Management (user_management.js): > > - 'self' is already declared in the upper scope. > - 'res' is already declared in the upper scope. > - 'self' is already declared in the upper scope. > - 'ownershipModel' is already declared in the upper scope. > > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postgres* > *Mob.No: +91-7798364578.* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000046045905bc77a0dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Nikhil

You forgot to attach the= patch :)

On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com&= gt; wrote:
Hi Team,

I have fixed a few=C2=A0= sonarQube=C2=A0issues, PFA patch
Details as follows:
=

1. Back-form=C2=A0 (backform.pgadmin.js):
  • TypeError can be thrown as "$tabContent" might be null or u= ndefined here.
  • 2. User Management (user_management.js):
    =
    • 'self' is already declared in the upper scope.
    • 'res' is already declared in the upper scope.
    • 'self&#= 39; is already declared in the upper scope.
    • 'ownershipModel'= ; is already declared in the upper scope.

    -- =
    Thanks & Regards,
    Nikhil Mohite
    S= oftware Engineer.
    Mob.No: +91-= 7798364578.


    --
    Thanks & Regards
    Akshay Joshi
    pgAdmi= n Hacker | Principal Software Architect
    EDB Postgres
    Mobile: +91 976-788-8246

    --00000000000046045905bc77a0dc--