Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d80Lk-0001XE-Vm for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:18:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d80Lj-0005wY-Kv for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:18:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d80Li-0005wO-Sh for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:18:27 +0000 Received: from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d80Lf-0007VL-Hj for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:18:25 +0000 Received: by mail-pf0-x232.google.com with SMTP id v14so45722749pfd.2 for ; Tue, 09 May 2017 01:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=y0L0hHUqIxRxmI+DViX0jB+VFN3urQlkgObKJ/gPO+8=; b=Ac9tmmSisDKqAforHGiD/u9IGIYKCDIUn5BWDvNzorAsNu34/9TK/qxFDIiiK1kG01 VWuBb2wu+dT5YWb9fEk4eMsraHgBm8T90lkAd3Vk0nUjN61/f3eV4dFJDeCoI8T4CnuQ qyuLlmczDnI4hdKb+Is6SVfHUaa/cpNBe5NR+ceQx6ZxMPtQwivpyDvWt9BeA5ygxX8T rZtwfxMPz1XZIuoSaB5mhcmymOpQzDbnwivXxWcqnkEhpk2XCPVV/73dzFH2NpOto7dR bAUK5lPP5kV0EeGok222Ap2H1dMtmHCn2A6nROpOL3hsApk5evuMipwnI9ONWk4SkZWD aLsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=y0L0hHUqIxRxmI+DViX0jB+VFN3urQlkgObKJ/gPO+8=; b=EVrufyBnKJ81U5uo0QT1VJ1fBSRI6ULimcR4YW3cJrcMHszwxZHCZ7wtUHJazYrrNZ Dz3wKMmjBf4MgcONAk1R6nciL3R9TAKfmCfm7ipdQmKXkp8AYdJFaH2vLEaTEGsz9JWs W0cAB8oO/hORFRdlTlV93wX9O4j9Ts2xlbgk4ugEfHJ1uV/lusw1b4AIi5EkacAgK1uT m1RHxrLhyKvEKX2gkWXqPuiSaW9PV2U9+4yp/MtWtU/3A8YxQcegDDmaze76CbS3ICpZ PjvMy563NpPGi+qvyzn55j2k8for90OJ5UKDovBxqD4j7Zje3msqYjjuOLRrKDHNQ6LH oD2A== X-Gm-Message-State: AODbwcDzoCS9qZ/oehWL/MBsyw4Aw6gl10eJQONYYT86/5NZaP2196aW +37z9IjgQvba7u0otBA5sNN276kK62VP X-Received: by 10.84.135.34 with SMTP id 31mr3362767pli.99.1494317902160; Tue, 09 May 2017 01:18:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.170.75 with HTTP; Tue, 9 May 2017 01:18:21 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Tue, 9 May 2017 13:48:21 +0530 Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Dave Page Cc: Neel Patel , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c11ac32bd7abd054f12ff08 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c11ac32bd7abd054f12ff08 Content-Type: text/plain; charset=UTF-8 Hi On Tue, May 9, 2017 at 1:42 PM, Dave Page wrote: > This appears to have made Jenkins get all angry and red :-( > > https://jenkins.pgadmin.org/ > We(Neel and I) have tested it and working fine. > > > On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: >> >>> Akshay, could you review this please? >>> >>> Thanks. >>> >>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel >> > wrote: >>> >>>> Hi, >>>> >>>> Please find attached patch file with the fix of RM #2328 - [Runtime]: >>>> Unable to launch query tool and debugger in new browser tab. >>>> >>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>> >>>> https://github.com/annulen/webkit/releases >>>> >>>> >>>> As there was a bug in QWebKit regarding "unload" event. We have raised >>>> and also they have provided patch file to fix this issue. I have applied >>>> the patch in linux and compile the webkit and tested the attached patch >>>> with compiled webkit which is now working fine. >>>> >>>> Below is the link for reference regarding unload issue. They have >>>> provided test webkit release for Mac in below URL but for other platform we >>>> need to apply the patch and compile the webkit until they provide >>>> webkit-releases for all platforms. >>>> >>>> https://github.com/annulen/webkit/issues/519 >>>> >>>> Do review it and let me know in case of any issue. >>>> >>>> Thanks, >>>> Neel Patel >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --94eb2c11ac32bd7abd054f12ff08 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

On Tue, May 9, 2017 at 1:42 PM, Dave Page <dave.page@enterpri= sedb.com> wrote:
This = appears to have made Jenkins get all angry and red :-(

<= a href=3D"https://jenkins.pgadmin.org/" target=3D"_blank">https://jenkins.p= gadmin.org/

=C2=A0 =C2=A0We= (Neel and I) have tested it and working fine.=C2=A0=C2=A0

=

On Tue, May 9, 2017 = at 8:39 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch appl= ied.

On Mon, May 8, 2017 at 3:21 PM,= Dave Page <dpage@pgadmin.org> wrote:
=
Akshay, could you review this please?

T= hanks.

On= Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@enterprise= db.com> wrote:
= Hi,

Please find attached patch file with the fix of RM #= 2328 - [Runtime]: Unable to launch query tool and debugger in new browser t= ab.

I have used Qt= 5.8 with webkit mentioned in below URL.



As there = was a bug in QWebKit regarding "unload" event. We have raised and= also they have provided patch file to fix this issue. I have applied the p= atch in linux and compile the webkit and tested the attached patch with com= piled webkit which is now working fine.

Below is the link for reference= regarding unload issue. They have provided test webkit release for Mac in = below URL but for other platform we need to apply the patch and compile the= webkit until they provide webkit-releases for all platforms.


Do review i= t and let me know in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company



--
=
Akshay Joshi
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;= border-collapse:collapse">Principal Software Engineer=C2=A0


Phone: +91 20-= 3058-9517
Mobile: +91 976-788-8246



--
Dave Page
VP, Chief Architect, Tools & = Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany

Blog: http://pgsnake.blogspot.com
T= witter: @pgsnake



--
Akshay Joshi
Principal Software Engineer=C2= =A0


=
Pho= ne: +91 20-3058-9517
Mobile: +91 976-788-8246
--94eb2c11ac32bd7abd054f12ff08--