Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kohv2-0000t7-Rk for pgadmin-hackers@arkaria.postgresql.org; Mon, 14 Dec 2020 07:05:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kohv1-0000xU-RF for pgadmin-hackers@arkaria.postgresql.org; Mon, 14 Dec 2020 07:05:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kohv1-0000xN-9n for pgadmin-hackers@lists.postgresql.org; Mon, 14 Dec 2020 07:05:15 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kohuy-0006hc-RI for pgadmin-hackers@postgresql.org; Mon, 14 Dec 2020 07:05:14 +0000 Received: by mail-il1-x142.google.com with SMTP id r17so14850959ilo.11 for ; Sun, 13 Dec 2020 23:05:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1GrZ9lB/AYbHpuNfsuEr4RT5qhnx7P9Rt04xXEnu0kk=; b=Lc2s3lzyR2UWjDi0vFwce6TDbs+Y0foA7A8hM+J6lyYSL2Dh9KFGhMTpjgaxb1KyXX Oftp0hLlZpGyR+0BA8iloANect9Kwo25BNm4wwpLbLY0xijnTLXJP/+jC3d6Emebi6n8 7rvaGikESo/6/vEdUe9GKD72+kwMBwYc4qzt5dDlkhfhmbhW58I4Ih6QygK0z+t5Wv8l JBtL41FvE1B3/HYyQzFYhbmzVNp8YYOQkmjrN4Pey/aWNM3kQbckfQvlqWCb1jvHrE34 9da5ApF0eT3CxpfYtseCkQZ+lYSXIh/KqNB/brDMsFgfVjVr5Yydtbr6A3vC8gmbtTsg MUOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1GrZ9lB/AYbHpuNfsuEr4RT5qhnx7P9Rt04xXEnu0kk=; b=dsvbNKr+E9Jmg5JZrJ/Zn8A/x0HofxlAC1D17WX+hMBYzMrlyQW4Qm7m8Ov2Oqlj4s tdB/XVUPk3ZvHW3MoO+swHqb2AEigy6wUvS5ryqp8GPvlI+dZHbPRFZQMjDqW8sVEP1/ bUkiTEJxWZgaq9GZl+9KwZ1J9IPdBr0uqLPexTDDVegA0xPKL2PO8tWbPhFx6MxdY6IK fE7F8tEJZNEttfx/0v2pFwD45ecLSHKuDbkW/jbYliabqVXE1cTugs/0GQ6/mXQV4+4Q QYFlZeFJBGRnLD1IXL41OBaBFU9kEkuLFGR1GfjDZ1rEJ/S/PleQk64E6rpOiyVEH8Gl rMmw== X-Gm-Message-State: AOAM533ELEEMrlUe8955qE/CNCuQnDGgq3rkBwqaG1O8PlIzqoKjGANa P6E6N0aguC7rBmVlWfoCdV3EI7KyOT/XbQChxax1V5H1ilJt6jaiGZtueP9X/TqEEUBg874Q1Yq 9BMR42HPJHgpxA9yJ95NRk2NT1p7tPpekiMfujer1XqD+Y8gKVBUi+Sy6ZC5PHuVmZyg44WNCtE hAWxe03b0qaZ9s2qmkOYJtPC9meeinHrMHCdOYcfIeQh5KNdG3c5c/eKRaPw== X-Google-Smtp-Source: ABdhPJzKm8pJgI7k02d6hjap6A9msJQBwzy8i6rxG77qmlwWR6QTFuI9/m74HuVDljalyCuPfqLTzDxcpXswseFgegQ= X-Received: by 2002:a92:6706:: with SMTP id b6mr35099812ilc.121.1607929511994; Sun, 13 Dec 2020 23:05:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 14 Dec 2020 12:35:01 +0530 Message-ID: Subject: Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results To: Aditya Toshniwal Cc: Rahul Shirsat , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000006303a605b66743e3" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006303a605b66743e3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, patch applied. On Mon, Dec 14, 2020 at 11:55 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Rahul, > > The file in the patch - > *web/regression/javascript/sqleditor/query_tool_preferences.js* is a copy > of *web/pgadmin/static/js/sqleditor/query_tool_preferences.js* and is not > a test case file. > > @committer - Please remove the file > *web/regression/javascript/sqleditor/query_tool_preferences.js* before > committing. > Apart from this, the patch looks good to me. > > > On Thu, Dec 10, 2020 at 6:55 PM Rahul Shirsat < > rahul.shirsat@enterprisedb.com> wrote: > >> Hi Aditya/Akshay, >> >> On Wed, Dec 9, 2020 at 2:59 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hello Rahul, >>> >>> Found below issues: >>> 1) The data grid is not fetching more than 1000 records now, gives a >>> console error: >>> sqleditor.js:1264 Uncaught TypeError: self.enable_disable_download_btn >>> is not a function >>> at child.fetch_next (sqleditor.js:1264) >>> >> *Fixed* >> >>> >>> 2) The sqleditor test cases are failing. >>> >> *This has been taken care of, and added more test cases. * >> >>> 3) Fix pep8 issues. >>> 4) Fix linter issues. >>> >> *Sorry for these issues, last minute code changes* =F0=9F=98=A3 >> >>> 5) Please check the doc changes again, it's not clear to me. >>> >> *This has been corrected now.* >> >>> >>> I didn't check but make sure the GUI tests for the sqleditor runs fine >>> since the behaviour has changed now. >>> >> *These are fixed now.* >> >>> >>> On Wed, Dec 9, 2020 at 1:53 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Aditya >>>> >>>> Can you please review this patch? >>>> >>>> On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat < >>>> rahul.shirsat@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Please find the updated patch below. >>>>> >>>>> On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat < >>>>> rahul.shirsat@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Please find the attached patch which resolves the issue of macros >>>>>> query results download, have used async cursor to achieve this >>>>>> functionality, where for downloading the results, cursor is scrolled= back >>>>>> to 0 and end of the records, and reset again while user scrolling on= Data >>>>>> Output table. >>>>>> >>>>>> QA/Reviewer needs to observe below issues if it occurs: >>>>>> >>>>>> 1. If records are more like 5000 or 10000, try to fetch records >>>>>> by scrolling at least (2000), now save the results by clicking th= e download >>>>>> button, it should save the file, and now try scrolling again, the= data >>>>>> should be shown continuously and not any abrupt end or unexpected= records >>>>>> order. >>>>>> 2. Also, the download button is now "Save results to CSV/TXT" >>>>>> where it will only get enabled when there are valid records in th= e Data >>>>>> Output. >>>>>> >>>>>> >>>>>> Also a minor fix of the add folder icon issue is also added into thi= s >>>>>> patch. >>>>>> >>>>>> -- >>>>>> *Rahul Shirsat* >>>>>> Senior Software Engineer | EnterpriseDB Corporation. >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Rahul Shirsat* >>>>> Software Engineer | EnterpriseDB Corporation. >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > --=20 *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000006303a605b66743e3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Dec 14, 2020 at 11:55 AM Adi= tya Toshniwal <adit= ya.toshniwal@enterprisedb.com> wrote:
Hi Rahul,

The file in the patch - web/regression/javascrip= t/sqleditor/query_tool_preferences.js is a copy of web/pgadmin/stati= c/js/sqleditor/query_tool_preferences.js and is not a test case file.
@committer - Please remove the file web/regression/javascript/sqle= ditor/query_tool_preferences.js before committing.
Apart from this, the patch looks good to me.

<= /div>

On Thu, Dec 10, 2020 at 6:55 PM Rahul Shirsat <rahul.shirsat@= enterprisedb.com> wrote:
Hi Aditya/Akshay,

On Wed, Dec 9, 2020 = at 2:59 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote= :
Hello Rahul,

Found below issues:
1) The data grid is not fetching more than 1000 records now,= gives a console error:
= sqleditor.js:1264 Uncaught TypeError: self.enable_disable_download_btn is n= ot a function
=C2=A0 =C2=A0 at child.fetch_next (sqleditor.js:1264)
=C2=A0= Fixed

2) The sqleditor test cases are failing= .
=C2=A0This has been taken care of, and ad= ded more test cases.=C2=A0
3= ) Fix pep8 issues.
4) Fi= x linter issues.
=C2=A0Sorry for these issu= es, last minute code changes=C2=A0=F0=9F=98=A3=C2=A0
5) Please check the doc changes again, it's no= t clear to me.
=C2=A0This has been correcte= d now.=C2=A0

I didn't check but make sure t= he GUI tests for the sqleditor runs fine since the behaviour has changed no= w.
=C2=A0These are fixed now.=C2=A0

On Wed, Dec 9, 2020 at 1:53 P= M Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Can you please review this patch?

On Mon, Dec 7, 2020 at 3= :10 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers= ,

Please find the updated patch below.
On Mon, = Dec 7, 2020 at 2:55 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wr= ote:
Hi Hackers,

Please find the attached patch which r= esolves the issue of macros query results download, have used async cursor = to achieve this functionality, where for downloading the results, cursor is= scrolled back to 0 and end of the records, and reset again while user scro= lling on Data Output table.

QA/Reviewer needs to o= bserve below issues if it occurs:
  1. If records are more lik= e 5000 or 10000, try to fetch records by scrolling at least=C2=A0(2000), no= w save the results by clicking the download button, it should save the file= , and now try scrolling again, the data should be shown continuously and no= t any abrupt end or unexpected records order.
  2. Also, the download bu= tton is now "Save results to CSV/TXT" where it will only get enab= led when there are valid records in the Data Output.
Also a minor fix of the add folder icon issue is also added in= to this patch.

--
Rah= ul Shirsat
Senior Software Engineer=C2=A0|= =C2=A0EnterpriseDB=C2=A0Corporation.


--
Rahul Shirsat
Software Engineer=C2= =A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Rahul Shirsat
Software Engineer=C2= =A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000006303a605b66743e3--