Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1imCNp-0006BL-Aa for pgadmin-hackers@arkaria.postgresql.org; Tue, 31 Dec 2019 07:56:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1imCNo-00052F-45 for pgadmin-hackers@arkaria.postgresql.org; Tue, 31 Dec 2019 07:56:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1imCNn-000528-P0 for pgadmin-hackers@lists.postgresql.org; Tue, 31 Dec 2019 07:56:03 +0000 Received: from mail-il1-x141.google.com ([2607:f8b0:4864:20::141]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1imCNl-0002dS-Bj for pgadmin-hackers@postgresql.org; Tue, 31 Dec 2019 07:56:02 +0000 Received: by mail-il1-x141.google.com with SMTP id t8so29692374iln.4 for ; Mon, 30 Dec 2019 23:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RVoyBIKEw4XX+jJHLHk9slSAve9so9OcCaDsnxk6GwM=; b=bgifedG4Kua3OWKPjur2T+G54Ferbf5EqzRBIKY98UaRBMkf7QdHdi9NJfuI/S3wlN wIGvgsL22up4Fq7Uvn/22yJ4RonqPuxqCJqmtTPi9Dts+jirBQi7chpgCRuer1Jw4DTJ Bgx0VLLUqYvZwQXAzZpTSlL86HOOS425r2AqID/mLLhXxn3wSPavBfhuNN5HWxastyhb piSxtWV0DK0qHmn3+J8A/bG1jHWQ0Ed2D7DG3ALQZ0Z0rTr7/zkyMqO+iz917vIAo564 oMgUdHFvHai4lfPDx3lRL90ssgBqh67Cby/2Qy0bLlDJ2XruivFF53/+BE17yBONTrxJ EPGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RVoyBIKEw4XX+jJHLHk9slSAve9so9OcCaDsnxk6GwM=; b=YSEPnUJqy4ARq3FwnvEDvFUoXRRb3YoPuWlyo34d505nZLfUusD+/lud2n5BREn6xl rq4MxlT/wBaYk4fcpYCUEB4qxNxmaDMtCWk1rvcKKywwb7ADY6XLmJolL9fA/7/BLXCg QH/Plgr3rI2ILu8DK4HnDLamZ3DxyrnekFersu0FUCwrFcQsQIu/VGuPbx4X5g4/thoE /vxqnSsyQEOknM/sJ/rChXV5qNohk5lecTK3gmo7Pt8LULXab4FSPsw0yiyyEgo2cvvp B+jynebJbcjPHWfV/i14Ec4/XkICj2LjFImVQDZQm2wzTHueB9qSCOAAnf5/QVIR+JkL wEFw== X-Gm-Message-State: APjAAAWzXjL6+jLoe8X+c69YlzN6zCMxOUde8UdzekAG20OSpD+O2/Kb dWGqWW0V5hQtO3cnd9B+G1qcAyN0oiwDqkCPPKrsqZZd3UgDzBiHGDC/hAXSyHhDZpoJVqrsl0/ e/d9Y9wpCDS/MO2K+C0PmsKmmC2OYkgJ6h0IojjU2pGC77EBCKHpT7EsP2+6n0lsM6+eFWcKb3x NKOmi7ZqeRZpoBmwJ7tpD+RoIPPTdw1jLZpqkxwxQHBUCsYk80otY= X-Google-Smtp-Source: APXvYqzfmiwUhGk2tksbsB/o0AkbdnqgEPWYftTrX1ArNEi+MvN+Iq+kj6B84mpMIseRveoKxjOA/x2/x0zJVGTTjOU= X-Received: by 2002:a92:3a02:: with SMTP id h2mr62568880ila.236.1577778960138; Mon, 30 Dec 2019 23:56:00 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 31 Dec 2019 13:25:49 +0530 Message-ID: Subject: Re: [pgAdmin][RM5024] Refactoring SQL of Functions and Procedures. To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000741d90059afb4ad2" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000741d90059afb4ad2 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Dec 24, 2019 at 12:57 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to refactor SQL for functions and procedures > wherever possible. > Along with this, it also fixes a bug where functions dialog data types was > showing system objects when "Show system objects" was set to False and > vice-versa. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000741d90059afb4ad2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Dec 24, 2019 at 12:57 PM Adi= tya Toshniwal <adit= ya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the= patch to refactor SQL for functions and procedures wherever possible.
Alon= g with this, it also fixes a bug where functions dialog data types was show= ing system objects when "Show system objects" was set to False an= d vice-versa.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0E= nterpriseDB India |=C2=A0Pun= e
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000741d90059afb4ad2--