Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSX6A-00064O-QZ for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 04:41:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nSX67-0001cA-Mk for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 04:41:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSX67-0001bv-4j for pgadmin-hackers@lists.postgresql.org; Fri, 11 Mar 2022 04:41:51 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nSX60-0001AJ-IF for pgadmin-hackers@postgresql.org; Fri, 11 Mar 2022 04:41:48 +0000 Received: by mail-io1-xd32.google.com with SMTP id c23so8947437ioi.4 for ; Thu, 10 Mar 2022 20:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bYXrsop0+WQ6v6tzPdrTkFiPxPZ+BgqA6689hEmAhCI=; b=YoQ3Q2z+WVJml+BHsXvXro6eRPipUc7wlcNkMgAN0ofW9/+i6ApUqZx6OLt1hmRMvj EhzgeR9LRT6+0N3Aq2/yyaS4Pm4mw9yljxbb0Bp3YrCc3RVAjlGUPZZ0KaY//DxzWYHU fgKzrgNiSjwIj1y3hD6Fa/cHwGdSmJYs695lqwVT25n5tMjgWeqX9NL26a4NP9bb6Hh5 m4nRjAzJYRere9XCiC2bU8Bdj8qWHIOFYhRL0rXxmpsmM77cmYvVCYMf0pw/aDRoWdI4 pFPnX3UuEWK++j84Sg0xJVtqaCXPA9JfH3vGTR2KsdxEgeY565SuiB/tsMlbHxZgTOb3 YR3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bYXrsop0+WQ6v6tzPdrTkFiPxPZ+BgqA6689hEmAhCI=; b=hrOiAMrhGQXhL76Xq5WAxMDS+PJqkOCYDqNic2/DWdrIrNrNxcy3exWAUXo8g6y5Wu ybfzAjZofw7DC6VMD356SX7Z22tsYhVcT28kEIjWxhe5WNZsb82fRVmINeUnJsRBW7kR T/qrVMwA3DCEolwTGrsBM2hCATRVklJc+pPbHj4ENQaB9eSGJdkgA9PrbDsQ10yvTRLh eLEyVp8/QUXDkCf2E5xZcMM4i2lNy/JZyZZyCvk1B+tRZi+hkbUDEtwuF1x0tk1cLsRD 5Hhm9AIdHBvw7XtPNS+XXxsK0+0vrxSrAqEC+8pG2JtwzdBHB0VaQp8jy/fknnuHyyEq 25QQ== X-Gm-Message-State: AOAM533NPDNFuOaD2YuL9u+MiM1wAXlgjqVPBLSseoa1jWOqUi1bLzXP 4GT2Wa8WjcTjA15mw/B1IbSCU9Markl7SkThOXPbwZzXVvLgllfn9TTK9IKCZz1p8StRBAQmF8A mGIqTCJ3z2G4no2CCSuNsQnWBEu2iWhMprwUYzEKr1WK/oxTIrQCX++qSIc5wW3m4uxOc5hXVYl zSuPeM5+DyD/6arvklVb6fyyRDx1S1FchxJMS0fCRLQKNdIZggtS6jvByCOzuMt1A6bbct X-Google-Smtp-Source: ABdhPJyDVQ00+9Orv0IKg0rT1p2GYBn6gSmOsl3HrdbBEoY2BLwKLSTfIAxzmGMvPK3+9MtUjwt7xIZ1pPQQQdlgpJQ= X-Received: by 2002:a6b:f405:0:b0:640:a963:2c24 with SMTP id i5-20020a6bf405000000b00640a9632c24mr6660829iog.110.1646973702348; Thu, 10 Mar 2022 20:41:42 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 11 Mar 2022 10:11:32 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment To: Yogesh Mahajan Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000007bb70905d9e9f213" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000007bb70905d9e9f213 Content-Type: text/plain; charset="UTF-8" Hi Khushboo Why there are two identical functions (def get_my_ip) in two different files, can you please make it generic in one place only and send the patch. On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan < yogesh.mahajan@enterprisedb.com> wrote: > Hi, > > Patch looks fine. IP Addresses are prefixed by 32 and 128 for IPv4 and > IPv6 respectively. > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the default Public IP range issue >> in AWS deployment. >> >> @Yogesh Mahajan , please test. >> >> >> Thanks, >> Khushboo >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000007bb70905d9e9f213 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo

Why there are tw= o identical functions (def=C2=A0get_my_ip)=C2=A0in two di= fferent files, can you please make it generic in one place only and send th= e patch.

On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.co= m> wrote:
Hi,

Patch= looks=C2=A0fine. IP Addresses are prefixed by 32 and 128 for IPv4 and IPv6= respectively.
=C2=A0
Thanks,
Yogesh Mahajan
EnterpriseDB

<= br>
On Fri,= Mar 11, 2022 at 8:49 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com&g= t; wrote:
Hi,

Please find the attached patch to fix the= default Public IP range issue in AWS deployment.

= @Yogesh Mahajan, please test.


Thanks,
Khushboo


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000007bb70905d9e9f213--