Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBabW-00070g-66 for pgadmin-hackers@arkaria.postgresql.org; Mon, 15 Feb 2021 09:55:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lBabV-0006mm-3R for pgadmin-hackers@arkaria.postgresql.org; Mon, 15 Feb 2021 09:55:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBabU-0006mf-Ud for pgadmin-hackers@lists.postgresql.org; Mon, 15 Feb 2021 09:55:40 +0000 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lBabQ-0004OJ-PA for pgadmin-hackers@postgresql.org; Mon, 15 Feb 2021 09:55:40 +0000 Received: by mail-io1-xd29.google.com with SMTP id a22so4274903iot.1 for ; Mon, 15 Feb 2021 01:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d9zuhIyWwJEeARJSv/klWmBRxQIR2EqzKCbKL40rGgw=; b=ovl4tMLOV58I8xta/jh/xztjqflP69Eb/qGk8lKe2tu4EExUeSoqS94oXu3i2NJ0Gv iACk0LA7nNeBtnYrq+Gs7+d86ezkhehp8VqlchuAaSxhZFNmHR8pB+hL9ZNJhuRK1DiA wFzDvBrqfVgs7OuE2a/ifEtRLu2zS5+4Bsi0LOhN+FbcfPZ/fM2pzPjfZGrvRIsI+znJ KIqf4X07/PNulep2XlLk3LIKgPyOMN5HSSiEPHwEKRbPdUGPA4pse604jczVQjTFR6OZ Tw0L+oqfbz4rVcPctYbDmnKacJn/h9tyvKgtnQHE/ouYS3mJDbk4EgAGdIXRw+gcfSbQ s+/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d9zuhIyWwJEeARJSv/klWmBRxQIR2EqzKCbKL40rGgw=; b=Z2k5qW4HoAc0XGSxFvgzkWkyBgq6kveVZeuYUnwQxlcOnDBWQyRrzuykUgIPFfjub1 DidaMA7CWaqWOmsnYQCLvm78ZZYT9iluWN5C2aGVl/lzkfDhrXLCcd9cq0MFf9k+lx1a zOTzGSQa2UzSe2+PIX9GIigG05VYQ6TyvgYenXjURomgfoAAFl9HWCyjj4uhZ5fjWBwe 5MPe3rJjDOkLmhmxRzwWLe4ClYFRkSSnilZ35SoyD9fqNWzTFDVmBiaYCDmQyzQXHO2I ypMIxnMEB0j0KHtHzZi6nxSHTltQA6YdwtN4/PMzh1jOVEGsxz7Vd6WilYKsDx0g9G9t k8Qw== X-Gm-Message-State: AOAM533NS5ISXp5LVJ5ErxRxJizLoTjL3oHlL6RlOLxWDMgwtWbNO3Yz tRXoc36k47SGYPw3HVoWI//F1COTuhvfO0kHhaDteOso9SvSt6XoY1cQMEAy+ldkBhPH+6VSVhC zbUx87zgx7rykAw7/u5WO6EFmaYXKw+dXHfr/FvyjBzD5aydKTk3oLW7Qi1xC6U20MRt/WSPPZN 3GPNA7O4TZn9PpvgnqRUomDJeWBynoJnMun2DDQH/8QNcamDeBsjZQS+/Dl2dVohXXUA== X-Google-Smtp-Source: ABdhPJwZxQCtWsbjuEFxTqmvhmFz/1N9cB3AhuED2OwzB+zvxZhiK/KKUzVZtuD2Fv/3t2VI8OiqbPJFFIP4T0kRyqk= X-Received: by 2002:a6b:d80b:: with SMTP id y11mr11488838iob.206.1613382934032; Mon, 15 Feb 2021 01:55:34 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 15 Feb 2021 15:25:23 +0530 Message-ID: Subject: Re: [pgAdmin][RM6197] Incomplete ERD image downloaded. To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ab918705bb5cfcf1" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ab918705bb5cfcf1 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Feb 11, 2021 at 4:16 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will improve and fix things except, the links are partially > rendered in case of SVG overflow. That needs to be fixed in html2canvas > library. Ref - https://github.com/niklasvh/html2canvas/issues/1486. In > addition, safari seems to be distorting the link paths. > Considering the majority of users are on Chrome and Firefox, the fix will > help most users until issues for Safari are fixed. > > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000ab918705bb5cfcf1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Feb 11, 2021 at 4:16 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch wil= l improve and fix things except, the links are partially rendered in case o= f SVG overflow. That needs to be fixed in html2canvas library. Ref - https://github.com/niklasvh/html2canvas/issues/1486. In addition, safa= ri seems to be distorting the link paths.
Considering the majority of users= are on Chrome and Firefox, the fix will help most users until issues for S= afari are=C2=A0fixed.

Please review.

--
Thanks,
Aditya Toshni= wal
pgAdmin hacker=C2=A0| Sr. Software Engineer | = edbpostgres.com
"Don't Complain about Heat, Plant a TREE"<= /div>


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000ab918705bb5cfcf1--