Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7eNu-0005do-JD for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 08:51:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d7eNu-0000jb-5u for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 08:51:14 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d7eNf-0000Kv-BA for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 08:50:59 +0000 Received: from mail-pf0-x22c.google.com ([2607:f8b0:400e:c00::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d7eNb-0006vs-Rc for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 08:50:58 +0000 Received: by mail-pf0-x22c.google.com with SMTP id v14so30082855pfd.2 for ; Mon, 08 May 2017 01:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+DYhfyjYwqrPGjy5ZX2LBuabs/CnHRkU6AQ1GRWXva0=; b=nabggmtsiNqAlFmb61/5me87hr2N95rwQ8+knFkvUz99ORs5w7L1ktoV1bGDvIdPrn 2sHI+FekpDsoCI+COFUXv0WPL7Reerry+DgMgrHeUy58a8iTroPhwplwCmdQFX06KxpF KFb2DVNFvuvrc4WVNDFY0HMU3L/x2gb1Z68iqvA9AzmBHWY56f79WhEDcZGR5H237mNU 5fx8fzJJdlE7EoYQopkBm9WsPM0k08/6jndeKuLvBFvq96xufkjydSIehgbX9PbTbCmg A7XDlfI4UpHm8JC5zoNhJcobKRf+b39WN6lVlKrSkGDrhKT4fUNEhnzPP9SkHbahGoVJ HBeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+DYhfyjYwqrPGjy5ZX2LBuabs/CnHRkU6AQ1GRWXva0=; b=GAJzLqtP9COgtZnB2B5WkTwD/qU9JbmiJ2mpm7SxQ/M6WgzYHv+3gF2zVKd+bNbGNn zPMTqkFMWMxlvUlUO7YM1DknYkzd28ITR/87BJNFhTR43/lgZbi0MfQyX22eAoUgjJT+ q8G/sgVRcIBk46ZzZmN7/vFvY33MOgWGiqMhuD5Teb3F6oZ21zjG2QxTWFknHV7WExHW aLH++WNHm/tCFx72IBEKvQ+0Gtz8Ls5lC8RlNN3TypU2amPI6OdfpKqczatd0l2vmlne jA6sSSPuLohemE8d5eljwCKsa2UtcuNflfNnYD9k5TEPm/QOGp/THwH6tlUOO/VFD9N0 QMqw== X-Gm-Message-State: AN3rC/6NlrZEKrW6kFhn/O1f3tgB+4MYHTvbQ4GUZjGJ2g7I63fg3Zbb 28bBwx+jiC69KLGFQbWL1qmzBs0KBq+X X-Received: by 10.98.106.199 with SMTP id f190mr31594777pfc.142.1494233454348; Mon, 08 May 2017 01:50:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.170.75 with HTTP; Mon, 8 May 2017 01:50:53 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Mon, 8 May 2017 14:20:53 +0530 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Dave Page Cc: Robert Eckhardt , Sarah McAlear , Joao Pedro De Almeida Pereira , Ashesh Vashi , pgadmin-hackers , Matthew Kleiman Content-Type: multipart/alternative; boundary=001a113b5a1c4223e8054eff562c X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113b5a1c4223e8054eff562c Content-Type: text/plain; charset=UTF-8 On Mon, May 8, 2017 at 1:46 PM, Dave Page wrote: > Akshay, as Ashesh is unavailable today, can you please review/commit this > ASAP? > Sure. > > Thanks. > > On Fri, May 5, 2017 at 1:18 PM, Dave Page wrote: > >> Can you get this polished off on Monday please Ashesh? >> >> On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt >> wrote: >> >>> All, >>> >>> This change in the xss testing is preventing our CI from going green and >>> is also preventing the Dependents and Dependencies tabs in Greenplum from >>> being useful. >>> >>> Can we either merge this or provide feedback as to what needs to change >>> so that it can be merged. >>> >>> Thank you >>> Rob >>> >>> On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear >>> wrote: >>> >>>> Hi Hackers & Ashesh! >>>> >>>> Is there anything else we can do for this? >>>> >>>> Thanks! >>>> Matt & Sarah >>>> >>>> On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < >>>> jdealmeidapereira@pivotal.io> wrote: >>>> >>>>> Thanks for reviewing, Ashesh. >>>>> >>>>> We have updated the patch. The headers are all consistent and we >>>>> removed the __init__.py files in directories containing only .sql. >>>>> >>>>> Thanks! >>>>> Joao & Matt >>>>> >>>>> On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < >>>>> jdealmeidapereira@pivotal.io> wrote: >>>>> >>>>>> Hello Ashesh, >>>>>> >>>>>> Thanks for reviewing the patch. >>>>>> >>>>>> We added the __init__.py files into templates to convert them into >>>>>> packages so that the tests inside of them can be found by the test runner. >>>>>> >>>>>> Thanks! >>>>>> Joao & Sarah >>>>>> >>>>>> On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi < >>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> Ashesh, can you review/commit this please? >>>>>>>> >>>>>>>> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < >>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>> >>>>>>>>> Hi Hackers, >>>>>>>>> >>>>>>>>> We found out that when you are connected to a GreenPlum database >>>>>>>>> and try to get Dependents and Dependencies of an object the application was >>>>>>>>> returning a SQL error. >>>>>>>>> >>>>>>>>> This patch splits the SQL query used to retrieve the Dependents, >>>>>>>>> Dependencies, and Roles SQL file into multiple versioned files. >>>>>>>>> Add Unit Tests for each file. >>>>>>>>> Also added __init__.py files to other test directories to run the >>>>>>>>> tests in them. >>>>>>>>> >>>>>>>> Hi Joao & Sarah, >>>>>>> >>>>>>> Why do we need to add __init__.py in the template directory? >>>>>>> I didn't understand the purpose of the adding __init__.py files in >>>>>>> the template directories. >>>>>>> >>>>>>> NOTE: The headers in those files are not consistent with the other >>>>>>> project files. >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> Ashesh Vashi >>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> >>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>> >>>>>>> >>>>>>>> Add ORDER BY into Copy Selection Feature test to ensure the results >>>>>>>>> are retrieved always in the same order >>>>>>>>> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and >>>>>>>>> skip it for versions less than 9.1 >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> >>>>>>>>> Joao & Sarah >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>> To make changes to your subscription: >>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a113b5a1c4223e8054eff562c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Mon, May 8, 2017 at 1:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, as = Ashesh is unavailable today, can you please review/commit this ASAP?
<= /blockquote>

=C2=A0 =C2=A0 Sure.=C2=A0

Thanks.
=

On Fri, May 5, 2017 at 1:18 PM, Dave Page <dpage@p= gadmin.org> wrote:
Can you get this polished off on Monday please Ashesh?
<= div class=3D"gmail_extra">
On Thu, May 4, 201= 7 at 12:51 PM, Robert Eckhardt <reckhardt@pivotal.io> wro= te:
All,=C2=A0

<= /div>
This change in the xss testing is preventing our CI from going gr= een and is also preventing the=C2=A0Dependents and Dependencies tabs in Gre= enplum from being useful.=C2=A0

Can we either merg= e this or provide feedback as to what needs to change so that it can be mer= ged.=C2=A0

Thank you
Rob
On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear <= span dir=3D"ltr"><smcalear@pivotal.io> wrote:
Hi Hackers & Ashesh!

Is there anything= else we can do for this?

Thanks!
Matt & Sa= rah

On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Perei= ra <jdealmeidapereira@pivotal.io> wrote:
Thanks for reviewing, Ashesh.
We have updated the patch. The headers are all consistent = and we removed the __init__.py f= iles in directories containing only .sq= l.

Thanks!
Joao & Matt
<= /div>

On Wed, Apr 26, 2017 at 11:= 22 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal= .io> wrote:
Hello Ashesh,

Thanks for reviewing the patch.

=
We added the __init__.py files into templates to convert them in= to packages so that the tests inside of them can be found by the test runne= r.

Thanks!
Joao & Sarah

On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi <<= a href=3D"mailto:ashesh.vashi@enterprisedb.com" target=3D"_blank">ashesh.va= shi@enterprisedb.com> wrote:
On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <<= a href=3D"mailto:dpage@pgadmin.org" target=3D"_blank">dpage@pgadmin.org= > wrote:
Ashesh, can you review/commit this please?

On = Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <jd= ealmeidapereira@pivotal.io> wrote:
Hi Hackers,

We found out that when you are conn= ected to a GreenPlum database and try to get Dependents and Dependencies of= an object the application was returning a SQL error.

<= div>This patch splits the SQL query used to retrieve the Dependents, Depend= encies, and Roles SQL file into multiple versioned files.
Add Uni= t Tests for each file.
Also added __init__.py files to other test= directories to run the tests in them.
=
Hi Joao & Sarah,

Why= do we need to add __init__.py in the template directory?
I didn&= #39;t understand the purpose of the adding __init__.py files in the templat= e directories.

NOTE: The headers in those files ar= e not consistent with the other project files.

=

--

=

Thanks & Regards,
Ashesh Vashi
<= span style=3D"font-style:italic">EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Comp= any


http://www.linkedin.com= /in/asheshvashi

=
Add ORDER BY into Copy S= election Feature test to ensure the results are retrieved always in the sam= e order
Renamed the Scenario of the=C2=A0xss_checks_pgadmin_debug= ger_test and skip it for versions less than 9.1

Thanks

Joao & Sarah


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise= PostgreSQL Company





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers






--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

En= terpriseDB UK: ht= tp://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
=
Akshay = Joshi
Principal Software Engineer=C2=A0
=
=
Phone: +91 20-3058-9517
Mobil= e: +91 976-788-8246
--001a113b5a1c4223e8054eff562c--