Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNWAT-0004CG-J8 for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 07:04:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kNWAS-0003Ko-Gk for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 07:04:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNWAS-0003Kh-4x for pgadmin-hackers@lists.postgresql.org; Wed, 30 Sep 2020 07:04:48 +0000 Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kNWAP-0007fp-EP for pgadmin-hackers@postgresql.org; Wed, 30 Sep 2020 07:04:47 +0000 Received: by mail-il1-x12d.google.com with SMTP id o9so575456ils.9 for ; Wed, 30 Sep 2020 00:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6to/zd3UDqoBH2kHe5Wo4VokkL+8/xRA/A53zdl8MCw=; b=TGrYhXI+hOAcIZQxEP+Uf8e29NQp1e9XScsOOYM4U1k1M/e9ArtjRY8nIRu5q+0sFI zAsbYu9luA+I1+R/jmBhpVYPhhmdZk1vPgA0J46l+V23xX9VmDMZCE1MCw/H4bD/V6RQ cJkDB55YtrMycMJe0dUeF0hnT6jxHLLj32nyZ1WeIRhQE63S6YBLuB+fT/DxqxwuXihc i6uNTMsbJyqmY/h4HcwEowJHq0ubjnbHIC03CzVPUsUxbZJVi9YbfQNpoxMqSVEygp/p ni0hgDuY+4cJh5jwJSpDjguLe/l462aGWtr4bezF1NrFcdv+ZnaqMnMgyuZzloiqHtcS JvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6to/zd3UDqoBH2kHe5Wo4VokkL+8/xRA/A53zdl8MCw=; b=CLAx+lYljSlUSYrYs4qqwD/CvcAQLHfbopa91/OjyB78JRaZPjC4LapZKvY3Iq/gxu WV/isuJPj5kLIbiuGOIipsutrjwn4ktgM5MnSgcqMUT42GYTJ+R0w+6hvt6r+Rx9IbxJ aM5ESDRt0Jcqvc5I8/jRXGUaBmvjPL6P43lrh7C6HrS3YXc950DYCHh2AgZEgk/062Na Q+33HQGksMl8ko+THfSS0eVYnGZMOLEjfYSehrJmvEGIEJJXdep3njn21pYYAACyOrTw OsUgsKIhtxXQbJIvEelMXm7sjVMvb5jTExlxzCkjB6Eo6WZ4sQyXYjE49hBTJEjLXkP+ OtMw== X-Gm-Message-State: AOAM530P0QLeBVz8K5WB8Ow2k78MujNt6anyC75X3zlWgeKVnqgQ12Q0 0K89W1EJtsBcbbRcaW8szhtORcJKaXHYlCcgvGwgljOYyN5jf0SapgIUoHlNN9/e51sBlgZ3as+ WrVWvOBwrRzqzld4poLf0HiqzxepzLE4pgfa9AM3Nx+wL+U52jD9mFlEqaB/oQgxRx60hEoL/ua +31dJqh3almdQc3ZphVaspWxG8TqsUmHPi5uWSEnQI9ogjSnYLEOoR3oAPrDtXxLA= X-Google-Smtp-Source: ABdhPJw3bbiL3flG/UxN/vhc0HtzvjeJbd3Srfx/k5f8Vx5OR0LnaMbFyEpjpgvCFRNss9xmOUi9IK+nyWdV20E06Q0= X-Received: by 2002:a92:9985:: with SMTP id t5mr873676ilk.121.1601449484456; Wed, 30 Sep 2020 00:04:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 30 Sep 2020 12:34:33 +0530 Message-ID: Subject: Re: [pgAdmin][RM5867]:Some properties are not getting updated correctly if the server is shared server. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a5af8a05b0828344" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a5af8a05b0828344 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Sep 30, 2020 at 11:00 AM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for the below issues. > > 1. Shared with all? changed to 'Shared?'. > 2. Hide shared server? changed to 'Hide shared servers?'. > 3. Some properties of the base server were getting updated if the user > updated the shared server properties so I fixed this issue. > 4. Fixed an issue where 'Later' and 'Refresh' button labels were > getting override on disconnect server confirmation dialogue. > 5. If the user shares an auto-detected server and other user log-in > then the auto-detected server of the second user will not be visible, the > second user will see a shared auto-detected server. > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000a5af8a05b0828344 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Sep 30, 2020 at 11:00 AM Pra= dip Parkale <pradip.p= arkale@enterprisedb.com> wrote:
Hi Hackers,

Plea= se find the attached patch for the below issues.
  1. Shared w= ith all? changed to 'Shared?'.
  2. Hide shared server? changed = to 'Hide shared servers?'.
  3. Some properties of the base serv= er were getting updated if the user updated the shared server properties so= I fixed this issue.
  4. Fixed an issue where 'Later' and '= Refresh' button labels were getting override on disconnect server confi= rmation dialogue.
  5. If the user shares an auto-detected server and ot= her user log-in then the auto-detected=C2=A0server of the second user will = not be visible, the second user will see a shared auto-detected server.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
=


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--000000000000a5af8a05b0828344--