Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8LFP-0000Ge-Iv for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 06:37:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d8LFP-0001ZY-5j for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 06:37:19 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d8LF9-0008Ej-Ix for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 06:37:03 +0000 Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d8L7h-0007Cv-ER for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 06:29:31 +0000 Received: by mail-pf0-x233.google.com with SMTP id e64so11163775pfd.1 for ; Tue, 09 May 2017 23:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fsZL9MSpOtNiDQBLI5XEH/yF6SNZQWut+IhxRbXMTW4=; b=xZMNLkw0yQUHO/SbEsnrgUb/FYRFXVce84Rbq2+UXq+Y/kYg2YgOZIHaHRK6b/Qgfv f1TUwp1qeTlJsDdt6S+bCI/1NukzYGSfTizNlcGymeLvJf/VSOAbjiSgW6peM3axYtKg MgXNzg4LjrMDPBU7osGj8vpxXz/tB1yOsM6jMFIkUNdJ+YjzgBsSuCPMPBWTq2YpunGJ 5AgpP2G70B3e0l7GGgjE4BEm8lS1oPV/kQsy/6n5aUP9JcN3pbUA9/aMX+wN8GqwNguo 8jmF1DUiqB4TSBNRqcV919qL3pgHCrv5nJZfKpg/AElIqy+CU6TLBUtjnoE3jpPum0QF 17jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fsZL9MSpOtNiDQBLI5XEH/yF6SNZQWut+IhxRbXMTW4=; b=FjUYE35DzHcVMv6dKV2//YrqijIEKTFTjPIdsdQiPF/FpyDjuyghGusb2k6RV6tdjd U9OLB6QbfOHwLUjLerKoNVtw7tYQYCH8dvG6jOQwwMDFTmlfmQyNVLTklBouae+2fAjK FlrCM1q8ZWmhWXkBxzPyiUDfu+C/4raTOwL7H++fE3MQ0g3nN9FvZRojnm8HbCcE5bN+ 35Y57LbCfm/dnCow+aZaEZkIwuAwGUpRI48zS/SrCkvfDiCPFkYDX3z/aa1n0BEeh2xV MRSA8Gq0Cof2/eplmS2GEQayjKfi0MelfgbRMmmw3oTvL6MIRltSpDiM39c8a9n6ktU6 si+Q== X-Gm-Message-State: AODbwcADPqYx6zq31OmpisjR2w3uZHO3LDOVBlpcucUtfy7YwTk5xuhy klLntq4W54QuXrqp1Yj2XnTIlEmedgUI X-Received: by 10.84.135.34 with SMTP id 31mr5649074pli.99.1494397756702; Tue, 09 May 2017 23:29:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.170.75 with HTTP; Tue, 9 May 2017 23:29:15 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Wed, 10 May 2017 11:59:15 +0530 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Sarah McAlear Cc: Dave Page , Robert Eckhardt , Joao Pedro De Almeida Pereira , Ashesh Vashi , pgadmin-hackers , Matthew Kleiman Content-Type: multipart/alternative; boundary=94eb2c11ac32711df8054f25976c X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c11ac32711df8054f25976c Content-Type: text/plain; charset=UTF-8 Hi Sarah On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear wrote: > Hi Akshay! > > >> Some test file names ended with "*_sql_template.py*" do we need to add >> that string ? > > we added this suffix after moving the tests up a level to tables/tests to > clarify what subject they applied to. we changed the suffix to "_sql.py" > > - Files "test_column_acl_sql_template.py" and "test_column_properties_sql >> _template.py" should be moved from tables->tests to >> tables->column->tests. As it's related to column. >> - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_ >> sql_template.py" should be moved from tables->tests to >> tables->triggers->tests. As its related to triggers. > > these tests are related to the sql files in tables/templates/column, not > tables/column, so moving them into tables/column would be more confusing. > > Following test cases are failing > > Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql > doesn't fail in your environment? > TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with below error: .....\test_role_dependencies_sql.py\", line 41, in assertions\n self.assertEqual(1, len(fetch_result))\nAssertionError: 1 != 0 > Thanks, > George & Sarah > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --94eb2c11ac32711df8054f25976c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Sarah

On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear <= ;smcalear@pivotal.= io> wrote:
Hi Aksha= y!
=C2=A0
Some test fil= e names ended with "_sql_template.py" do we n= eed to add that string ?=C2=A0
we added this= suffix after moving the tests up a level to tables/tests to clarify what s= ubject they applied to. we changed the suffix to "_sql.py"
<= div>
- Files "test_column_= acl_sql_template.py" and "test_column_properties_sql_template.py"= ; should be moved from tables->tests to tables->column->tests. As = it's related to column.
- Files "test_= trigger_get_oid_sql_template.py" and &quo= t;test_trigger_nodes_sql_template.py" should be moved from tables->tests to tables->triggers->= tests. As its related to triggers.
these tests are = related to the sql files in tables/templates/column, not tables/column, so = moving them into tables/column would be more confusing.=C2=A0

Following test= cases are failing
Thank you, fixed, see new= patch. Can you confirm that TestTablesNodeSql doesn't fail in your env= ironment?
=C2=A0 =C2=A0
=C2=A0 =C2= =A0 TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed = with below error:
=C2=A0 =C2=A0 .....\test_role_dependen= cies_sql.py\", line 41, in assertions<= /span>\n self.assertEqual(1, len(fetch_result))= \nAssertionError: 1 !=3D 0


Thanks,
George & Sarah




--
Akshay Joshi
Principal Software Engineer=C2= =A0


=
Pho= ne: +91 20-3058-9517
Mobile: +91 976-788-8246
--94eb2c11ac32711df8054f25976c--