Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goTJO-0004WI-DK for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jan 2019 13:20:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1goTJM-0007Lx-1E for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jan 2019 13:20:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goTJL-0007Lq-Qm for pgadmin-hackers@lists.postgresql.org; Tue, 29 Jan 2019 13:20:19 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goTJI-000454-WD for pgadmin-hackers@postgresql.org; Tue, 29 Jan 2019 13:20:19 +0000 Received: by mail-qt1-x841.google.com with SMTP id t13so22134501qtn.3 for ; Tue, 29 Jan 2019 05:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fWD4QHQejKCAuFoOYB1iZqTjXwk6D0281cSAkT/eL7w=; b=HxwNlyw0KzzftxBd+94biZNP3CFAzHzWIM+J+f2cf/57ZwjQyfUYpIzQ7RSvD+K1lf hJ6XirqOMQpSeQ8zPR5VVtwQWR/yFM+C5TmO9dI7tXVQWROckTrd4n+y/jj9OFQaEyWO sxvCgCAcMBcxh74cgGCrmiAdNoAwOwkMYXWkvnBFIpt4EwltC9ksAyYZ8c7Vw8UinwRx Y7ZpN84H9PcJkexDlW/61Q4u09ybmcX1lB6m45DPos0Gd8tMA4AFoyZ9e5l+El41JtWd az5nd10CkU/sp6R5bj1Uoq00IGjv+6UN8/DFfRjCt/ucLISSyWsQNU1h9fAIgcZmj5pm NcWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fWD4QHQejKCAuFoOYB1iZqTjXwk6D0281cSAkT/eL7w=; b=jeJyqaiTkC98/YDILXOn0Eg4eCzcrZuSdxREEhgVfHY3QzpD/Zl/cJFrG5epXhMjO3 m23QxHEdB4W8bEsFFg91XNoWhvttpgc/tvbvDcSE4RTmeifiJb+VhaCyZ37XDtQOnWcC IL1XzZ7PgR6dZO0IFd7Jw2KJIYpkpinXWGwojfeQXs3DiUNkaawzy3B7BD8XxK5eLveb BN70PUZLnEPw/73xD6VwFgu8/bEoFkXYH1zoL+eOFF4STnVr4Xk1IzwClbneJoCz3AVa CvmnDrsG9xD/RqvgdsgKETXUEbNKMGMtzQNvNWuNuW7wvvNzZH2qPaqeIZNAgC5RmB8k uSHQ== X-Gm-Message-State: AJcUukfVoV7Bn7HiDBECePXcD27IoaTQaR+zNVQ4xfIT6tozKvBeohkZ PUrHSL4NURd8tc/Ri3AXoyxU/BuSifpod7tdxxwelQ== X-Google-Smtp-Source: ALg8bN5lnnOTyskK0eXuSZqhNwqK4VEyzBJ7pj1rAutz1ARkWB7yOVN7hto4IVeh8pVv1XrVmf1ph5QPFtc1XKIY/Fk= X-Received: by 2002:ac8:3466:: with SMTP id v35mr25189737qtb.231.1548768015020; Tue, 29 Jan 2019 05:20:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 29 Jan 2019 18:50:03 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output To: Aditya Toshniwal Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000600bca058098a718" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000600bca058098a718 Content-Type: text/plain; charset="UTF-8" On Tue, Jan 29, 2019 at 6:27 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Akshay, > > The patch looks good to me. > Thanks patch applied. > > On Tue, Jan 29, 2019 at 4:54 PM Dave Page wrote: > >> Aditya, can you review this please? Once you're happy, Akshay can commit. >> >> On Tue, Jan 29, 2019 at 9:35 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows) >>> does not show Select output. Please review it. >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000600bca058098a718 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Jan 29, 2019 at 6:27 PM Aditya To= shniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi Akshay,
The patch looks=C2=A0= good to me.

=C2=A0 =C2=A0 Thank= s patch applied.=C2=A0

On Tue, Jan 29, 2019 at 4:54 PM Dave Page <dpage@pgadmin.org>= ; wrote:
Aditya, can you review this please? Once you're happy, Akshay= can commit.

On Tue, = Jan 29, 2019 at 9:35 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrot= e:
Hi Hackers,

Attached is the patch t= o fix=C2=A0RM 3697 Detached Data Output Tab (Windows) does not show Select = output. Please review it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-= 8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterp= riseDB UK: http:/= /www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--000000000000600bca058098a718--