Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZBi2-0002sJ-VS for pgadmin-hackers@arkaria.postgresql.org; Tue, 18 Dec 2018 09:30:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gZBi1-0001FA-Mw for pgadmin-hackers@arkaria.postgresql.org; Tue, 18 Dec 2018 09:30:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZBi1-0001Ex-DI for pgadmin-hackers@lists.postgresql.org; Tue, 18 Dec 2018 09:30:37 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZBhr-0002q0-GG for pgadmin-hackers@postgresql.org; Tue, 18 Dec 2018 09:30:36 +0000 Received: by mail-qk1-x743.google.com with SMTP id q1so9037341qkf.13 for ; Tue, 18 Dec 2018 01:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SLnSskBYBYXXTsdLJXkU5xMSR1WxK/EBsjBhLAPx7jk=; b=uECYTyaf+IyR5CEYbEIFU7K502uz6ZijomoUl3OozHiq1ze14PW0chog71Z/Ouboqj 7S0rPGkl3eQoxzk04SSxyIC/+tSsfQ8aUMzatsPdHbUPKO7nooz0yUaRiqrfZxVqQsfg yPVhU0qN9h53J1IFTUyk2z/KosCNX3Pg4bdFF91vL/QdfowX5FYUX/bB7EO2n71O/O+B /9S6zfuCLCS+ykNAOFS1rNuoqEP3H69QdOwe4R/Uu/T3dhzfQNxWtNlzhEt2YvUYfPhb d2B3xk/Bv4eQVUZFygebHBn7iSgFBIQYYaq8wCZ9GPdTQrlmGgyUXn1BEtKOOrxS1mqE Fbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SLnSskBYBYXXTsdLJXkU5xMSR1WxK/EBsjBhLAPx7jk=; b=a0W21hueQHwuvGDSTNt2HI2Z36iFEcQBRTzRyJ+v4pRpazLq/1HKyIkldXXNgd9BTb kQztD4syz/t6AYjpCVFY2X6W8u/G6EvXSWAeroGRYBLufLvy13TlWPWzE3h3FYIcGNSJ JTpFEiDpNajllD+gK/XBmR8vLukK49RTVV6tYkUVopwqfswXOSnzFu7Imm+mzMoCcHhs noxR32cA4pTm9gJJbrfGqr5RZtV4XZ26r40W/RNJEj/2HckPp3AnAmK3SdMwhlDRAoyj 91SukPODWLqY2EFKwnJrUah/ub3JaiNGfTxLM+ff4nvA5qY7IcfhsO4Idmwwfs8k76Lj ujWg== X-Gm-Message-State: AA+aEWZhds4HVbIKb/Uyvze6MAUGU1kbCn38gTQY9LkMnqdiI8kDqH3S /y4P+vjvuOuNPd/zKia49+/tTIfiJg9lruqXO7lNjh+PpI8= X-Google-Smtp-Source: AFSGD/U6ijUGlPGwQTNPBrhlji5yV7qVDCIz3KS7RptIVnTrERiqeBC9/n2YZKyEUgv0Vo7yWwTxe8A05u5BftNo4HI= X-Received: by 2002:a37:5741:: with SMTP id l62mr15528072qkb.44.1545125425225; Tue, 18 Dec 2018 01:30:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 18 Dec 2018 15:00:14 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001ab920057d488ce6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001ab920057d488ce6 Content-Type: text/plain; charset="UTF-8" On Tue, Dec 18, 2018 at 2:49 PM Dave Page wrote: > Hi > > On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3780 pgAdmin4 lacks ability to specify >> NULL values in CSV export. >> >> Please review it. >> > > A few points; > > - You've included code from backports.csv, but per the licence you need to > include a description of the changes made. > Sure. In that case I'll copy the complete file and will do my changes which is of two lines only. With my patch I have remove all the unwanted code from backport.csv. > > - Shouldn't backports.csv be removed from requirements.txt, or is it used > elsewhere? > Yes. Will do that. > > - If the previous point is true, then I'm fairly sure there is code in one > or more of the many package build scripts that adds an __init__.py file to > backports.csv in the venv that's created. > I'll remove that code as well. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --0000000000001ab920057d488ce6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Dec 18, 2018 at 2:49 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Dec 18, 2018 at 3:45 AM Aksha= y Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hacke= rs,

Attached is the patch to fix RM #3780=C2=A0pgAdmin4 = lacks ability to specify NULL values in CSV export.

<= /div>
Please review it.

A few points;

- You've included code from b= ackports.csv, but per the licence you need to include a description of the = changes made.

=C2=A0 =C2= =A0 =C2=A0 Sure. In that case I'll copy the complete file and will do m= y changes which is of two lines only. With my patch I have remove all the u= nwanted code from backport.csv.=C2=A0 =C2=A0 =C2=A0=C2=A0

- Shouldn't backports.csv be removed from re= quirements.txt, or is it used elsewhere?

=C2=A0 =C2=A0 =C2=A0Yes. Will do that.=C2=A0

- If the previous point is true, then I'm= fairly sure there is code in one or more of the many package build scripts= that adds an __init__.py file to backports.csv in the venv that's crea= ted.

=C2=A0 =C2=A0 I'= ll remove that code as well.=C2=A0=C2=A0
=C2= =A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--0000000000001ab920057d488ce6--