Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iU9eT-0005BQ-DI for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Nov 2019 13:22:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iU9eS-0001BM-6u for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Nov 2019 13:22:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iU9eR-0001BF-Ji for pgadmin-hackers@lists.postgresql.org; Mon, 11 Nov 2019 13:22:40 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iU9eO-0000Av-1p for pgadmin-hackers@postgresql.org; Mon, 11 Nov 2019 13:22:38 +0000 Received: by mail-io1-xd43.google.com with SMTP id i13so13206045ioj.5 for ; Mon, 11 Nov 2019 05:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5L4ONs1/3sC8H6ERFzFYAuicoBlx5E5Uikn1VXyTyJg=; b=xlaLBQuUo9ICXUBMnA5jPxFLbeapsoGQwrt36pMDcc6cvz7j2/p4eBXwCArQCWlm1t CLSEwEsXxnxq14JRSuMULdrpEV10mTm1mtY5aa4B6cuesxNrxfVxxC9W3V1+Gb9f+n96 SBxeSx9KxB55SPSKr5EQ7/UlsPi4Kq1jyY+DgVLo9R2l8Pfb+GE/Cn8n693EHcn94KlZ bNhqcfp+TwX3Bdur8cc/kf9gTA16tDD9DWT095gAe3w499uQKHQo9b/uXHEfqHX5xi3i jmRrLKDyzuDvE1/Px8JTKjgNx6vPl9hCscVAWOW6YzeSYwOBnvDx3zyKf/fDGvJam/5R QitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5L4ONs1/3sC8H6ERFzFYAuicoBlx5E5Uikn1VXyTyJg=; b=pUzGkfAto6nASa8J79Kl9L1M7kMJ09OgAx28b4Xn7LFotgayJRtHOGYzxFIimQOy2k JPd2OMmrNOHvdYx4fmWFx9cs46eDeMc53MrXgpXQaAjDFM9fAmttjTF+PkC4Rsbf5PEX +JaUvW4bX6WHVfv9hw632jrpRbdmwlAH515Aw068exUC31riGsKmM80OVVCB2huWmFK4 XL1wicO3fgh+CDuawvxXpXbm+wNy+yLWMt/2fTkTrXFUIDUChDbZgD1OX6Z39P+5TrbR cuwrZfLpwdbq+yubrr4KpR9OGRx4011Uu4E+7y4f0yVplbUDRtgeiaIZi51AEJN2nZdl yBKw== X-Gm-Message-State: APjAAAUPgnx57onK2BVeQNnrlD6Y0BcEU2idE7Qt0YD2Rfy6Y2L1f90f rYo0K8PE6FhnBsJMv1UZ7iYBTeypLnwVJr6mow28FSOdlMJLZn+POpDBYMa1/445mqOWaFocSab sPcrQFtvZe4Ee8CZQLYe/zJqgR7YGVwycu/7EIt2xD3qD7AHVq1knx6nu45p+v3SIAG7mftEIAe INcwSV/eldWmhDsPboTwrJ+41lbA4I18ZKq0aCdZ/wcJ7YBsiCg8Q= X-Google-Smtp-Source: APXvYqxoRS08l8j5RCI/yh7XRlsolAcuvZtGtcDPxor3RuE6yjFfHevXclE1Y+SbUtFKjGohc+/jSZ0kO+n98j+zU/Q= X-Received: by 2002:a05:6638:3e9:: with SMTP id s9mr26176014jaq.7.1573478554959; Mon, 11 Nov 2019 05:22:34 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 11 Nov 2019 18:52:23 +0530 Message-ID: Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme To: Aditya Toshniwal Cc: pgadmin-hackers , Ashesh Vashi , Dave Page Content-Type: multipart/alternative; boundary="00000000000054a4d305971206e4" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000054a4d305971206e4 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components. On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. > Kindly review. > > On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> Kindly hold on with the patch. Few more changes required per review by @Ashesh >> Vashi . >> >> On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for further improvements in the Dark theme colors. >>> Gray shades and other colors are changed to identify different >>> components more clearly. Few of the controls were missing the privileges of >>> dark theme, fixed that. >>> Few dashboard graph related changes. >>> As suggested, theme related code changes is removed from config.py and >>> moved to miscellaneous under a new package - Themes. Thank you @Ashesh >>> Vashi for inputs on that. >>> >>> Kindly review. >>> >>> On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: >>>>>>> >>>>>>>> >>>>>>>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Thanks, patch applied. >>>>>>>>> >>>>>>>>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < >>>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Hackers, >>>>>>>>>> >>>>>>>>>> Attached is the updated patch with few more changes and >>>>>>>>>> corrections. >>>>>>>>>> Kindly review. >>>>>>>>>> >>>>>>>>> >>>>>>>> I've committed a couple of minor tweaks - one to remove a space, >>>>>>>> e.g. >>>>>>>> >>>>>>>> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'), >>>>>>>> >>>>>>>> is now: >>>>>>>> >>>>>>>> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'), >>>>>>>> >>>>>>>> And another change to fix the word wrapping in the README which was >>>>>>>> totally different from the rest of the file. >>>>>>>> >>>>>>>> Thanks! >>>>>>>> >>>>>>> >>>>>>> Oh, and do we need all the code in config.py? I really didn't even >>>>>>> want a config option in there to turn theming on or off (what's the >>>>>>> point?), let alone 20 new lines. >>>>>>> >>>>>> The code is added after the config_local and config_distro is loaded. >>>>>> So, user won't be able to disable it unless he directly changes the >>>>>> config.py. >>>>>> >>>>> >>>>> That is clearly wrong and needs to be fixed. config_local and >>>>> config_distro should be able to override anything in config.py. >>>>> >>>>> But... why allow the themes to be updated or disabled at all? It's not >>>>> like a non-developer can add new ones, and it's not a security issue that >>>>> an administrator might need to control. In fact, it's arguably an >>>>> accessibility feature, for those whose eyes (like mine) last the day better >>>>> with a darker theme. >>>>> >>>>> Let's remove it entirely please. I don't see any good reason to have >>>>> any of that in config.py. >>>>> >>>> Intention is not to allow disabling the themes, but it's the feature >>>> implementation code. I'll move out the code. >>>> >>>>> >>>>> Thanks. >>>>> >>>>> >>>>>> I'll reduce the code a bit. >>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000054a4d305971206e4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

As per discussio= n with Aditya, we have removed customized scroll bars for the time=C2=A0bei= ng as they are not clearly=C2=A0visible with some of the components.
<= /div>
O= n Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wro= te:
= Hi Hackers,

Attached is the updated patch.
Kindly review.
<= br>
On Mon,= Nov 11, 2019 at 3:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com= > wrote:
=
Hi,

Kindly hold on with the patch. Few more changes requir= ed per review by=C2=A0@Ashesh Vashi=C2=A0.

On= Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <aditya.toshniwal@enterprised= b.com> wrote:
Hi Hackers,

Attached is the patch for further=C2=A0= improvements in the Dark theme colors.
Gray shades and other colors are cha= nged to identify different components more clearly. Few of the controls wer= e missing the privileges of dark theme, fixed that.
Few dashboard=C2=A0grap= h=C2=A0related changes.
As suggested, theme related code changes is removed= from config.py and moved to miscellaneous under a new package - Themes. Th= ank you=C2=A0@Ashesh Vashi= =C2=A0for inputs on that.

Kindly review.

On Mon, Nov 11, 201= 9 at 3:00 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wro= te:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page &l= t;dpage@pgadmin.org<= /a>> wrote:
<= div dir=3D"ltr">
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <= ;adi= tya.toshniwal@enterprisedb.com> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:= 56 PM Dave Page <= dpage@pgadmin.org> wrote:


On Thu, Nov 7, 2019 = at 2:18 PM Dave Page <dpage@pgadmin.org> wrote:

On Thu, Nov 7, 2019= at 1:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Thanks, = patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi Hackers,
Attached is the updat= ed patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - on= e to remove a space, e.g.
gettext('A page refresh is required to apply =
the theme. Do you wish to refresh the page now ?'),
<= div>is now:
gettext('A page refresh is required to apply the theme. Do =
you wish to refresh the page now?'),
And another= change to fix the word wrapping in the README which was totally different = from the rest of the file.

Thanks!

Oh, and do we need all the code in confi= g.py? I really didn't even want a config option in there to turn themin= g on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro= is loaded. So, user won't be able to disable it unless he directly cha= nges the config.py.

That is clearly wrong and needs to be fixed. config_local and config_dis= tro should be able to override anything in config.py.

<= div>But... why allow the themes to be updated or disabled at all? It's = not like a non-developer can add new ones, and it's not a security issu= e that an administrator might need to control. In fact, it's arguably a= n accessibility feature, for those whose eyes (like mine) last the day bett= er with a darker theme.

Let's remove it entire= ly please. I don't see any good reason to have any of that in config.py= .
Intention is not to allow disabling the th= emes, but it's the feature implementation code.=C2=A0I'll move o= ut the code.
=

Thanks.
=C2=A0
I'll reduce the code a bit.
=

--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise= PostgreSQL Company


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000054a4d305971206e4--