Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNuvp-0008Cu-2j for pgadmin-hackers@arkaria.postgresql.org; Mon, 13 Apr 2020 08:59:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jNuvm-0004ce-UM for pgadmin-hackers@arkaria.postgresql.org; Mon, 13 Apr 2020 08:59:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNuvm-0004cX-Fi for pgadmin-hackers@lists.postgresql.org; Mon, 13 Apr 2020 08:59:02 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jNuvi-0002nw-3T for pgadmin-hackers@postgresql.org; Mon, 13 Apr 2020 08:59:00 +0000 Received: by mail-il1-x12b.google.com with SMTP id z12so7895831ilb.10 for ; Mon, 13 Apr 2020 01:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IysvrAYObz58wV161eeuaIWJJIEpPShCKvcyS6Q2R88=; b=xS22cVEcmqYg1rU22FGBwjIfdjmSM/4CCqsndRPtHfvufUdM53HGekCmXn9IBAMK5j USkbomJtA/82MhZx0VHA7Zn9SC0JbGzfylSIvcu/YP6gNuZ/1NrxsxblBR6mIAu5gTGg ynT+Iut3FBxr/0WYJoywEKor1aNPB97zos3XyX8Elnm47hLmQfqnEguv+hJAnF301rkC 4eh9mT4EOzSzoAHLBxEikLZ2uPpR1LIeDQQZN8Of6P9oFgmuNk2ZNlJULk+RkKnvJNXS hnGWT5tIcimcmBPfOE+PvkUWaD8ML5L4xy0MAox4P94VNbVeciKNa6suAKnmVTc5Fbcr xrSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IysvrAYObz58wV161eeuaIWJJIEpPShCKvcyS6Q2R88=; b=JtYuhO2qU3ZQzJhE2BWICymD2nvSrHyUdTRFxeNsCA5koiSBfMFMkx+WvWLdxTgaVq lwKIe0HvF8t/2198leG7h3B0vrnTa8WOFtGZtPaNUdpdJnm2W5s1tpfGUezdFAklClGV 5ZxkTWEU6kVT5skgvZK6ZT4/hv/O6wViW2ihqiMQGL5r8mYDF6lkOmtkkFJeay1RCjLX CdSNQQOTqWJfj9rjtLml1T1hFlVGXlZidcXNOeU/T4KpO+SZ0D1bTMUHtphJkFoSNUCp 3o57TGxNK9VwdmFXu3v57giVfkFpNYxkXo4v80hmMFoA0xeoY2UYj03hDNUP96CpW96K oA4Q== X-Gm-Message-State: AGi0Pub4OgDturNM2Hmx1nOFxCxKBG34bGzxrBYa20q/DujBV5XfTWjT T7QAVoEiI6EzeFmB2ijrm/jgnK8ytDyjInTCHR/3GTUXfBmEOD5wfb1CtoAyhqaGoXMeSIQXLKY xWDbe7zxdjkHOaSEF/NeiF6EhhQF2WQbsek++ZGdQiG4QPY5xDp8gDuMxby4K/3lj67Kju4ivHp obNc+JIJSbPCQpHd7ni10d2v0B0vbe/f7vjot1JlNhfBppiNRQRKA= X-Google-Smtp-Source: APiQypKVRphPX8qSvyo7NSbOOGqkLLa1BVDrC6/dHP5XPOVfrDDob4hFKHQqP4nFzQbPYmMGtn9XvM/ajZVEovbqH38= X-Received: by 2002:a92:88da:: with SMTP id m87mr15165656ilh.252.1586768337094; Mon, 13 Apr 2020 01:58:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 13 Apr 2020 14:28:46 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000012e6fb05a3284b52" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000012e6fb05a3284b52 Content-Type: text/plain; charset="UTF-8" Hi Murtuza The issue has been fixed with your patch, but there is an existing issue discover with the fix. After disconnecting the server and click on Download CSV button confirmation dialog comes and user needs to click twice. Following error observed in the browser: sqleditor.js?ver=42000:1 Uncaught TypeError: Cannot read property 'apply' of undefined at Object. (sqleditor.js?ver=42000:1) at Object.callback (vendor.others.js?ver=42000:2) at Tt (vendor.others.js?ver=42000:2) at Object.Ct (vendor.others.js?ver=42000:2) at HTMLDivElement. (vendor.others.js?ver=42000:2) If possible can you please fix the above and resend the combined patch. On Fri, Apr 10, 2020 at 7:02 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > Upon downloading the csv file, we used the prompt for re-connecting to the > database server when there is a database server connection issue. Currently > the user tries to download CSV and there is a connection issue then it is > showing a python exception error. > > Steps: > 1) Open query tool > 2) Execute -> SELECT 1,2,3 > 3) Disconnect from server from browser tree > 4) Click on Download CSV button > > Current: Python exception error > Expected: It should display dialog to reconnect the server. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000012e6fb05a3284b52 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Murtuza

The issue has been fixe= d with your patch, but there is an existing issue discover with the fix.
After disconnecting the server and click on Download CSV button con= firmation dialog comes and user needs to click twice.=C2=A0
Follo= wing error observed in the browser:

sqleditor.js?v= er=3D42000:1 Uncaught TypeError: Cannot read property 'apply' of un= defined
=C2=A0 =C2=A0 at Object.<anonymous> (sqleditor.js?ver=3D42= 000:1)
=C2=A0 =C2=A0 at Object.callback (vendor.others.js?ver=3D42000:2)=
=C2=A0 =C2=A0 at Tt (vendor.others.js?ver=3D42000:2)
=C2=A0 =C2=A0 a= t Object.Ct (vendor.others.js?ver=3D42000:2)
=C2=A0 =C2=A0 at HTMLDivEle= ment.<anonymous> (vendor.others.js?ver=3D42000:2)

<= /div>
If possible can you please fix the above and resend the combined = patch.

On Fri, Apr 10, 2020 at 7:02 PM Murtuza Zabuawala <murtuza.zabuawala@enterprise= db.com> wrote:
Hi,

Upon downloading the csv file, we used the pr= ompt for re-connecting to the database server when there is a database serv= er connection issue. Currently the user tries to download CSV and there is = a connection issue then it is showing a python exception error.

Steps:
1) Open query = tool
2) Execute -> SELECT 1,2,3
= 3) Disconnect from server from browser tree
4) Click on= Download CSV button

Current: = Python exception error
Expected: It should display=C2= =A0dialog to reconnect the server.


--
Regards,
Murtuza Zabuawala
Enterprise= DB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany



--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000012e6fb05a3284b52--