public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM #4362 trigger function create script
Date: Wed, 19 Jun 2019 20:47:01 +0530
Message-ID: <CANxoLDfhrEn1E-ovPK6C-7Ra0Rd2QwpHktUmAAoN1fG_cr+GFQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxFsPN_vP3k6znphGTm7t0L3Ov3ScVhO6hsEMQztN_RDQ@mail.gmail.com>
References: <CANxoLDdq2T63tbdL+7OqfxxKkPe2PLbkSC1Bov4oEHzOcvQfLQ@mail.gmail.com>
<CA+OCxoxFsPN_vP3k6znphGTm7t0L3Ov3ScVhO6hsEMQztN_RDQ@mail.gmail.com>
Hi Dave
On Wed, 19 Jun, 2019, 19:57 Dave Page, <[email protected]> wrote:
> Hi
>
> On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix RM #4362 trigger function create script.
>> Please review it.
>>
>
> While I can see how this works, I question why we have the string "SETOF"
> in prorettypname anyway? That's a separate property, so it should be in a
> separate variable. What if I have a type called "SETOFDavesStuff"
> (unlikely, but it illustrates the point)?
>
We have used pg_get_function_result(func_oid) to get the returns clause
for function and assign its value to prorettypename variable. I have
followed the same logic for trigger function and fixed it. Similar logic
has already been used for functions.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: RM #4362 trigger function create script
In-Reply-To: <CANxoLDfhrEn1E-ovPK6C-7Ra0Rd2QwpHktUmAAoN1fG_cr+GFQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox