Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMsRw-0005a2-1q for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 12:07:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jMsRu-0007uY-Mo for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 12:07:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMsRu-0007uQ-6m for pgadmin-hackers@lists.postgresql.org; Fri, 10 Apr 2020 12:07:54 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jMsRr-0004fW-NX for pgadmin-hackers@postgresql.org; Fri, 10 Apr 2020 12:07:52 +0000 Received: by mail-io1-xd2f.google.com with SMTP id f3so1559039ioj.1 for ; Fri, 10 Apr 2020 05:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gQ6XfTszGi5pSUmUsYgBgidVcZnMHcEPOXwxsRwAXI4=; b=B45uwppWGIKUNULklzpHGE01yvtAC6GoMXHHN3jp7uOLDp441S7QzDD8tuH7EXfnhp 2rn1i3tyPadBed2d6z2ptRWhL3ebPEib0BLJF7o8hXaBIaDHIkKvsHQ+rM8MxU7aUnDN 5YkztyPAZUf3YzZxK/ebvV62EG20535pN7fle2wworOBoyS8qAGA/n9BKQyD3Hfn6rLJ +5O/mk5yfbSNcYll0+pV4Mvphg5WZGCcGnkTLsUSMUmr77P3kpS3v2euDJP8bR/2+XLl ZmKv4Jdkhny0lUzzpBIhfagUTBEz+wpZgQlvWMPprvXoU7xBH+hwkBxg43cFeLIE3Dij QmZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gQ6XfTszGi5pSUmUsYgBgidVcZnMHcEPOXwxsRwAXI4=; b=hBbAWq2OUIf3PQ35JD9k9aGdeK+4+VuUS1zTBCKnRx7LB2nFZ9ZtKRaDScuazMI4/D TwLn24+Si4b7Xso3eR47eX+yXJsZtJopvLNMnekahBnrled1+Yy548ecqOq0YaWE5RFx d0le8HXmw570+0KlD5FTx1MDlLq5RbuBjk02NfZFY+DSACq0QI8fsFlee5WUOOeuqVoS CiJJZ9F7gL/bl4jFfnXFq5peGmybDsFAoxKHTCpj6A+JI7y1TRpnc4RL5qnUkR3EQ8U3 PvRsmBOASC7pUY21pNADQvSYB6l4Uvy07TcXD6Qryeqad1NSkChRC7ZY41cSq46PtoGv PDog== X-Gm-Message-State: AGi0PubZ5SU91JXEPM5q+H/ITKiY3OsDEQKLspFRuti5m/KfSFHcHHuN azKmRxa+dNQDA0dPh+/TAzjTWp6yWlKasuMqtKMttkE2AsBMJy8xO3VKqjRiKPwbXkVanwEZs1L BoKEBax4Y/jLRFluKfq45USqBSwDDRyA/jBN7pkmtu5uU7fNQnN+78M4g4VQA9NHpLhPNeSFPnr v3r6a6jSTwuHH2IdTZiS9l9yGAYdyinpszVDvI7LIiAvrM56uj0Bo= X-Google-Smtp-Source: APiQypKGqGIRZbYUOrczgFTuqLOhrCfEE5wzNAUMjuUrUusG/uY4vytrFzb93ZOe/wqQG5EFPW5Ik18V1Rkia59yQSk= X-Received: by 2002:a6b:fc0d:: with SMTP id r13mr4055890ioh.18.1586520470681; Fri, 10 Apr 2020 05:07:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 10 Apr 2020 17:37:39 +0530 Message-ID: Subject: Re: [pgAdmin][RM5227] Cannot add user To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000164bfb05a2ee95a5" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000164bfb05a2ee95a5 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Fri, Apr 10, 2020 at 4:11 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated rebased patch. > > On Fri, Apr 10, 2020 at 3:13 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> Can you please rebase and send the patch again. >> >> On Fri, Apr 10, 2020 at 10:33 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix following user management related issues: >>> 1) Unable to add a user when there are many users. The dialog went >>> blank. Fixed. >>> 2) Error message did not have a close button. Fixed. >>> 3) When clicked on the add button, then cursor will focus on the email >>> box of the new row for convenience. >>> 4) When the dialog opens, the cursor will focus on the search text box. >>> 5) By default, "User" role will be selected when adding a new user. Also >>> removed an empty option in the roles dropdown. >>> 6) When the search filter is applied and we try to add an already >>> existing user, the validation is done only on the filtered data and not on >>> all the users data. This is fixed. >>> >>> Please review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000164bfb05a2ee95a5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Fri, Apr 10, 2020 at 4:11 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is th= e updated rebased patch.

On Fri, Apr 10, 2020 at 3:13 PM Akshay Joshi = <aksh= ay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Aditya

Can you please rebase and send the patch again.

On Fri, Apr 10, 2020= at 10:33 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wro= te:
= Hi Hackers,

Attached is the patch to fix following user management rel= ated issues:
1) Unable to add a user when there are many users. The dialog = went blank. Fixed.
2) Error message did not have a close button. Fixed.
3) = When clicked on the add button, then cursor will focus on the email box of = the new row for convenience.
4) When the dialog opens, the cursor will focu= s on the search text box.
5) By default, "User" role will be sele= cted when adding=C2=A0a new user. Also removed an empty option in the roles= dropdown.
6) When the search filter is applied and we try to add an al= ready existing user, the validation is done only on the filtered data and n= ot on all the users data. This is fixed.

Please review.

=
--
<= div dir=3D"ltr">
Thanks and Regards,=
Aditya Toshniwal<= /div>
pgAdmin Hacker | Sr.= Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about He= at, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000164bfb05a2ee95a5--