Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jHPKi-0006EJ-HN for pgadmin-hackers@arkaria.postgresql.org; Thu, 26 Mar 2020 10:01:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jHPKh-0006Q7-33 for pgadmin-hackers@arkaria.postgresql.org; Thu, 26 Mar 2020 10:01:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jHPKg-0006OL-KM for pgadmin-hackers@lists.postgresql.org; Thu, 26 Mar 2020 10:01:50 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jHPKe-0000vQ-2Y for pgadmin-hackers@postgresql.org; Thu, 26 Mar 2020 10:01:49 +0000 Received: by mail-io1-xd2f.google.com with SMTP id q7so1949014iot.10 for ; Thu, 26 Mar 2020 03:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TwgBgcljJ/h3+NAnbg8LDquS/K0uC+0/5hHLYtGNUoA=; b=pfTI1CYiaazw+9zf31OrvSSMXNY8vEAJLR4i7ez+6UoED9ReSIBUHBN67F7JnaSqTt jEsugKkzWAGYqkiOK9EG3fQ+Y9c3/RTdnxH7Pku4kuJoDYUzwaCT2Z4JFFMjZHiUgugI 99WahS7nb+JVLuHArzQ5PIsHJDKV07nyjB6hFQ/lpEt9/2LFKXWQEvJtAblb3FBM64jQ DCrkFXpTylbVTyUdngTACmWcnACB7dzeWEti9nX8A4nqvt9FcomRLrDk6+Yo6fx0KDog kLEhEYUQMmybnXN12VXA2jjVF4nlZLP5nulHItnniSc4rS39Tdw2E32WalaOSn5ITcce TwSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TwgBgcljJ/h3+NAnbg8LDquS/K0uC+0/5hHLYtGNUoA=; b=Vp8stR8qI/rItP84uk4cEFz98ZQRylfXDRmSQ0moYCRlX6cFTOkr07iyMB6YNFgWNd b4XZFVu3UK6ZpezjEilyGxlbQCchwPYmxpElzQAldjkYOZblpSgUVnM9nNTxfYnXSNpz q3aDxygyDZGQKjLXxR5v4eKBTQDFQF4ulnq62pESXunmrG+L8/lvihcJSHD+wTYx5bOv OvZr6BxsJVNo+nqjGXhApPFFMMbLYY109H3qJ9LwLnOGK5Q+JehDPjnr8sflhKHBxGqv hJGw0KcvIiq/4I+dVjz1HFxHccwlAByolpFnjLobQ0b/uECZMjSrCORK+lAw5MGrW75s fpow== X-Gm-Message-State: ANhLgQ16U7DQ9lPaZilztjI2Cta4+Nj3WQoMbSqwgllETaoqMxFQm+Oo hF2CLg0v0hWIg7B9gbSih1w6Otc5U/4YOumY80k/aknHPqm7zIpAN6gORYQuYyH0ddFtvQcs4LU yrWlcpdMfeLTVJknnR3FBBZJjY4sYQJC3//BcvRUNzolhgYQbTlAm+VkK41b9orhMijyNU9G89i DuLlrZMJFd6s6Y+N8vEgXK+IC9A45LE+YMQ0laqRz8/urGidfnCRA= X-Google-Smtp-Source: ADFU+vtsiAn/dcS7oQ59DCg6OX/x8ADnmNvsb7cZRNADBuN/50ORUfvR1tjtMXBivkXVt9po6LCp+kcnYYso4d3XXLk= X-Received: by 2002:a6b:c087:: with SMTP id q129mr2625910iof.57.1585216906541; Thu, 26 Mar 2020 03:01:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 26 Mar 2020 15:31:35 +0530 Message-ID: Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue To: Nagesh Dhope Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009b5ce605a1bf12af" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009b5ce605a1bf12af Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Mar 26, 2020 at 11:00 AM Nagesh Dhope wrote: > Please find an updated patch, which fixes review comments. > > On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Nagesh, >> >> I cannot see any change related to $active-border variable apart from >> !default. Plus, $active-border should not be allowed to edit. It is a >> structural variable and not a variable which affects theme change. >> Please revert the $active-border change and send the patch. >> >> On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope < >> nagesh.dhope@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find a patch which includes >>> >>> 1. Use *btn-secondary* styles for all buttons in alertify dialog >>> header. >>> 2. Added *!default *for $active-border variable, so that it can be >>> overridden if required. >>> 3. Added entry for *.scss *in .editorconfig >>> >>> -- >>> Thanks, >>> Nagesh >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000009b5ce605a1bf12af Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Mar 26, 2020 at 11:00 AM Nag= esh Dhope <nagesh.dhope= @enterprisedb.com> wrote:
Please find an updated patch, which fixes= review comments.

On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal <aditya.t= oshniwal@enterprisedb.com> wrote:
Hi=C2=A0Nagesh,

I cannot see an= y change related to $active-border variable apart from !default. Plus, $act= ive-border=C2=A0should not be allowed to edit. It is a structural=C2=A0vari= able and not a variable which affects theme change.
Please revert the= =C2=A0$active-border change and send the patch.

On Thu, Mar 26, 2020= at 10:14 AM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:
Hi Hack= ers,

Please find a patch which includes
    Use btn-secondary styles for all buttons in alertify dialog header= .
  1. Added !default for=C2=A0$active-border variable, so= that it can be overridden if required.=C2=A0
  2. Added entry for .s= css in .editorconfig
--
Thanks,
Nagesh


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks,
Nagesh


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000009b5ce605a1bf12af--