Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ixQPq-00005b-W6 for pgadmin-hackers@arkaria.postgresql.org; Fri, 31 Jan 2020 07:08:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ixQPp-0003fo-PB for pgadmin-hackers@arkaria.postgresql.org; Fri, 31 Jan 2020 07:08:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ixQPp-0003f3-9X for pgadmin-hackers@lists.postgresql.org; Fri, 31 Jan 2020 07:08:33 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ixQPm-0008SI-B8 for pgadmin-hackers@postgresql.org; Fri, 31 Jan 2020 07:08:32 +0000 Received: by mail-io1-xd42.google.com with SMTP id c16so7042298ioh.6 for ; Thu, 30 Jan 2020 23:08:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tQL/ku3ocg2m5LJj9n2urobpHrk+LJdgH+Fr9XxEOzw=; b=WmtDSqEKe7D6Gu4RbCv5EWHMpIAoVxd3APUJBiAh80P+RYieAmWSCENvZ4DHhRUyPb Z4Fi2WAOEJLYqw0LgqpyqHQ6NdsZBPC+jGxHZAwGmg6KwFCTlmqk/3pWC5qJYIYChXO1 LBApe9VrJ2UaIMrmsa6sWQZGFCpW+UDkAeYWC/AtskiSeQuXhOqeuNVsJepaGAKIANg2 HrMhr5hPy3E0Hhp0J9s3Sp6flRw3jkEtfIz81BtScTO2AzEU2ZfgupXKrsquvupsaQ6X C5N0pKEtRJNDdk4vOX4Ul9VAoKj+LnR6Acg2UAhcL2VVqIbFFgYbKGbeZcCyMV/d57uG 4etQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tQL/ku3ocg2m5LJj9n2urobpHrk+LJdgH+Fr9XxEOzw=; b=itF9Y0ip3xxDCUzeXO7+kb86VVFEHaXVDySSvRowrnJCmHqUF06W6TG0GhYMHR0RUc wjTWRLgZYsIcUx/YKqVyg07TgCcoMBCGNuyGUFWnOkbkWDNE4efnZjg+MUaXfhZA8wD6 fX4ykE9uby+1I7dJAjbeoV3PNAqs1tvPh9Ht/KL6SknlGcXYllN6zm3YJNAhk/Tef5Cq +24VXfeWgko19L9S+NC3bsppkPStswPG7ydWY4c14zKOLJxtQl+7q09wtK937krasYq1 IMAEJM5IAaOs8kJWl+/dkZ2GcdaJt4uNxw5yfXFjoC5nGF1yimSyqUSq2mlGSgD3NjgI 4Kbw== X-Gm-Message-State: APjAAAUT4XkMB7ywMl48H8T6lbEmls8Sy6hIVMwcq+kFH6APLQsUx53c YJEoALoj3V0FsLL3gZuYsTI32I7eXZUd5R4cELqhco2Omgibyi5E7q3fvSuHUDxCrEdZim4sjZ2 tE5XhiMDuHZtDO+6PXShA48DrZJ2hR+QLAlsdxu4gZKu6rKqSut2exrGvLTsmM4jFZ7gspmgNSt q3XwSCLZSNloHbmmCBoRccZykNeBbib4xNVi8pY51UZ7XuwGREjKI= X-Google-Smtp-Source: APXvYqzkdoZ8NGJTfF7ab7x1FqEV60BYRlSfw+m7/deMj7LF62WXWGdQATzlEliEm93lWW1/J44MPLHNP++vDYbKp+I= X-Received: by 2002:a5d:9b12:: with SMTP id y18mr4562246ion.176.1580454508993; Thu, 30 Jan 2020 23:08:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 31 Jan 2020 12:38:18 +0530 Message-ID: Subject: Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000097b7d5059d6a3db8" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000097b7d5059d6a3db8 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to include dialogs (create/edit) for all the > nodes. > Kindly review. > > On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> As per discussion, we should visit all the nodes create/edit dialog and >> make the controls read-only wherever appropriate. >> >> On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to allow input controls to be set as readonly >>> instead of disabled. >>> I've also changed the code for the nodes to make sure properties tab >>> have readonly fields wherever applicable. This will allow tab navigation in >>> properties tab and also allow screen readers to read it. >>> Please note that, I've not visited each and every node create/edit >>> dialog to identify what should be readonly or what should be disabled as it >>> depends on business logic. The patch is mainly for the properties tab. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000097b7d5059d6a3db8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Jan 30, 2020 at 1:55 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is th= e updated patch to include dialogs (create/edit) for all the nodes.
Kindly = review.

On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi <akshay.joshi@enterpri= sedb.com> wrote:
Hi=C2=A0Aditya

As per discussio= n, we should visit all the nodes create/edit dialog and make the controls r= ead-only wherever=C2=A0appropriate.

On Wed, Jan 22, 2020 at 5:46 PM Ad= itya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,
Attached is the patch to allow input controls to be set as readonly inste= ad of disabled.
I've also changed the code for the nodes to make sure p= roperties tab have readonly fields wherever applicable. This will allow=C2= =A0tab navigation in properties tab and also allow screen readers to read i= t.
Please note that, I've not visited each and every node create/edit d= ialog to identify what should be readonly or what should be disabled as it = depends on business logic. The patch is mainly for the properties tab.

=
Kindly review.

--
Thanks and Regards,
A= ditya Toshniwal
= pgAdmin Hacker | Sr. Software Engineer |=C2=A0EnterpriseDB India = |=C2=A0Pune
&qu= ot;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000097b7d5059d6a3db8--