Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEqaH-0002T0-KI for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 08:31:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEqaG-0007Qo-Bv for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 08:31:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEqaF-0007P6-ST for pgadmin-hackers@lists.postgresql.org; Thu, 19 Mar 2020 08:31:20 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEqaD-0001M9-8W for pgadmin-hackers@postgresql.org; Thu, 19 Mar 2020 08:31:18 +0000 Received: by mail-il1-x131.google.com with SMTP id v6so1454151ilq.2 for ; Thu, 19 Mar 2020 01:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+CbmqrJzI1R62/IK3t1ytgNS8TpY1+nXznzkbNWaErY=; b=mpgOaXBGLeJUHdRiHSaHrHucyNdQc8pqpxn2xo+iTQIxhpfW3WU3fKIOiLHzp2EoSW haJE9Xn6lGyF6mRG6DG/5HepHuzkg0GPpK5G92MmeJTWO2atVLXbnh5XxMQ7vo1A9Ni0 U5rG+TKUVeKXDYHB/iw041DZ6uTzu2eXP5ICoCJ8Lq65eeVhGD8+Jxl1HHQL+ODRriAD 1x9pY9HljcxMKrZzYmzja03YTPyHZhwUYCwNuVZAZ9knWeORkewDjFmZsyoKlLrzFXp+ 6Rddx9vmAo2nPbBYa1ipMOIMure4WQOrzY1HbltXKyH0jx2ETWPW17tVm/FnAcDpBDWg 1vBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+CbmqrJzI1R62/IK3t1ytgNS8TpY1+nXznzkbNWaErY=; b=YJwiMUvRcMcchN+Mdgcyp4ZxvVBwfibdQm97wuBOLlk7ebTtFvEWa9Lq/go0E8r+F/ LvYznmxyc8ah5tww7hLKKPliuBvQq1c/Wn5iM6VONRUFHDGZRTWXJvPm4jK2Olb7XvNz qgSEGln3QXSQEKK0igYM3wq66j7iFRnZuzckjJhbG4tbXL/UjR4Jyd7GXxhIFXDah3C6 18USliMEeU3PIBTX2LuvFpuY+j8DApf7hE4whQ+6LCkwsjq+SJGnWyiEOXbiW8TSsDfq 1usWRXAf5+vAvYU1WdflcLlPzEQ4v8yqnX7w8/KN1U3/Zz523J9ZwQ71xlRuYR65mFLb UQUw== X-Gm-Message-State: ANhLgQ0gy3rP52rcAfIjFWeBMvOukfweznbY0S6NPuy+viPf3EaioddY /H2vzLH7tnVGud6pHmBVYcD5CmR5d62V8ImC4tUtNFgsHtJPHjrh6A0tSxz1uCa3xrXEh+MKy4G R5oMBSOa1OQROmGO69dOKIA374wy23TNMweJLmNJ98HToGT9RA5K5WEEqspOx7OOSiVEVkjILi5 2CF6WWqUBcziI98ifHECZ5Z95r7cITGC+UOA6aEgTwyj5exGcW/yo8FA== X-Google-Smtp-Source: ADFU+vsAXao698wAYxnB2CUV72FbuOUvtpliguuCJ8f7kzWN8YrzTa5RTalWsMH8pizo/HgVLe+lJRKPWyFma2Mrrrw= X-Received: by 2002:a92:5b17:: with SMTP id p23mr2071081ilb.121.1584606675721; Thu, 19 Mar 2020 01:31:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 19 Mar 2020 14:01:04 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#5261] Support for Collation, FTS Templates, FTS Dictionaries, FTS Configurations and FTS Parsers To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000003fe0305a130fe5c" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000003fe0305a130fe5c Content-Type: text/plain; charset="UTF-8" Thanks, Khushboo for review. On Thu, Mar 19, 2020 at 1:25 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Akshay, > > The patch looks good to me. > > Apart from this patch, I encountered below error. > > "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/schema_diff_utils.py", > line 271, in get_sql_from_submodule_diff > parent_target_data=target > File > "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/__init__.py", > line 790, in ddl_compare > target_data=parent_target_data) > File > "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py", > line 142, in wrap > return f(*args, **kwargs) > File > "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/__init__.py", > line 508, in get_sql_from_diff > schema_diff=True) > File > "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py", > line 1369, in get_partitions_sql > part_data['partition_scheme'] = self.get_partition_scheme(row) > File > "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py", > line 695, in get_partition_scheme > for row in data[part_keys]: > KeyError: 'partition_keys' > The issue has been fixed and committed. > > > > Thanks, > Khushboo > > On Wed, Mar 18, 2020 at 4:28 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to add support for Collation, FTS Templates, FTS >> Dictionaries, FTS Configurations and FTS Parsers in Schema Diff Tool. >> >> The patch contains some minor fix where parameters are added in the >> difference list even though it's size is zero. I have also added the test >> cases. >> >> Please review it. >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000003fe0305a130fe5c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, Khushboo for review.

On Thu, Mar 1= 9, 2020 at 1:25 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Akshay,
The patch looks good to me.

Apart= from this patch, I encountered below error.

"/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_gr= oups/servers/databases/schemas/tables/schema_diff_utils.py", line 271,= in get_sql_from_submodule_diff
=C2=A0 =C2=A0parent_target_= data=3Dtarget
=C2=A0File "/Users/khushboovashi/Project= s/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tabl= es/partitions/__init__.py", line 790, in ddl_compare
=C2=A0 =C2=A0target_data=3Dparent_target_data)
=C2=A0File = "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_gro= ups/servers/databases/schemas/tables/utils.py", line 142, in wrap
=C2=A0 =C2=A0return f(*args, **kwargs)
=C2=A0Fi= le "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_= groups/servers/databases/schemas/tables/partitions/__init__.py", line = 508, in get_sql_from_diff
=C2=A0 =C2=A0schema_diff=3DTrue)<= /span>
=C2=A0File "/Users/khushboovashi/Projects/pgadmin4/web= /pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py&qu= ot;, line 1369, in get_partitions_sql
=C2=A0 =C2=A0part_dat= a['partition_scheme'] =3D self.get_partition_scheme(row)
= =C2=A0File "/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/b= rowser/server_groups/servers/databases/schemas/tables/utils.py", line = 695, in get_partition_scheme
=C2=A0 =C2=A0for row in data[p= art_keys]:
KeyError: 'partition_keys'
<= /div>

=C2=A0 =C2=A0The issue has been fixed= and committed.



Thanks,
Khushboo

On = Wed, Mar 18, 2020 at 4:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com>= wrote:
Hi Hackers,=C2=A0

Attached is the patch to add = support for Collation, FTS Templates, FTS Dictionaries, FTS Configurations = and FTS Parsers in Schema Diff Tool.

The patch con= tains some minor=C2=A0fix where parameters are added in the difference list= even though it's size is zero. I have also added the test cases.
=

Please review it.

--
Thanks & Regards
Akshay Joshi<= /font>
Sr. = Software Architect
Ente= rpriseDB Software India Private Limited
Mobile: +91 976-7= 88-8246


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000003fe0305a130fe5c--