Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNtXD-0002VR-7Z for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Oct 2020 08:01:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kNtXC-00072p-3U for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Oct 2020 08:01:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNtXB-00072Q-LY for pgadmin-hackers@lists.postgresql.org; Thu, 01 Oct 2020 08:01:49 +0000 Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kNtX5-0003Ff-DA for pgadmin-hackers@postgresql.org; Thu, 01 Oct 2020 08:01:48 +0000 Received: by mail-il1-x12d.google.com with SMTP id q5so5242933ilj.1 for ; Thu, 01 Oct 2020 01:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ur9MrAG1/FFxZ81SjMoDPS5JV9nf6nr/GrON+LEZPvA=; b=YO/y4P9NSca/NHRSa9Q7Y+oGFC7SeNokcr/VkUuZUHU+2zN3wxFFknewAynpeYLsu4 A5NA5P/L4QpsMtgXr+EISIqpkA/z0bX3EM4Dy/TmM4kVAduHeCzViWAxYWK7cf1Oh4cq QcdKqJwcvBSapfx52I9RqMarEYU27yvlTKN3g0T4kpU4QLYKjp1K04h35DtpXir7If3P GrkRx42TuVv+azoFaUHqpaX5o8A6v4DtCfZKTtmSwcUpjB3D3mW96PJ9iV1NXfb8mllv vjHmsQ41ffXxzY8TA76EzfLP3NBxIYM2PxPiV0F9F70mEoKT/+ILmLBml5jSjcrGfHeg SOTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ur9MrAG1/FFxZ81SjMoDPS5JV9nf6nr/GrON+LEZPvA=; b=Lh7nAYwlPcvF9ciPOjhAm18PuJMeVdueIGIil2A3Ht61uEXf4qSNymggUfWlybC1R6 2ssXcKSZ22edXjG+uLgf7x0KAwBMWApPLR8TyY15tfaCJ3ohUqVXEocqadb8kzc6eXTp 9Mt9f0zk4N9ZpMB9D3DT710EiZNpQLIEqzNZoe9TAa8GwQlIQMojCVf/BKf4EcvMDb1v 63iRutgeOIknxuV5iAQUqHZjOY6wTcfCFZ6VmIsgezircdyW1MuX/yBUlChMwOdpZZqn XN5VndO3OorTFeSZt5t+nTSIMwzahz/sCS8j8kYEvHbDfxmyDx6RgMSRt67xcHOtyoHc vHEw== X-Gm-Message-State: AOAM531CTILhggg6MX0fmiAXpwwF8ACuAtdMG1JXbdN8cKcX2UPRhqxI 5xDzoe+iSyGz3NdSBKRIIa9OhMk0vpPzNt4qAXyO2WsV6JZNzRWILr6xxLHpmZ0Tag+eiE3vgiQ pAO/HvgnUFZZDfSPQMYDhq9Mb5bqTaV9JFDIVjzws01Dv6B6LshiP+EbgwRHhmtCqkvw7rkiHsO g2ug6lKy2jgZrgFfG64jIFYXReA3hdaNhb3jeVt5Og4MyHlJsCDvUlKZcEAy+TGSjD3Q== X-Google-Smtp-Source: ABdhPJxjUUv20ewBihuqakY4Goi2pE6p+p2lEYB1Mmu98kEmHo3vqLscDKwSuG9TFdAlIFsXnEIyyvGZ1ZzGp57A8+w= X-Received: by 2002:a92:9985:: with SMTP id t5mr1437075ilk.121.1601539302568; Thu, 01 Oct 2020 01:01:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 1 Oct 2020 13:31:31 +0530 Message-ID: Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000394ef405b0976d3d" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000394ef405b0976d3d Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Akshay, > > I have resolved the sonarQube issues, PFA updated patch for the same. > > > Regards, > Nikhil Mohite. > > > On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Nikhil >> >> Your patch introduces 1 new Bug and 13 new code smells, please fix those >> and resend the patch. >> >> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> I have resolved code conflict issues and sonarqube issues. >>> PFA updated patch. >>> >>> Regards, >>> Nikhil Mohite. >>> >>> On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Nikhil >>>> >>>> The patch is not applying, rebase, and send it again. Please check your >>>> code should not create any new SonarQube issues. >>>> >>>> On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite < >>>> nikhil.mohite@enterprisedb.com> wrote: >>>> >>>>> Hi Akshay, >>>>> >>>>> I have resolved all the review comments and also updated the test >>>>> cases as per the new implementation. >>>>> >>>>> PFA updated patch. >>>>> >>>>> >>>>> >>>>> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Nikhil >>>>>> >>>>>> Following are the initial review comments: >>>>>> >>>>>> - Open View/Edit data on any table and click on the same database >>>>>> connection and then click on the Execute button. Got "get_primary_keys() >>>>>> takes 1 positional argument but 2 were given" error. >>>>>> - In my opinion, we should hide the option to change the database >>>>>> connection for View/Edit Data. >>>>>> - If the user clicks on the same database connection multiple >>>>>> times then no need to change the backend connection and transaction id. Add >>>>>> validation at the backend, no action required in this case. >>>>>> - The role option is missing from the "connect to server" dialog. >>>>>> - The Password field should not be there on the "connect to >>>>>> server" dialog. Sometimes we saved the password so asking a password every >>>>>> time is not correct. Check the pgAdmin 3 behavior. >>>>>> >>>>>> Code review still remains. >>>>>> >>>>>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite < >>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Team, >>>>>>> >>>>>>> Regarding RM-3794 >>>>>>> allow the user to change the database connection from an open query tool: >>>>>>> I have implemented the feature and also added documentation for it. >>>>>>> >>>>>>> PFA patch. >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards,* >>>>>>> *Nikhil Mohite* >>>>>>> *Software Engineer.* >>>>>>> *EDB Postgres* >>>>>>> *Mob.No: +91-7798364578.* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>> *EDB Postgres * >>>>>> >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Sr. Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000394ef405b0976d3d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Oct 1, 2020 at 10:42 AM = Nikhil Mohite <nikhil.= mohite@enterprisedb.com> wrote:
Hi Akshay,

I= have=C2=A0resolved the sonarQube issues, PFA updated patch for the same.


Regards,
Nikhil Mohite.


On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Hi=C2=A0Nikhil

Your patch= introduces 1 new Bug and 13 new code smells, please fix those and resend t= he patch.

On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite <nikhil.mohite@= enterprisedb.com> wrote:
Hi Akshay,

I have r= esolved code conflict issues and sonarqube issues.
PFA updated pa= tch.

Regards,
Nikhil Mohite.
=
On Mon= , Sep 28, 2020 at 5:58 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wr= ote:
Hi=C2=A0Nikhil

The patch is not applying, rebase, = and send it again. Please check your code should not create any new SonarQu= be issues.

On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite <nikhil.mohite@= enterprisedb.com> wrote:
Hi Akshay,

I have r= esolved all the review comments and also updated the test cases as per the = new implementation.

PFA updated patch.
<= br>


On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <akshay.jos= hi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil

Follo= wing are the initial review comments:
  • Open View/Edit data on an= y table and click on the same database connection and then click on the Exe= cute button. Got "get_primary_keys() takes 1 positional argument but 2= were given" error.
  • In my opinion, we should hide the option t= o change the database connection for View/Edit Data.
  • If the user cl= icks on the same database connection multiple times then no need to change = the backend connection and transaction id. Add validation at the backend, n= o action required in this case.
  • The role option is missing from the= "connect to server" dialog.
  • The Password field should no= t be there on the "connect to server" dialog. Sometimes we saved = the password so asking a password every time is not correct. Check the pgAd= min 3 behavior.
Code review still remains.

On Thu, Sep = 17, 2020 at 4:15 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote= :
Hi Team,

Regarding RM-3794 allow the=C2=A0user to c= hange the database connection from an open query tool:
I have imp= lemented the feature and also added documentation for it.

PFA patch.

--
Thanks & Regards,=
Nikhil Mohite
Software Engineer.<= /div>
<= font face=3D"verdana, sans-serif">Mob.No: +91-7798364578.
<= /div>


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--000000000000394ef405b0976d3d--