Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfyUT-0004S0-TH for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 May 2021 05:30:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lfyUR-0005aH-MZ for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 May 2021 05:29:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfyUR-0005a9-7l for pgadmin-hackers@lists.postgresql.org; Mon, 10 May 2021 05:29:59 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lfyUN-0005Ij-KH for pgadmin-hackers@postgresql.org; Mon, 10 May 2021 05:29:58 +0000 Received: by mail-io1-xd2b.google.com with SMTP id t3so13614326iol.5 for ; Sun, 09 May 2021 22:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cpFrLdS8M13/qEnXzaFSEC8WS2Z3GO4EOY0/Bo7Yvz8=; b=YndfQYtTE/J3aVYkQZIzWG3xFAlmiqLgSzpfqCp05cyrpPWU1MQ2HNr9wrhG8NZciB U/ZdyEn4bVJcwybNXPBdnjh9wFqkf+fBeH3LGRG/kVk5GaXQtgTqnHt5DaxITgcSYhRU FqyHygCzA1+yGu2NHUowtrBJY2w/SfJ+ljLEczdwiNgRLZ68S41jaMwcprvZTwgfLp1J GaszAEGw1gZ0kaLXJTXGGCcgb433pmXVY5Q0nwyIwU+V0D2NMnTzC2yL+eOWMBw+d1Ls orIB1yrd5d+csYhhBmP8f0tJ/Z+fc5YKK4/a0HSbmaLAj3Y1neuhW43jdt68oRzt2gnh S0GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cpFrLdS8M13/qEnXzaFSEC8WS2Z3GO4EOY0/Bo7Yvz8=; b=XAezmYrcZiGzixHsJm7jrOU50BoFTdKvvjf+iqrm5Th0ZZzRa0tPhS6jtJQa2+onc1 IMPX8IeqR4HIrusaO2qa5gjmyA5d/b3uUKFaNWd41thE8/wrpRRRbtHJPRTFkVY51PJD fBBch4W4bEVm0kGzp+qdD5QZ1TOvrDTbNen64ZqgeQmgXZKdOkbyDcG4FHM4vqiHWRF/ jtiWCJZLG9ewO6xHU9Eoz71OYxqMfcGtA7+iACRcZlXwy4JuZPs5SzyY/pDSfsWIQChS DsdS3Ajt98aV3/XNNSQ0F1/d3R4v6w9MzPpE4WVmX2cQjSQ92Q2ewTSRhhRE5GNYC9mI roSg== X-Gm-Message-State: AOAM5335rG3UnGa/2UeJRegDHBIbqSW9K7GBCtI+JRM0cp/BqVCQ8eIP HkX43IKRe3607JCFlfgMDAdpsxQSruFtvF+dq249NnlPKHWkX9maMbuGsSFP60n7NtObCQWCbRC KuLp7j/7SK08xaON3idot07Lo27J6AlKnRDqFnZZZpYhGH26jQBWk2p/QpTGO1ISjG9xHcrDnAm hR+TH3emdn39REPUUQq5Kx629nWYZpqoqBBtncZ7pEAZ8q7+KPHj0OBfpOzg== X-Google-Smtp-Source: ABdhPJxjxetkxeWAY+96KKrLFkexs3Zs7l+tYYgDfb/5RogLL/UdXlBGC5b4Hzx5uaK0p/i0qFC2vtcgXkDq/FPYscE= X-Received: by 2002:a05:6638:963:: with SMTP id o3mr10599850jaj.0.1620624593429; Sun, 09 May 2021 22:29:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 10 May 2021 10:59:42 +0530 Message-ID: Subject: Re: oauth2 patch To: Florian Sabonchi , Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000034bdb905c1f31100" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000034bdb905c1f31100 Content-Type: text/plain; charset="UTF-8" Hi Khushboo Can you please review the patch? On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi wrote: > Hello in this patch I have implemented OAuth2. Unfortunately I wasn't > sure how the test should look like, because I couldn't find anything in > the developer documentation, so I decided not to write one for now. > > The configuration has to look like this here is an example for github: > > OAUTH2_NAME = 'github' > OAUTH2_CLIENT_ID = 'secret' > OAUTH2_CLIENT_SECRET = 'secret' > OAUTH2_TOKEN_URL = 'https://github.com/login/oauth/access_token' > OAUTH2_AUTHORIZATION_URL = 'https://github.com/login/oauth/authorize' > OAUTH2_API_BASE_URL = 'https://api.github.com/' > OAUTH2_USERINFO_ENDPOINT = 'https://api.github.com/user' > OAUTH_ENDPOINT_NAME = 'user' > > > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000034bdb905c1f31100 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo

Can you please review the p= atch?

On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi <sabonchi@posteo.de> wrote:
Hello in this patch I have imp= lemented OAuth2. Unfortunately I wasn't
sure how the test should look like, because I couldn't find anything in=
the developer documentation, so I decided not to write one for now.

The configuration has to look like this here is an example for github:

OAUTH2_NAME =3D 'github'
OAUTH2_CLIENT_ID =3D 'secret'
OAUTH2_CLIENT_SECRET =3D 'secret'
OAUTH2_TOKEN_URL =3D 'https://github.com/login/oauth/= access_token'
OAUTH2_AUTHORIZATION_URL =3D 'https://github.com/login/o= auth/authorize'
OAUTH2_API_BASE_URL =3D 'https://api.github.com/'
OAUTH2_USERINFO_ENDPOINT =3D 'https://api.github.com/user' OAUTH_ENDPOINT_NAME =3D 'user'




--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000034bdb905c1f31100--