Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8JuD-0002yE-AP for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Aug 2020 08:57:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k8JuC-0004V6-8b for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Aug 2020 08:57:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8JuB-0004Uz-N2 for pgadmin-hackers@lists.postgresql.org; Wed, 19 Aug 2020 08:57:12 +0000 Received: from mail-il1-x135.google.com ([2607:f8b0:4864:20::135]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k8Ju9-0003Pk-9d for pgadmin-hackers@postgresql.org; Wed, 19 Aug 2020 08:57:10 +0000 Received: by mail-il1-x135.google.com with SMTP id t13so19979353ile.9 for ; Wed, 19 Aug 2020 01:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6OcB7g24vWrvxPjBwxl3UYggySSxzVLNXpxJY57NN6I=; b=teg7vfqH6LyRuNrg+cbrDU3V/0X7TNaYNvdd2QSDSRYFjqq06W4iuiMO1zj/an5/g7 nJEYs9hCAKrGzLLacLAoavIKaekNYRwUKoWAV6Wq9zd7hRK3QGiZe63qragU4UaBVzSg 13y/F+l1ZfKds3iwxsNHjd4fdXugIOm1R2zzEfaVFP9jmhYI1S4Ty3lMr5uSwxMHs3pP KoHXy4Zf/zSHe0mttCkaZv7QV657xmj82DR6V/zNzE6DzfKOe6wI+yle12if3CPl6L4W 7r6DIy78cwQrCz2dsRZG+9tt1puebjHOIB1dXzosUm2v4ioHGWWxbsKE8tXxFNqW0DpJ 4R9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6OcB7g24vWrvxPjBwxl3UYggySSxzVLNXpxJY57NN6I=; b=h+lk3xXAV9ZTBxZsbqQ7nB+PSko7bIaLjAvpx8gzJSMyKlB8B9I1iW02HyigFGoeJo TAVTnQ9Mck8iaAuylufwjZnrfZKLSi2F1XZ+rt3EVs7zzkbgAOAOeQh7wCdFc9THu1mg fbyVaOcINXVzH/hKMzRnwTmngKqzePvWlYsrDWunh7rCTPKsBGXKG7DCJ/wH6VubN9JX B97OSWo00V7Z/bvvi1JKybIxIsMo7bERyLKNnd4mSBF6KeVpsjv25YgUiRi6Lhixna7B iBqrJH1GrVQ76QZejrTzTg+K5G8JjmGisi7iDr2aUooT7FQ1LOCLclnNVu+pgmm2rPdn lZng== X-Gm-Message-State: AOAM530GrRLs0PbBHcrFhG79UoJTdc1vLu4oMn2M7NvMlVJh8acl6WU4 XKXM89KJGYDOXjRM87eSczONyotD2YbkGMDnGmeVSktvEEAVJD1IBDJE9IGzKLJ/+7dXxHptlNi kmhy330mIb1ovGnyFhOBMDHKSOV/yI2tYp39lUazOgbqlCUwx83CnFYhb7OF89DdeKA5rz5L5lJ RT2fBcyaObeGgBtMWM2t80sBmrIqtoy+QCuCznXhi71uFPyVZJohDZk7cWhQ== X-Google-Smtp-Source: ABdhPJzSUkZvoVCaP4fLhjaMfIbOnJuAvOdUp2e+x8T/rs5mkIZQvlJWvC+aIs02r/C16f1W6j7jGJHeBiu2MA532Kw= X-Received: by 2002:a92:c946:: with SMTP id i6mr20816602ilq.252.1597827428255; Wed, 19 Aug 2020 01:57:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 19 Aug 2020 14:26:57 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - SonarQube Fixes To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000462fb805ad373034" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000462fb805ad373034 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > > On Tue, Aug 4, 2020 at 12:10 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Khushboo >> >> As per offline discussion, multiple developers declaring the constant for >> the same string and error messages. To avoid that only one developer should >> work on this task. >> Suggestions: >> >> - We should have a common class for Constants (which are not module >> specific). >> >> Made a constant.py file which contains the common Constants. > >> >> - For module specific constants we should not declare them as Global >> variables if possible declare them as the Class variable. >> >> >> - For common error messages(if any) we can define functions in >> PGChildNodeView. >> >> Already implemented. > >> Please incorporate the changes send by Yogesh. >> > I will send another patch for Yogesh's changes as needed more changes. > > Thanks, > Khushboo > >> >> On Mon, Aug 3, 2020 at 1:36 PM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the sonarqube code smells having >>> the rule "String literals should not be duplicated". >>> >>> Thanks, >>> Khushboo >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000462fb805ad373034 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Aug 19, 2020 at 2:01 PM = Khushboo Vashi <khush= boo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached updated patch.

<= br>
On Tue,= Aug 4, 2020 at 12:10 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wro= te:
Hi=C2=A0Khushboo

As per offline discussion, multipl= e developers declaring the constant for the same string and error messages.= To avoid that only one developer should work on this task.
Sugge= stions:
  • We should have a=C2=A0common=C2=A0class for Const= ants (which are not module specific).
Made a constant.py file which contains the common Constants.=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
    =
  • For module specific constants we should not declare them as Global vari= ables if possible declare them as the Class variable.
=
<= div dir=3D"ltr">
  • For common error messages(if any) we can defin= e functions in PGChildNodeView.
Alre= ady implemented.=C2=A0
Please incorporate the changes send by Yogesh.=C2= =A0 =C2=A0
I will send another patch for Yoges= h's changes as needed more changes.

Thanks,
Khushboo
On Mon, A= ug 3, 2020 at 1:36 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> = wrote:
Hi,

=
Please find the attached patch to fix the so= narqube code smells having the rule "String literals should not= be duplicated".

Thanks,
Khushboo


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
<= div>pgAdmin Hacker | = Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

<= /div>
--000000000000462fb805ad373034--