Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hryQS-00061E-CX for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 05:42:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hryQQ-0007jI-Ra for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 05:42:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hryQQ-0007jB-KW for pgadmin-hackers@lists.postgresql.org; Mon, 29 Jul 2019 05:42:22 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hryQM-0002WR-Ck for pgadmin-hackers@postgresql.org; Mon, 29 Jul 2019 05:42:21 +0000 Received: by mail-qk1-x742.google.com with SMTP id d79so43265914qke.11 for ; Sun, 28 Jul 2019 22:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AjvH2R4ODm18m6STKnySZTxzekHWUYXn5nD6wdRoe1A=; b=MCzn2w2QGHWi2cHM+ue+XWVsvOlZT9tPYuzEMIqoM4mY1qLXONHriwLzQBIYbneHj+ vzHPpG5Kyi4LTdQyO+UDMfXszO0h7wTJjMxEUkQarCWE9aBaSLmiKiBaqRHAyKY+Qj3B 9Z5hK0CmH4BdnvRptEnPdvLZBf3tZ8X+mhBwoAXygoy5OenVjcBo4R/2MDmnXYcpruIZ ByyuCNyshpvLWnB94zQjCurNmBosJcdAiNlRbE32KhQLmczVEymqLNOTOw4IWrOfBjsQ 9/6GfyHWPqH+GpMFWAWTOJPBP7pQHRQq+FnzYqs++x7sAN5JQNj9kFnQETA1t5DDwsk+ SVvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AjvH2R4ODm18m6STKnySZTxzekHWUYXn5nD6wdRoe1A=; b=pKdxDWLs/8lQVu4HDCziOgPuqPb6TFbwEB+3+08hxFB8B1aPfrr5CWpcW3dJe7icOz j6EpMbmX7hd8ZhtbPpx2ikGmIVZY+yM2e8gzuGv3spcc5gNPmKwLG32o+786irWon2ke JQLlbcYDRvh6dpSGiBug+/P41fozTEDDSYB33Y/ouakyKXAs5PGxuFHL/XjE9swzaahK 8BoYTX/U7osbvf8mdg3j4s/r6U60+X5TsxMUPzr2jTlsXCUclt54PNsd06MnWnTBUQxX csTBLvKy7Dns44kzv4Cto6o8ge5XDU6/JO2ThJkENy2Va6+A3oghsKZ2IE6CON7Fmi2X eGlw== X-Gm-Message-State: APjAAAUIlhlto3fahLnxStIysMyOAnPwmV+Gg6y6jHW2ZjKgEc7qKPZZ g9uSDJCQyvfAaepKGwvlWOyu09Znwv9QvdI1/dtLgQ== X-Google-Smtp-Source: APXvYqx09VDHbJuMDUsyhxhtXbq4DNs8pwQsTM5soemOLo7NklB/w3ykF5xThBPD+j+jqQp62ajU5XRBcWLjaCXsO2M= X-Received: by 2002:a37:4e4b:: with SMTP id c72mr70611551qkb.91.1564378936199; Sun, 28 Jul 2019 22:42:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 29 Jul 2019 11:12:05 +0530 Message-ID: Subject: Re: [GSoC] Support editing resultsets from tables with OIDs To: Dave Page Cc: Yosry Muhammad , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c96965058ecb5ac6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c96965058ecb5ac6 Content-Type: text/plain; charset="UTF-8" On Fri, Jul 26, 2019 at 5:33 PM Dave Page wrote: > Akshay; can you take a look at this and commit if appropriate please? I'm > somewhat busy at the moment :-( > Sure, I am looking it. > > On the subject of the regression test - I assume at one point the messages > window was including the command tags in it's output. This failure would > indicate we broken that. Anyone got any ideas how that happened? > > On Thu, Jul 25, 2019 at 1:01 PM Yosry Muhammad wrote: > >> Hi, >> Please find a patch attached to add supporting of resultsets from tables >> with OIDs as updatable resultsets (with updated test cases and docs) - this >> is a part of a GSoC project. Please review ! >> This patch also includes a small refactor of the previous patch and a >> small bug fix that occurred when the query resultset had no rows but was >> updatable (row additions were not permitted, although they should be). >> >> >> On a different note, one of the feature tests fails (on master), probably >> due to a small typo. In query_tool_tests.py this function call: >> >> self.page.find_by_xpath( >> '//div[contains(@class, "sql-editor-message") and ' >> 'contains(string(), "CREATE TABLE")]' >> ) >> >> on lines 371-374 produces an exception that the element cannot be found, >> this is probably due to the fact that the message returned by the query >> executed before this call does not contain the string "CREATE TABLE". Just >> letting you know about this. >> >> Thanks and regards! >> -- >> >> *Yosry Muhammad Yosry* >> >> Computer Engineering student, >> The Faculty of Engineering, >> Cairo University (2021). >> Class representative of CMP 2021. >> https://www.linkedin.com/in/yosrym93/ >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000c96965058ecb5ac6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Fri, Jul 26, 2019 at 5:33 PM Dave Page= <dpage@pgadmin.org> wrote:<= br>
Akshay; can you take a look at this and commit if appropriate please? I= 9;m somewhat busy at the moment :-(

= =C2=A0 =C2=A0Sure, I am looking it.=C2=A0

On the subject o= f the regression test - I assume at one point the messages window was inclu= ding the command tags in it's output. This failure would indicate we br= oken that. Anyone got any ideas how that happened?

On Thu, Jul 25, 201= 9 at 1:01 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi,
Please= find a patch attached to add supporting of resultsets from tables with OID= s as updatable resultsets (with updated test cases and docs) - this is a pa= rt of a GSoC project. Please review !
This patch also includes a = small refactor of the previous patch and a small bug fix that occurred when= the query resultset had no rows but was updatable (row additions were not = permitted, although they should be).


On a different note, one of the feature tests fails (on master), prob= ably due to a small typo. In query_tool_tests.py this function call:
<= div>
self.page.find_by_xpath(
    '//div[contains(@class, "sql-edi=
tor-message") and '
    'contains(string(), "CREATE TABLE")]=
9;
)
on lines 371-374 produces an exception that = the element cannot be found, this is probably due to the fact that the mess= age returned by the query executed before this call does not contain the st= ring "CREATE TABLE". Just letting you know about this.
=
Thanks and regards!
--=C2=A0

Yosry Muhammad Yosry

Computer Engineerin= g student,
The Faculty of Engineering,=
Cairo University (2021).
Class representative of CMP 2021.


--
Dave Page
Blog: <= a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blo= gspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000c96965058ecb5ac6--