Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8dr-000804-Vv for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 09:28:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gp8dq-0004L2-B2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 09:28:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8dq-0004Kv-4D for pgadmin-hackers@lists.postgresql.org; Thu, 31 Jan 2019 09:28:14 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8dj-0001iZ-00 for pgadmin-hackers@postgresql.org; Thu, 31 Jan 2019 09:28:13 +0000 Received: by mail-qk1-x734.google.com with SMTP id m17so1469060qki.5 for ; Thu, 31 Jan 2019 01:28:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uRFy/8ZdAsQILjF3ed+fbDmXNGGCo/JjXJLLwHUbwHI=; b=vM9mYJQXuh360sDA7BUFiQ3kATMRrOMK4jWYLVEw3RaBhoe7vTQLgzUsyxCfRbkvmJ 2p3uKEu5PrdEz5Y+qg2MawF1t9L1RiduyFY5ytLE0CbfN62G57nJ4uW3V3xprLEilH5D VcmQL1A8sq7p0YwQWcI/SBfHkjnWuD+C2SlvU5qDyIp4t10O2Lb0MEm/IjmgIA7fTV2Z Z9ys1FSdxOjZser49yq/5E5Kt4K3PykYZVWCUa+8jVR78BceHRbc0PKvCbra4waL0wuF Fy3PvqsguuU0tE2en5RYsH5aMe/GK0y4PFYxAKMOMIUBsl++RpnorRnkcnM1ohJrLfwz x4tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uRFy/8ZdAsQILjF3ed+fbDmXNGGCo/JjXJLLwHUbwHI=; b=K0bZvr52Z8JV1/WN7GDQyRzKTPBvLYVn3rJe1HUwdqSRUrQTV2UtW3g/T7iyRuOhD6 fbHObJCGee7EeElJmHwZaK/iDA/MYMMNf9jtSsKWhPeIVP/G1tFQAIvRullxLRhYlAZC WmgMQLImaz2OPxuB9mTiwrCc1qduBbvWAVH28v/dREf33mOvMy4g6Ia2VYCVM2RDd3K6 ME6oTADV9JHP5m5iZYRLegk97Iiq5LGNwLq34TCDW89lFlCOW/3eTpVDJiTSzSgHnkZG g6i55hrrzt2eMeH2d7j/dVPxctbLR+MTDXkStfX2coXeMNGLIVrjDYZZNI6X3yZH2nWp hoig== X-Gm-Message-State: AJcUukdo6j31TKlykC2Ukik//ASnSDLkRoqEEVhfYQFeqtEINuF+y0V/ lgKfogeWn/XiikW3B97b/2CLOgh98FOb6GwDh88AUQ== X-Google-Smtp-Source: ALg8bN6CMf483BRtnGqTAXdv6f/6IuNVsRlFStnrwb5SwRCfRQtQMx288Ifyfue62B6aihYf1jaH/w09AX5RmTfrE80= X-Received: by 2002:a37:688c:: with SMTP id d134mr31165149qkc.57.1548926884000; Thu, 31 Jan 2019 01:28:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 31 Jan 2019 14:57:52 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables To: Aditya Toshniwal Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b44e9e0580bda419" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b44e9e0580bda419 Content-Type: text/plain; charset="UTF-8" Thanks patch applied with the mentioned changes. On Thu, Jan 31, 2019 at 2:26 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Khushboo, > > The patch looks good to me and statistics works great now. Tested with > 2000 tables. > However, I did not get what did the below change do. > > *diff --git a/web/pgadmin/misc/statistics/static/js/statistics.js > b/web/pgadmin/misc/statistics/static/js/statistics.js* > > *index cfd573e1..5441f883 100644* > > *--- a/web/pgadmin/misc/statistics/static/js/statistics.js* > > *+++ b/web/pgadmin/misc/statistics/static/js/statistics.js* > > @@ -104,7 +104,9 @@ define('misc.statistics', [ > > offText: gettext('False'), > > onColor: 'success', > > offColor: 'primary', > > - size: 'mini', > > + size: 'small', > > + width: null, > > + height: null, > > } > > ); > > > > @Committer, > > Except above change, all looks good to me. > > > > On Tue, Jan 29, 2019 at 3:17 PM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> I have also improved the performance of the properties tab. >> Please also apply the bootstrap toggle patch to check the properties tab >> performance. >> >> Thanks, >> Khushboo >> >> On Tue, Jan 22, 2019 at 5:05 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Khushboo, >>> >>> There is improvement than before but the UI still lags. I tested with >>> 2000 tables and statistics on Tables node. >>> I would also suggest to add further rows only if scrolling down. Rows >>> adding can be avoided even if the scroll does not take to the last element. >>> Currently, if I scroll slightly down it add rows and if I scroll back up >>> it adds more. I think the scroll up fetch can be avoided. >>> >>> On Mon, Jan 21, 2019 at 4:43 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Aditya >>>> >>>> Can you please review it. >>>> >>>> On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix the RM 3664 - Statistic panel >>>>> hangs when 1000+ tables >>>>> >>>>> The statistics tab hangs with more rows. So, now the rows will be >>>>> pushed in the backgrid collection in bunches on scroll event to fix this >>>>> issue. >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000b44e9e0580bda419 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied with the mentioned changes.=C2=A0
On T= hu, Jan 31, 2019 at 2:26 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:=
Hi = Khushboo,

The patch looks=C2=A0good to me and statistics works great n= ow. Tested with 2000 tables.
However, I did not get what did the below chan= ge do.

diff --git a/web/pgadmin/misc/statistics/static/js/statistics.js= b/web/pgadmin/misc/statistics/static/js/statistics.js

index cfd573e1..5441f883 100644

--- a/web/pgadmin/misc/statistics/static/js/statistics.js

+++ b/web/pgadmin/misc/statistics/static/js/statistics.js

@@ -104,7 +104,9 @@ define('misc.statistics', [

=C2=A0=C2=A0 =C2=A0 =C2=A0 offText: gettext('False'),

=C2=A0=C2=A0 =C2=A0 =C2=A0 onColor: 'success',

=C2=A0=C2=A0 =C2=A0 =C2=A0 offColor: 'primary',

-=C2=A0 =C2=A0 =C2=A0 size: 'mini',

+=C2=A0 =C2=A0 =C2=A0 size: 'small',

+=C2=A0 =C2=A0 =C2=A0 width: null,

+=C2=A0 =C2=A0 =C2=A0 height: null,

=C2=A0=C2=A0 =C2=A0 }

=C2=A0=C2=A0 );



@Committer,

Except above change, all looks good to me.



On Tue, Jan 29, 2019 at 3:17 PM Khushboo Vashi &l= t;khus= hboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached updated patch.
I have also improved t= he performance of the properties tab.
Please also apply the boots= trap toggle patch to check the properties tab performance.=C2=A0
=
Thanks,
Khushboo

On Tue, Jan 22, 2019 at 5:05 PM Ad= itya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Khushboo,

There is improvement than before but the UI still lags. I tested with= 2000 tables and statistics on Tables node.
I would also suggest to add further rows only if scroll= ing down. Rows adding can be avoided even if the scroll does not take to th= e last element.
Currentl= y, if I scroll slightly down it add rows and if I scroll back up it adds mo= re. I think the scroll up fetch can be avoided.

On Mon, Jan 21= , 2019 at 4:43 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Hi= Aditya=C2=A0

Can you please review it.

<= div class=3D"gmail_quote">
On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi <= khushb= oo.vashi@enterprisedb.com> wrote:
Hi,

Please fin= d the attached patch to fix the RM 3664 - Statistic panel hangs when 1000+ = tables

The statistics tab hangs with more rows. So= , now the rows will be pushed in the backgrid collection in bunches on scro= ll event to fix this issue.

Thanks,
Khus= hboo


--
Akshay Joshi
<= b>Sr. Software Architect
<= /div>

=

Phone: +91 20-3058-9517Mobile: +91 976-788-8246


--
Thanks an= d Regards,
Aditya To= shniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't Complain about Heat, Plant a tree"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--000000000000b44e9e0580bda419--