Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJcqh-0006FT-8L for pgadmin-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 12:52:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jJcqf-0002FS-HW for pgadmin-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 12:52:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJcqf-0002FK-05 for pgadmin-hackers@lists.postgresql.org; Wed, 01 Apr 2020 12:52:01 +0000 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jJcqU-0004cE-Fl for pgadmin-hackers@postgresql.org; Wed, 01 Apr 2020 12:51:59 +0000 Received: by mail-il1-x144.google.com with SMTP id 7so22865689ill.2 for ; Wed, 01 Apr 2020 05:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yDcnbwJIzTnZKxy7s8qPpfuud3GM6QTBNXzuC8aP1c8=; b=q+ECu7bW9iucu7NJ1BdCfOCF+Rai6YpEVb7uaf7J0xqlcUWEzeJQ75CJrxdMsBZUbv I9rg0sqHHJKpXymiAqejzPM88Vf+QThjV5alo/mj0/Va4fjn5lphhHVwhIInW1V9TDkR KULeDspAJiW68nCbzEYY/VGzqVbIwm+v2tkejXEiMW2l7eH7zm11d5ChbYRvNuZK0eeE Q/v0Tl/zM9O8eoTon7mS2mP7jKrHIudojo3ws7qJuRmUFVmyaIijkJ/dhvOOXOZWSpKm H157VzmHX3qFP2c7+k1MuUaEXh1wLd9aAAOBUOUKkUWgrJWD1k8lt+aQALgvA1M1b6ss lmnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yDcnbwJIzTnZKxy7s8qPpfuud3GM6QTBNXzuC8aP1c8=; b=CIHotkEwnZ7XI7mIjhPxXAI9ToYoV3EZYjGCHFdp2yUG9wlipIEy0QgIv3aRNVJYS1 3j83gebcWinZLaqe0kPksuZze/JvONB+uDYr8LjKMzVlYXJrPq+0kQraNCRfNpgvS6rI I1umZnesCgJ095br2/uMNTKM3L0iitRImZQ6SG2CAkjipf2AY326u68Rq1Ezq97oH6Oj ep8rzqhcOBkzvojGHJyad1aKwKhGAXbB1X3xeZDseyt0tyLIM8auQGkrZXIH26d7G+jC YH4FO2LnpOdgGDPG0e7TtMSbaimZf1hKHMYTeWhN9PLNrM+DP7124/b/ZXxohg98lZZA uU9g== X-Gm-Message-State: ANhLgQ3aiixea4DbjtNL/+nliho8pjObLeYrHwhu6bc42NRc7gc8/5Lq j1KYq/PjLIvJrVLLccrG+BMh/HJG4SMYGsNxnhGt8uHSDmdYMMuLB6srfkgmxQCaNk/YllX8ceo Bnt0jAv60dOvbHXfSNFf3CfoI8SRVX8NKU+aaGGR5oSHEQpk0s8KW/dGa4Vala6v+OTI4ob9ZZE SToo8mOEOWdSIVF0t8vtonZe6PLVeBhRwXIc05agx7tnOqBlJJcnQ= X-Google-Smtp-Source: ADFU+vtimwDjbi9QE/V+9FP5KevRsGLOQ6kK0C9plX4NlD0jdeMPGOaFBOy9+SnLkXWIjKyrqx7xrrntWssue0bHR9Y= X-Received: by 2002:a92:b0e:: with SMTP id b14mr22754885ilf.176.1585745509559; Wed, 01 Apr 2020 05:51:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 1 Apr 2020 18:21:38 +0530 Message-ID: Subject: Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000cd489605a23a2538" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000cd489605a23a2538 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Apr 1, 2020 at 6:05 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The issue was on PG9.6, fixed that. > Docs updated. > > Please review. > > On Wed, Apr 1, 2020 at 5:37 PM Akshay Joshi > wrote: > >> Documentation and Screenshot need to be updated. >> >> On Wed, Apr 1, 2020 at 5:10 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> Tested on 9.6, test cases are fixed but wrong SQL generated for tables: >>> CREATE TABLE public.test >>> ( >>> col1 bigint >>> ) >>> WITH ( >>> OIDS = FALSE,, >>> parallel_workers = 56 autovacuum_enabled = TRUE, >>> >>> Also parameter parallel_workers is not showing until we enabled the >>> autovacuum parameters. >>> >>> Please fix and resend the patch. >>> >>> On Wed, Apr 1, 2020 at 3:35 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> On Wed, Apr 1, 2020 at 2:51 PM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Aditya >>>>> >>>>> API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above. >>>>> Please fix and resend the patch. >>>>> >>>> The SQL is corrected for 9.6 versions. Others seems to be working fine. >>>> Attached is the updated patch. >>>> Please review. >>>> >>>>> >>>>> On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is a patch to add support for parameters toast_tuple_target >>>>>> (PG v11+) and parallel_workers(PG 9.6+) of table. Refer - >>>>>> https://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS >>>>>> . >>>>>> >>>>>> Both the parameters are added in the advanced tab of table dialog. >>>>>> >>>>>> The patch also fixes a related issue - RM5180, >>>>>> where autovacuum_enabled parameter is added automatically in the RE-SQL >>>>>> when table has been created with WITH parameter. >>>>>> >>>>>> Please review. >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect* >>>>> *EnterpriseDB Software India Private Limited* >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000cd489605a23a2538 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Apr 1, 2020 at 6:05 PM Adity= a Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the upd= ated patch. The issue was on PG9.6, fixed that.
Docs updated.

Please r= eview.

On Wed, Apr 1, 2020 at 5:37 PM Akshay Joshi <akshay.joshi@enterprise= db.com> wrote:
Documentation and Screenshot need to be updated.=C2= =A0

On Wed, Apr 1, 2020 at 5:10 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya=C2=A0

Tested on 9.6, test cases = are fixed but wrong SQL generated for tables:
CREATE TABLE public= .test
(
=C2=A0 =C2=A0 col1 bigint
)
WITH (
=C2=A0 =C2=A0 OID= S =3D FALSE,,
=C2=A0 =C2=A0 parallel_workers =3D 56 =C2=A0 =C2=A0autovac= uum_enabled =3D TRUE,

Also parameter=C2=A0para= llel_workers is not showing until we enabled the autovacuum parameters.

Please fix and resend the patch.

On Wed, Apr 1, = 2020 at 3:35 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> = wrote:
Hi Akshay,

On Wed, Apr 1, 2020 at 2:51 PM Aks= hay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above. Ple= ase fix and resend the patch.
The SQL is corrected= for 9.6 versions. Others seems to be working fine. Attached is the updated= patch.
Please review.=C2=A0

On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal <= ;adi= tya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is a=C2=A0= patch to add support for parameters toast_tuple_target (PG v11+) and parall= el_workers(PG 9.6+) of table. Refer -=C2=A0https://www.postgresql.org/docs/11/sql-createtable.html#SQL-C= REATETABLE-STORAGE-PARAMETERS.

Both t= he parameters are added in the advanced tab of table dialog.

The patch also fixes a related issue - RM5180, where=C2= =A0autovacuum_enabled parameter is added automatically in the RE-SQL when t= able has been created with WITH parameter.

Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0EnterpriseD= B India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000cd489605a23a2538--