Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iuX4D-000475-UD for pgadmin-hackers@arkaria.postgresql.org; Thu, 23 Jan 2020 07:38:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iuX4C-0003tt-Ns for pgadmin-hackers@arkaria.postgresql.org; Thu, 23 Jan 2020 07:38:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iuX4C-0003tm-Cu for pgadmin-hackers@lists.postgresql.org; Thu, 23 Jan 2020 07:38:16 +0000 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iuX49-0000DQ-Ti for pgadmin-hackers@postgresql.org; Thu, 23 Jan 2020 07:38:14 +0000 Received: by mail-il1-x144.google.com with SMTP id f10so1398369ils.8 for ; Wed, 22 Jan 2020 23:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mec3IhqhXgdQrvDea1qUJj9CvNwddARQSDYG3koFVJc=; b=EUfoPdZVqf5WAHq6P22DcZIFjAevRrwPmNh+iMHerJxHusI+6CXrcBwickqQGkjCWR Fv1Xq8NGx7hwGcKOXU/JP6UUgS+/Xk8UvP2H00K+JtW8BOlzyhXLy26TatXaDuJ6PZ+q FX2Q8yWNrt1XaszO0/s3fCgSn5JmzcW/13ZeMXtryepYIorCMxqFJHgfws3YS/yqK0ar ZZZD5qsq5MTkSidbH0IQKLvLBJw38h56pcXAYBDnqFv78gOmajUYO3HdKx1+9YzppuWx zRtYN5TWxgyo2PA5rJr2sZDLEdMh4GGdD6TeolJXl0qRzVqxMcSMfgwDX+9o0RhvsweK U3Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mec3IhqhXgdQrvDea1qUJj9CvNwddARQSDYG3koFVJc=; b=uVWZ5i5Zh2mSVdBywpn6f5153zNi49eOP3u0qWP1MgAfpB2jabnEbFNccyzoYvTs2T DHE4/1YMs6ZYRakRdVAi1qc7wMp7rU7jBDz2M7hNW9EG079lDuzTpessWZlmJ5Upa+HN 8yzTeaFVX1RCq02OBzvxMW96kB2pVajm5QksyKCs47xfHz16mIOOhbu7nzIRk7KAR+PT 1EHztfw3CgGss6fTbA+bGRx833Z6z9uHDYaTYJg6feqbt2GQdAVBCHsGH1V12M4LhDSa Z5+pSeKx7prAEh1tvy3ZK//dQeaosXkJRKq8zrqVPr3Uz1P/XacHEz4Hv+eE33nglAI9 mxvA== X-Gm-Message-State: APjAAAUgamiBU/FK6WHLdGVRqFcoHuwulHaXfuP6xQEZt3Qo2Y8CN4IJ e7OaDmfswO76I1LwYX973yP4StyUFuIIgY8JFblOuiryx5MehDtVjaZm5Tt3gH++WTr83V/W8/s p3N9x2bOXTf/n2/fPC3WNISLS/mBSoBAUPYMHTvU2L6A8wCHUYxP9brXJ89g2psTHuGaA0WZtBr k+F8RUbiXxH6ndbpXfzY5tybCBczYFonV9Y5wg41pYZ01hiOjLA2Lm8A== X-Google-Smtp-Source: APXvYqwKbtLu9rAFCRgX0CjiZ0+p9mFj8eE67q4Db9xl1m4iGnCxSbl8C95HaTknGqaKZejAF5QuXIFBFAycEfLYMBI= X-Received: by 2002:a92:51:: with SMTP id 78mr11462161ila.121.1579765092418; Wed, 22 Jan 2020 23:38:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 23 Jan 2020 13:08:01 +0530 Message-ID: Subject: Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000299c1b059cc9b98b" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000299c1b059cc9b98b Content-Type: text/plain; charset="UTF-8" Hi Aditya As per discussion, we should visit all the nodes create/edit dialog and make the controls read-only wherever appropriate. On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to allow input controls to be set as readonly > instead of disabled. > I've also changed the code for the nodes to make sure properties tab have > readonly fields wherever applicable. This will allow tab navigation in > properties tab and also allow screen readers to read it. > Please note that, I've not visited each and every node create/edit dialog > to identify what should be readonly or what should be disabled as it > depends on business logic. The patch is mainly for the properties tab. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000299c1b059cc9b98b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

As per discussion, we sh= ould visit all the nodes create/edit dialog and make the controls read-only= wherever=C2=A0appropriate.

On Wed, Jan 22, 2020 at 5:46 PM Aditya Tos= hniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch = to allow input controls to be set as readonly instead of disabled.
I've= also changed the code for the nodes to make sure properties tab have reado= nly fields wherever applicable. This will allow=C2=A0tab navigation in prop= erties tab and also allow screen readers to read it.
Please note that, I= 9;ve not visited each and every node create/edit dialog to identify what sh= ould be readonly or what should be disabled as it depends on business logic= . The patch is mainly for the properties tab.

Kindly review.

--
<= div>
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker = | Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain abo= ut Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000299c1b059cc9b98b--