Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3PzM-0007Qu-6c for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 May 2016 15:35:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b3PzL-00066F-2l for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 May 2016 15:35:51 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b3Pz7-0005sQ-Bl for pgadmin-hackers@postgresql.org; Thu, 19 May 2016 15:35:37 +0000 Received: from mail-oi0-x22e.google.com ([2607:f8b0:4003:c06::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b3Pz3-0005Bz-W0 for pgadmin-hackers@postgresql.org; Thu, 19 May 2016 15:35:36 +0000 Received: by mail-oi0-x22e.google.com with SMTP id x201so134736439oif.3 for ; Thu, 19 May 2016 08:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=UGZFYp9u/pvv/wDZ5G7Kmc5UsvaBZMAOlAhWex6bSXc=; b=w0I2PHbB4tUYnStfdnWbs6ZvIqJLyosPD0+HClzMZvYlo7qA6kmvxoNTNuuxqYCRdX uskOPMacP0mZojkIBvyhT9n8v5t9A6wYXcK+ABGM6+ZuC1gpfFM/boEjJFHCO2qtt5cM QzrLIvHNCzhSIFACrErkovDoaUEqVf7UO4VBcxcEkrFROcaS/RNJv33hOcIEd1JAZJp4 +TPuaIuZfDM7e5f+w4+i08CucTqEo8VhOsnStbwnpA3tp+RxU4sJzU3oVCRMWcNIvCcR K18bqi3SgHct1VbspNX5iDu4mRoa8RmeNGkk4tGFFScLe9gVSNyEMCvCFcHaDt9Jd0OU 5CFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=UGZFYp9u/pvv/wDZ5G7Kmc5UsvaBZMAOlAhWex6bSXc=; b=TIy6ag6jIInSBjrUF0WvmgtRh8YfI6iivtzleP9/Bkrz5DmFHESpc/L9W1PsEYW7b7 pv5/z4M2WVmSOwMgOGCxegtVn2wByhEErl4McfKk+LcWK12hMq07Kh9gScFq4iK/rOei nGLtGRnHAo3xKqGcIXBU8dFsGCD1UZDovy3IawaHGPPaq5v+PdqlqKfEmmD6Bl0DIfpg ahMfFtujmsEvWiW+QmB+CEFiYsBIQuVQjIJ4QCJPEGzo1n2xzgdh6TuTcOIpUDiXDX2r qB69nbVDiOnB8uDAnAVqa2QF8i5C+f2GDEeS/hi9qhwp8t2C7vNH5cB9YHMQwR8PDeuC KVHg== X-Gm-Message-State: AOPr4FWFt9ZVXsQ8PUUH/RtA57wDgxtje0uNDunec1WTACltJZvfZhONMHimDM19/TSkxJe4saH+KbH+pgn5IXKk MIME-Version: 1.0 X-Received: by 10.202.68.138 with SMTP id r132mr8730144oia.72.1463672133210; Thu, 19 May 2016 08:35:33 -0700 (PDT) Received: by 10.202.175.148 with HTTP; Thu, 19 May 2016 08:35:33 -0700 (PDT) In-Reply-To: References: Date: Thu, 19 May 2016 21:05:33 +0530 Message-ID: Subject: Re: PATCH: FTS configuration node From: Akshay Joshi To: Ashesh Vashi Cc: Sanket Mehta , Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113dafd6916c1e053333b9e2 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113dafd6916c1e053333b9e2 Content-Type: text/plain; charset=UTF-8 Thanks - Committed with some modification and fixes. On Wed, May 18, 2016 at 12:57 PM, Ashesh Vashi < ashesh.vashi@enterprisedb.com> wrote: > > On Wed, May 18, 2016 at 12:52 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> >> On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < >>> sanket.mehta@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA the revised patch. >>>> Response is lnline. >>>> >>>> Regards, >>>> Sanket Mehta >>>> Sr Software engineer >>>> Enterprisedb >>>> >>>> On Tue, May 17, 2016 at 12:54 PM, Harshal Dhumal < >>>> harshal.dhumal@enterprisedb.com> wrote: >>>> >>>>> Hi Sanket, >>>>> >>>>> Please find my review comments below: >>>>> >>>>> 1. In create mode it generates wrong sql. >>>>> >>>>> CREATE TEXT SEARCH CONFIGURATION test.asdf ( >>>>> COPY= >>>>> ); >>>>> >>>>> steps to reproduce: >>>>> a] Fill up any necessary fields in general tab. >>>>> b] On definition tab set Copy config filed and navigate to SQL tab. >>>>> c] Come back again to definition tab clear Copy config field and >>>>> set Parser field and again navigate to SQL tab >>>>> >>>> Fixed >>>> >>>>> >>>>> 2. Create new FTS configuration with parser throws below error. >>>>> >>>>> provide atleast copy config or parser. >>>>> >>>>> (this is because you have used key name for parser in js as "prsname" >>>>> and in python you have applied validations on key "parser") >>>>> >>>> Fixed >>>> >>>>> >>>>> 3. When we clear dictionary for any token using cross (x) button in >>>>> select2; JavaScript code for selecct2 fails. (see attached screenshot) >>>>> >>>> This occurs due to issue in select2 control. Its a generalized issue >>>> which will be resolved later. >>>> >>> When you say - it is common issue, can you please point where else >>> you've seen this behaviour? >>> >> The same behaviour occurs in all nodes where multiselect cell is being >> used like, exclusion control, debugger etc. >> > We do not have MultiSelectCell. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > >> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Software Engineer * >>>>> >>>>> >>>>> >>>>> EenterpriseDB >>>>> >>>>> On Mon, May 16, 2016 at 7:37 PM, Sanket Mehta < >>>>> sanket.mehta@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Revised patch is attached with this mail. >>>>>> My response is inline. >>>>>> >>>>>> >>>>>> Regards, >>>>>> Sanket Mehta >>>>>> Sr Software engineer >>>>>> Enterprisedb >>>>>> >>>>>> On Fri, May 13, 2016 at 6:20 PM, Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Sanket >>>>>>> >>>>>>> Below are my review comments: >>>>>>> >>>>>>> >>>>>>> - Add button should be disabled in Tokens tab while creating. >>>>>>> >>>>>>> Done >>>>>> >>>>>>> >>>>>>> - Unable to click on down arrow for token select control. >>>>>>> >>>>>>> Done >>>>>> >>>>>>> >>>>>>> - Title should be change from "Create FTS-dictionaries" to >>>>>>> "Create FTS-Configuration". >>>>>>> >>>>>>> Done >>>>>> >>>>>>> >>>>>>> - Tree node is not getting refreshed on name change. >>>>>>> >>>>>>> Done >>>>>> >>>>>>> >>>>>>> - Unable to rename FTS Configuration when name contains any >>>>>>> capital letter. >>>>>>> >>>>>>> Done >>>>>> >>>>>>> >>>>>>> - If user tries to add already existing token then respective >>>>>>> row in the backgrid should be highlighted. >>>>>>> >>>>>>> Done >>>>>> >>>>>>> >>>>>>> - "URL not found" when click on SQL help icon from the >>>>>>> properties dialog. >>>>>>> >>>>>>> Done >>>>>> >>>>>>> >>>>>>> - SQL should not be generated when remove and add the same token >>>>>>> again. Currently it is creating two sql's one for remove and >>>>>>> another is for add. >>>>>>> - *Fix for the above issue is*: - Add "keys: ['token']," to >>>>>>> TokenModel in your js file. >>>>>>> >>>>>>> Done >>>>>> >>>>>> >>>>>>> >>>>>>> On Fri, May 13, 2016 at 2:58 PM, Sanket Mehta < >>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi All, >>>>>>>> >>>>>>>> Last patch for FTS configuration does not contain node.ui.js file >>>>>>>> Kindly ignore it. >>>>>>>> >>>>>>>> Here is the new revised patch attached with this mail. >>>>>>>> Please do review it and let me know if any changes required >>>>>>>> >>>>>>>> Regards, >>>>>>>> Sanket Mehta >>>>>>>> Sr Software engineer >>>>>>>> Enterprisedb >>>>>>>> >>>>>>>> On Thu, May 12, 2016 at 4:38 PM, Sanket Mehta < >>>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> PFA the revised patch. >>>>>>>>> Please do review it and let me know if anything is not proper. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Sanket Mehta >>>>>>>>> Sr Software engineer >>>>>>>>> Enterprisedb >>>>>>>>> >>>>>>>>> On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal < >>>>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> + patch link >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> http://www.postgresql.org/message-id/CAFiP3vwkka+=1FOJ7kr2zbC4AzecoCa9eO9DZ34-Oyy_9gE92g@mail.gmail.com >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Harshal Dhumal* >>>>>>>>>> *Software Engineer * >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> EenterpriseDB >>>>>>>>>> >>>>>>>>>> On Thu, May 5, 2016 at 8:18 PM, Sanket Mehta < >>>>>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> PFA first patch for FTS configuration node. >>>>>>>>>>> >>>>>>>>>>> It depends upon backgrid select2cell multi select control, for >>>>>>>>>>> which Harshal has sent the patch recently. >>>>>>>>>>> Please do apply his patch first and then apply this patch. >>>>>>>>>>> >>>>>>>>>>> Please do review it and let me know if any changes are required. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Sanket Mehta >>>>>>>>>>> Sr Software engineer >>>>>>>>>>> Enterprisedb >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>>>> To make changes to your subscription: >>>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>> To make changes to your subscription: >>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Akshay Joshi* >>>>>>> *Principal Software Engineer * >>>>>>> >>>>>>> >>>>>>> >>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>>>>> ) >>>>>> To make changes to your subscription: >>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a113dafd6916c1e053333b9e2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - Committed with some modification and fixes. =C2= =A0

On Wed, = May 18, 2016 at 12:57 PM, Ashesh Vashi <ashesh.vashi@enterpris= edb.com> wrote:

On Wed, May 18, 2016 at 12:52 PM, Sanket Mehta <sa= nket.mehta@enterprisedb.com> wrote:

=
On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi <<= a href=3D"mailto:ashesh.vashi@enterprisedb.com" target=3D"_blank">ashesh.va= shi@enterprisedb.com> wrote:

On Wed, May 18, 2016 at 12:= 41 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:

Hi,

PFA t= he revised patch.
Response is lnline.

Regards,
Sanket Mehta
Sr Software engineer
Enterpr= isedb

On Tue, May 17, 2016 at 12:54 P= M, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
= Hi Sanket,

Please find my review comments below:

= 1. In create mode it generates wrong sql.

CREATE TEXT SEARCH CONFIGU= RATION test.asdf (
=C2=A0=C2=A0=C2=A0 COPY=3D
);
steps to reproduce:
=C2=A0=C2=A0=C2=A0 a] Fill up any necessa= ry fields in general tab.
=C2=A0=C2=A0=C2=A0 b] On definition tab set Co= py config filed and navigate to SQL tab.
=C2=A0=C2=A0=C2=A0 c] Com= e back again to definition tab clear Copy config field and set Parser field= and again navigate to SQL tab
Fixe= d=C2=A0

2.= Create new FTS configuration with parser throws below error.

provide atleast copy config or pars= er.

(this is because you have used key = name for parser in js as "prsname" and in python you have applied= validations on key "parser")
=
Fixed=C2=A0

3. When we clear dictionary for any token using cross (x) butt= on in select2; JavaScript code for selecct2 fails. (see attached screenshot= )
This occurs due to issue in select2 con= trol. Its a generalized issue which will be resolved later.
When you say - it is common issue, can you= please point where else you've seen this behaviour?
<= /div>
The same behaviour occurs in all nodes w= here multiselect cell is being used like, exclusion control, debugger etc.<= /div>
We do not have MultiSe= lectCell.

--

Thanks & Regards,

Ashesh Vashi<= /span>
Ent= erpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company



--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company

<= p style=3D"margin:0pt">






--=C2= =A0
Harshal Dhumal
Software Engineer=C2=A0




On Mon, May 16, 2016 at 7:3= 7 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

Revis= ed patch is attached with this mail.
My response is inline.
=


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, May 13, 2016 at 6:20 PM= , Akshay Joshi <akshay.joshi@enterprisedb.com> w= rote:
Hi Sanket=C2=A0
Below are my review comments:

    =
  • Add button should be disabled in Tokens tab while creating.
Done=C2=A0
  • Unable to click on down arrow for token se= lect control.=C2=A0
Done= =C2=A0
  • Title shou= ld be change from "Create FTS-dictionaries" to "= ;Create FTS-Configuration".
Done=C2=A0
  • Tree node is not getting refreshed on name change.
    • <= /ul>
Done=C2=A0
  • Unable to rename FTS Config= uration when name contains any capital letter.
Done=C2=A0
  • If user tries to add already existing token then respective= row in the backgrid should be highlighted.
Done=C2=A0
  • "URL not found" when click on SQL= help icon from the properties dialog.=C2=A0
<= /div>
Done=C2=A0
=
  • SQL should not be generated when= remove and add the same token again. Currently it is creating two sq= l's one for remove and another is for add.
    • Fix fo= r the above issue is: - Add "keys: ['token']," to TokenModel in your js file.
Done
=C2=A0

O= n Fri, May 13, 2016 at 2:58 PM, Sanket Mehta <sanket.mehta@en= terprisedb.com> wrote:
H= i All,

Last patch for FTS configuration does not contain= node.ui.js file
Kindly ignore it.

Here = is the new revised patch attached with this mail.
Please do revie= w it and let me know if any changes required

Regards,
San= ket Mehta
Sr Software engineer
Enterprisedb
=

On Thu, May 12, 2016 at 4:3= 8 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA t= he revised patch.
Please do review it and let me know if anything= is not proper.

Regards,
Sanket Mehta
Sr Softwa= re engineer
Enterprisedb

On Thu, May 5, 2016 at 8:19= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:

--=C2=A0
Ha= rshal Dhumal
Software Engineer=C2=A0

On Thu, May 5, 2016 at 8:18 PM, Sa= nket Mehta <sanket.mehta@enterprisedb.com> wrote= :
Hi,

PFA first patch for FTS configuration node.

It depends upon backgrid select2cell multi select control, for which Har= shal has sent the patch recently.
Please do apply his patch first= and then apply this patch.

Please do review it an= d let me know if any changes are required.


Regards,
Sanket Mehta
S= r Software engineer
Enterprisedb


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay Joshi
Principal Softw= are Engineer=C2=A0
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;= border-collapse:collapse">
<= /b>
=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246<= /font>



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=







--
Akshay Joshi
Principal Software Engineer=C2= =A0


=
Pho= ne: +91 20-3058-9517
Mobile: +91 976-788-8246
--001a113dafd6916c1e053333b9e2--