Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJc9r-0003Nh-BV for pgadmin-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 12:07:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jJc9q-0001W6-81 for pgadmin-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 12:07:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJc9p-0001Vz-Tz for pgadmin-hackers@lists.postgresql.org; Wed, 01 Apr 2020 12:07:46 +0000 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jJc9n-0004Gv-9t for pgadmin-hackers@postgresql.org; Wed, 01 Apr 2020 12:07:44 +0000 Received: by mail-il1-x144.google.com with SMTP id j9so22793951ilr.7 for ; Wed, 01 Apr 2020 05:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5JcvI4h1KPX9Q1uECMBsCQvQyORoXHHIrjoOeXtkQJ8=; b=Sk6ldItVfP3XSrNiedzj3r2DPYA0mgBWyexB4A/5PF3hSJceAZGqNK8Uej5HMTlLYu keMqNZbIAnUeRmDiYYwMZ2Ysi5S2XC1D/p/ygWyGXyObCu99VujpAewz2Fy13nIMvMwX 20pzOelETAbxtnI2kAZhk2yPcVpGeeoGeQed/hOUZKwT9sLqn1EBNfqB1ItIKbQFk9yF h03l4JU6p6WnvQ/+uZvkISQiIv7OTaJr9wJd14diui8c87qpv/uwTTH7gZoyllAzuQrn 84HM0gzCoMVtxAPoOtP2R/w0rz0Lf9sFBuybzMmANEq9af4544Ls+F/uoRHJhS+n6dc+ 7iTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5JcvI4h1KPX9Q1uECMBsCQvQyORoXHHIrjoOeXtkQJ8=; b=kAzItXW7QkuBMusec3KM0kdz8mtsWLPx0POEP73Xr695RsX1IRA6Aa7993ydckOo5J pyqUuf96piYvoCIyrEShvC9ijW8GdQ9i6syJwisJc6uvXbi8X0xi8jaXnLN6AFssxrdn aMcAWRaYtSDwE4cl+ATN4tGewjLnGLBdu4Vi/FUY/2mLIHD6z6JiwFQOa8wNy9ta6g7b FxoZ0iWvzQcyv5cPk+uPTU4ogEHWa6sjR+LQ3ydFECOFZ0NDTc6ml61tOHjKpv8t4AWk 5aZ3vqbei67pHSrl7jbt3Kv3HYHS5X+DE1Hk7czUaRb3Ap2RZmZi7NphuzDR3EyqVLOp 4roA== X-Gm-Message-State: ANhLgQ3tZMrj7C6TI5LD7K4p1De0jnb8vuVPfuimqwSmPBXR173PoME4 965/Usf6jVv4KNNCeYDbMIGfJTRlcZxMvO9/iSlvMgbSlkRLsvEilPN06gScUuW1vP1qqB18v7+ 1T9n+4BJHCU0x+CkRATNoJCojs1wU6ZPsR7LNeMPCAlVwFo2d5bAw3A4gyNYrB+LyAgY4G5Q7w1 Lx3dChlwmHOybWQJWug4fCjiqhSA4Exu2pM4eqyCowf9JmafkPLHY= X-Google-Smtp-Source: ADFU+vuSURaNzbiow6Yv/vuZWxozkSd1ZPXk3gq+xhrt2FVFLyrRwZ7T6eZIVZSbR8HRGTjB7Nc7YAH/tSL9qkXUHLA= X-Received: by 2002:a92:5b17:: with SMTP id p23mr21125355ilb.121.1585742862013; Wed, 01 Apr 2020 05:07:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 1 Apr 2020 17:37:30 +0530 Message-ID: Subject: Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000fef27705a23987c3" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000fef27705a23987c3 Content-Type: text/plain; charset="UTF-8" Documentation and Screenshot need to be updated. On Wed, Apr 1, 2020 at 5:10 PM Akshay Joshi wrote: > Hi Aditya > > Tested on 9.6, test cases are fixed but wrong SQL generated for tables: > CREATE TABLE public.test > ( > col1 bigint > ) > WITH ( > OIDS = FALSE,, > parallel_workers = 56 autovacuum_enabled = TRUE, > > Also parameter parallel_workers is not showing until we enabled the > autovacuum parameters. > > Please fix and resend the patch. > > On Wed, Apr 1, 2020 at 3:35 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Akshay, >> >> On Wed, Apr 1, 2020 at 2:51 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above. Please >>> fix and resend the patch. >>> >> The SQL is corrected for 9.6 versions. Others seems to be working fine. >> Attached is the updated patch. >> Please review. >> >>> >>> On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is a patch to add support for parameters toast_tuple_target >>>> (PG v11+) and parallel_workers(PG 9.6+) of table. Refer - >>>> https://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS >>>> . >>>> >>>> Both the parameters are added in the advanced tab of table dialog. >>>> >>>> The patch also fixes a related issue - RM5180, where autovacuum_enabled >>>> parameter is added automatically in the RE-SQL when table has been created >>>> with WITH parameter. >>>> >>>> Please review. >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000fef27705a23987c3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Documentation and Screenshot need to be updated.=C2=A0
On W= ed, Apr 1, 2020 at 5:10 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya= =C2=A0

Tested on 9.6, test cases are fixed but wrong SQL= generated for tables:
CREATE TABLE public.test
(
=C2=A0 = =C2=A0 col1 bigint
)
WITH (
=C2=A0 =C2=A0 OIDS =3D FALSE,,
=C2= =A0 =C2=A0 parallel_workers =3D 56 =C2=A0 =C2=A0autovacuum_enabled =3D TRUE= ,

Also parameter=C2=A0parallel_workers is not = showing until we enabled the autovacuum parameters.

Please fix and resend the patch.

On Wed, Apr 1, 2020 at 3:35 PM Adit= ya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
= Hi Akshay,

On Wed, Apr 1, 2020 at 2:51 PM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Hi Aditya

API/RESQL test = cases are failing for EPAS/PG 9.6 and maybe above. Please fix and resend th= e patch.
The SQL is corrected for 9.6 versions. = Others seems to be working fine. Attached is the updated patch.
Please review.=C2=A0

On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal <aditya.toshniwal@ente= rprisedb.com> wrote:
= Hi Hackers,

Attached is a=C2=A0patch to add suppo= rt for parameters toast_tuple_target (PG v11+) and parallel_workers(PG 9.6+= ) of table. Refer -=C2=A0http= s://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREATETABLE-STORAGE= -PARAMETERS.

Both the parameters are = added in the advanced tab of table dialog.

Please review.

--
Thanks= and Regards,
= Aditya Tosh= niwal
= pgAdmin Hacker | Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don'= ;t Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000fef27705a23987c3--