Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Cmn-0004In-No for pgadmin-hackers@arkaria.postgresql.org; Wed, 20 Jan 2021 12:40:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l2Cmm-0005h3-LY for pgadmin-hackers@arkaria.postgresql.org; Wed, 20 Jan 2021 12:40:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Cmm-0005gw-EI for pgadmin-hackers@lists.postgresql.org; Wed, 20 Jan 2021 12:40:32 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2Cmk-0000i1-57 for pgadmin-hackers@postgresql.org; Wed, 20 Jan 2021 12:40:32 +0000 Received: by mail-io1-xd2f.google.com with SMTP id q1so46512832ion.8 for ; Wed, 20 Jan 2021 04:40:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xze+WwG52yTUx8dQHOZiCqtlCSauvq3wqmT3ERh3ZW0=; b=kDe+UNA9T4J+uukgEh7Kj194GkqS8mMIQ21nzClzxAMyugPG7rKhBvtROo2OxQZaec HCdH0arA5+JxdyEh1LJls3HSNrvtOLpA5gns7PI8+z9D9zNPVDzc89rziXKRAOxaPgLz 0W1dJS1rR64rS+hsxKPlIwUOkn3zBgxKP1rFj9xfIdm+t6JGIIGVGVbHwMC4XDkGQt0X CEK/BEIYg9w8AzP7WrnZlEwv55y+XuhevX5a5e7EKjasIur7Ii49Sc0RGQxDNyJ8yxeo IxIvGxF2Dm/LUjMB7DtN69LxEukStjxmHc3EP++evpZcbMWqn9uQ1CjAfLuaw2UJ72gI 1r8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xze+WwG52yTUx8dQHOZiCqtlCSauvq3wqmT3ERh3ZW0=; b=BqQIyJ3f45cY0wOTf4rz+9JSP4/I6Hc99kC59KdHH9pxm6biNwHk0kJmdwSGMbFDhD Lwvq6o416JqRDCtVYzJ8p32of0f8X0oMNU2h8FNTDCTnHgo2hNmtKLwoj6xeJ17quhsY lnQbnklIOOJS6RbvVbDt3cmg41FdvXXKyqQbTxm8HYdXktJ/rTswa8jQQb9CUkj+gRsr V/LF2kO+VIANn/kwvcbvCtBM81Kgar9XblTHAY2zY17RFjQ2hDiH9WRAbyNEow4tZrWM RcDB9HjTUXUYIw1SSf0SEfbkViZyeeZiz0nT+6If3zjHQwq94XuXQpHe658YuvnLCTa5 XFPA== X-Gm-Message-State: AOAM531r3b0f0EERsubeAX2vni8qK44JlQHhVnnLXogT9WQx1sBoijlZ JUdxMSadxhrTymYn30npKgHUAcPk3ZG7lvP3RZSituz0nhGS1tvk20b1wZsyKK3Y7Z6LJKiTKPN SKvgd3A5H7TDaM9wGfbVATP4jY0E6RaMKwmHfHDs2LWYDltMIMIO68HkHUZzYOI4P9Rwk+z/8ge YhhpV/mu+3rowdPf/GaQNSWrQ60DArJNJ8nLXpI8SXlM/KpTVq9zGVLxnrpw== X-Google-Smtp-Source: ABdhPJwtnsczhlLjjdeWFnP4re6c0X0anA6h9Nw6IVMfmRq98Q2owGwr41Y9jyoNxuDLq1m2WsFEa95sDMWBTmskQHU= X-Received: by 2002:a92:cd81:: with SMTP id r1mr7622594ilb.252.1611146428677; Wed, 20 Jan 2021 04:40:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 20 Jan 2021 18:10:17 +0530 Message-ID: Subject: Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000901cd005b9544234" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000901cd005b9544234 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Jan 20, 2021 at 4:37 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch: > 1) Fixes the broken explain GUI test case. > 2) Displays a tooltip "Click for details..." on hover over explain plan > nodes. > > Please review. > > On Tue, Jan 12, 2021 at 4:45 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Attached is the updated patch. Please review. >>> >>> On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Aditya >>>> >>>> Code looks good to me. Below are the review comments: >>>> >>>> - Copy and Paste not working in the popup. >>>> - Documentation needs to be updated. >>>> >>>> >>>> On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached patch improves the way explain plan details tooltip for a >>>>> node is shown. With the change, popup with details will be shown upon >>>>> clicking a node, and it will remain open until explicitly closed. >>>>> >>>>> Please review. >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>> >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000901cd005b9544234 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Jan 20, 2021 at 4:37 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch:
1)= Fixes the broken explain GUI test case.
2) Displays a tooltip "Cl= ick for details..." on hover over explain plan nodes.

Please rev= iew.

On Tue, Jan 12, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprised= b.com> wrote:
Thanks, patch applied.

On Tue, Jan 12, 2021 at 4:08 PM= Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

Attached is the updated patch. Please review.

On Tue, Jan 12, = 2021 at 2:51 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi= =C2=A0Aditya

Code looks good to me. Below are the review= comments:
  • Copy and Paste not working in the popup.
    • <= li>Documentation needs to be updated.

On Mon, Jan 11, 2021= at 4:38 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrot= e:
H= i Hackers,

Attached patch improves the way explain plan details toolti= p for a node is shown. With the change, popup with details will be shown up= on clicking a node, and it will remain=C2=A0open until=C2=A0explicitly clos= ed.

Please review.

--
Thank= s,
Aditya Toshniwal<= /span>
<= /font>
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
"Don'= ;t Complain about Heat, Plant a TREE"
<= /div>


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000901cd005b9544234--