Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjehe-0005fV-MW for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Jan 2019 06:29:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gjehd-000734-9Q for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Jan 2019 06:29:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjehc-0006zy-Rw for pgadmin-hackers@lists.postgresql.org; Wed, 16 Jan 2019 06:29:29 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjehZ-0001Ks-0C for pgadmin-hackers@lists.postgresql.org; Wed, 16 Jan 2019 06:29:27 +0000 Received: by mail-qk1-x744.google.com with SMTP id q8so3160473qke.1 for ; Tue, 15 Jan 2019 22:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cvXwxtwzrby0264b6VAHuUX+nWbnTYKx0lQDkWvmBgo=; b=pHLZweYOIAx/pQA0u0CTc3W+yI1hYKk6+1wdLFcXrnw2JReV0OgIJ51pl+cFh/p8/h w3l6scfoh4wWeRYoi5++dsZz7BpFpE2C11SiJPI+CQ8LNDav5oNxkAhuUe9KEJPPUlCq xbDHQsl3muT+w/gbnszFqi6IFgVWYMfGcjLuluGg3CTj5WFPy7jaBIv/A6dsx3eYVjA9 GKO7RLfqb++Fz2NjW9DN6xM097i/fkXrHT/+KcO+BvRBult45LhSTJeNEvJycJHhC3A8 Hr8OHT4HrFPtlwsarHMa5Qku9lEK4HBHxWgQsFVeNxL3Vh0WFs/sjvOm0ZFzqMCsCZ6I QglA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cvXwxtwzrby0264b6VAHuUX+nWbnTYKx0lQDkWvmBgo=; b=FzXYVuvJ2Y+E38kQb6kDDVpiJWiVlxqh6tJU7E0qvtoKGpDrQE5Awkc0Rx17VPERT6 frDMriOXcJLrrjOGqUuLiIuULvbxPg90GGxyoLfb4dmrTBsVc3fJaMAqwCovLs1x30lq 5b9frf3m2JJ8S28GRGdsHkE2I37Sd/D1XgszrXUFY696QjDMEW2GBNCJM2NUzE+QYKZC JOEfK3Idk/b/tUc96e4MMk3RT+JrF6LmPbqtOud8wN3jv5KlQ2DMAaNUry7yzu4/a4Jh qyPX8P3PVrn3E68AKKytQ19naCR18PiM8uDoha4iXuysrFVXTOgLqKpkuLMCBDPv1dBY eWkA== X-Gm-Message-State: AJcUukcNNLvlQvfqlvQatL58yZwktg7kJ+2yPBIc7IHZh15sfHr5qsW/ DNqqAfOxoFn6ZiHfMbqDqKw+HgEz4SgrQ2Y8lfX+ag== X-Google-Smtp-Source: ALg8bN7jU2wTf9ktPwmnpN3B0f2TvbmZAM/lWfI3TcYhP830KxNQ6AXYFe8nzJuvlShryIzoEdl1vaunaabfOoHJCvQ= X-Received: by 2002:a37:d91:: with SMTP id 139mr5388620qkn.166.1547620163836; Tue, 15 Jan 2019 22:29:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 16 Jan 2019 11:59:12 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica To: Aditya Toshniwal , Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001cf1bf057f8d6608" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001cf1bf057f8d6608 Content-Type: text/plain; charset="UTF-8" Thanks patch applied without Tree Changes. On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal wrote: > Hi Hackers, > > Attached is the patch for further design improvements: > - Process watcher made fixed width with header changes, time details > rounded to 2 decimals > - Query history will show "No query history" if no query fired. Query > editor default size increased. > - Tree improvements - right bold border removed completely. Now click > anywhere on a tree item to perform actions. Please note, single click on > the tiny tree arrow button will not work with this. Clicking anywhere is > more useful than this. > @Dave Should we proceed with this behaviour, I haven't commit it. > - Fixed a bug where New folder create button not working when in List mode > and No files/folder present. > - Other minor improvements. > > Kindly review. > > On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for few more changes: >> - New Folder button was not working in file dialogue. Fixed that. >> - Color, icon changes in file dialogue >> - Also replaced the splash screen image (which is used on main dashboard >> also). It works fine on dashboard. However, I'm not sure of the splash >> screen as the new image is SVG and older was PNG. I have made changes for >> that in runtime code but I'm not able to test (evnvironment issue) runtime >> code :(. It would be helpful if someone else can try it once. >> >> Kindly review. >> >> >> On Mon, Jan 7, 2019 at 2:25 PM Dave Page wrote: >> >>> Thanks - applied! >>> >>> On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal >>> wrote: >>> > >>> > Hi Hackers, >>> > >>> > Attached is the patch to incorporate the changes discussed in trailing >>> mail(s). >>> > >>> > Kindly review. >>> > >>> > On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote: >>> >> >>> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal >>> >> wrote: >>> >> > >>> >> > Hi, >>> >> > >>> >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: >>> >> >> >>> >> >> Hi >>> >> >> >>> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >> >>> >>> >> >>> Hi Dave, >>> >> >>> >>> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page >>> wrote: >>> >> >>>> >>> >> >>>> >>> >> >>>> A few other things that I noticed (or have been bugging me): >>> >> >>>> >>> >> >>>> - The menu bar seems a little cramped. Taking pg-navbar from 32 >>> to 40px and setting the font-weight to normal on the menu options (but not >>> the product name) seems much better to me (and adjusting everything else as >>> required of course). >>> >> >>> >>> >> >>> Giving too much space for the navbar will reduce the usable space >>> for other things. It is good enough(32) to be used easily, and is equal to >>> all the other headers in app (including tabs) giving a feel of native >>> desktop application. You'll find even smaller menu heights in native >>> desktop application. We can make font weight to normal and may be slightly >>> increase horizontal spacing between the menu links. >>> >> >> >>> >> >> >>> >> >> 8 pixels isn't going to make a noticeable difference to the >>> workspace for users, and would leave the bar smaller than the 50px it's >>> been for the last couple of years (iirc). I think it needs it to avoid >>> looking cramped - please make the change. >>> >> > >>> >> > Will do. >>> >> > One more doubt regarding bold headers, should I remove bold headers >>> in dashboard graph header, subnode headers (eg.table->columns), properties >>> tab accrordian headers ? >>> >> >>> >> No, please don't. I left them bold and the styling seemed like it >>> >> worked. We can tweak again if others disagree later. >>> >> >>> >> Thanks! >>> >> >>> >> BTW - Chrome 71 shows the offset headers in the file dialogue as well. >>> >> >>> >> >>>> >>> >> >>>> - In the file dialogue, the column headers don't line up with >>> the columns in the rows. >>> >> >>> >>> >> >>> I could not see this on my machine (screenshot attached). Could >>> you please share the screenshot. >>> >> >> >>> >> >> >>> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. >>> >> >> >>> >> >> -- >>> >> >> Dave Page >>> >> >> Blog: http://pgsnake.blogspot.com >>> >> >> Twitter: @pgsnake >>> >> >> >>> >> >> EnterpriseDB UK: http://www.enterprisedb.com >>> >> >> The Enterprise PostgreSQL Company >>> >> > >>> >> > >>> >> > >>> >> > -- >>> >> > Thanks and Regards, >>> >> > Aditya Toshniwal >>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune >>> >> > "Don't Complain about Heat, Plant a tree" >>> >> >>> >> >>> >> >>> >> -- >>> >> Dave Page >>> >> Blog: http://pgsnake.blogspot.com >>> >> Twitter: @pgsnake >>> >> >>> >> EnterpriseDB UK: http://www.enterprisedb.com >>> >> The Enterprise PostgreSQL Company >>> > >>> > >>> > >>> > -- >>> > Thanks and Regards, >>> > Aditya Toshniwal >>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>> > "Don't Complain about Heat, Plant a tree" >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --0000000000001cf1bf057f8d6608 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied without Tree Changes.

<= div class=3D"gmail_quote">
On Mon, Jan 14, 2019 at 10:55 AM= Aditya Toshniwal &l= t;aditya.<= span class=3D"" id=3D":2e0.4" tabindex=3D"-1" style=3D"">toshniwal@<= span class=3D"" id=3D":2e0.5" tabindex=3D"-1" style=3D"">enterprisedb.com> wrote:
Hi Hackers,=

Attached is the patch for further design i= mprovements:
- Process w= atcher made fixed width with header changes, time details rounded to 2 deci= mals
- Query history wil= l show "No query history" if no query fired. Query editor default= size increased.
- Tree = improvements - right bold border removed completely. Now click anywhere on = a tree item to perform actions. Please note, single click on the tiny tree = arrow button will not work with this. Clicking anywhere is more useful than= this.
=C2=A0@Dave=C2=A0=C2=A0Should we procee= d with this behaviour, I haven't commit it.=C2=A0
- Fixed a bug where New folder create button not work= ing when in List mode and No files/folder present.
- Other minor improvements.

Kindly review.

On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal <aditya.toshniwal= @enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for = few more changes:
- New = Folder button was not working in file dialogue. Fixed that.
- Color, icon changes in file dialogue<= /div>
- Also replaced the spla= sh screen image (which is used on main dashboard also). It works fine on da= shboard. However, I'm not sure of the splash screen as the new image is= SVG and older was PNG. I have made changes for that in runtime code but I&= #39;m not able to test (evnvironment issue) runtime code :(. It would be he= lpful if someone else can try it once.

Kind= ly review.


On Mon, Jan 7, 2019 at 2= :25 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks - applied!

On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal
<= aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to incorporate the changes discussed in trailing= mail(s).
>
> Kindly review.
>
> On Fri, Jan 4, 2019 at 3:31 PM Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal
>> <aditya.toshniwal@enterprisedb.com> wrote:
>> >
>> > Hi,
>> >
>> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal <aditya.to= shniwal@enterprisedb.com> wrote:
>> >>>
>> >>> Hi Dave,
>> >>>
>> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page <dpage@pgadmin.org> w= rote:
>> >>>>
>> >>>>
>> >>>> A few other things that I noticed (or have been b= ugging me):
>> >>>>
>> >>>> - The menu bar seems a little cramped. Taking pg-= navbar from 32 to 40px and setting the font-weight to normal on the menu op= tions (but not the product name) seems much better to me (and adjusting eve= rything else as required of course).
>> >>>
>> >>> Giving too much space for the navbar will reduce the = usable space for other things. It is good enough(32) to be used easily, and= is equal to all the other headers in app (including tabs) giving a feel of= native desktop application. You'll find even smaller menu heights in n= ative desktop application. We can make font weight to normal and may be sli= ghtly increase horizontal spacing between the menu links.
>> >>
>> >>
>> >> 8 pixels isn't going to make a noticeable difference = to the workspace for users, and would leave the bar smaller than the 50px i= t's been for the last couple of years (iirc). I think it needs it to av= oid looking cramped - please make the change.
>> >
>> > Will do.
>> > One more doubt regarding bold headers, should I remove bold h= eaders in dashboard graph header, subnode headers (eg.table->columns), p= roperties tab accrordian headers ?
>>
>> No, please don't. I left them bold and the styling seemed like= it
>> worked. We can tweak again if others disagree later.
>>
>> Thanks!
>>
>> BTW - Chrome 71 shows the offset headers in the file dialogue as w= ell.
>>
>> >>>>
>> >>>> - In the file dialogue, the column headers don= 9;t line up with the columns in the rows.
>> >>>
>> >>> I could not see this on my machine (screenshot attach= ed). Could you please share the screenshot.
>> >>
>> >>
>> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS.=
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software= Solutions |=C2=A0Pune
"Don't Complain about Heat, Plant = a tree"


--
Thanks and Regards,
Aditya Toshniwal
=
Software Engineer |=C2=A0E= nterpriseDB Software Solutions |=C2=A0P= une
"Don't Complai= n about Heat, Plant a tree"


--
Akshay Joshi
Sr. Software Architect

=

<= /font>
Phon= e: +91 20-3058-9517
Mobile: +91 976-788-8246
--0000000000001cf1bf057f8d6608--