public inbox for [email protected]  

help / color / mirror / Atom feed

From: Anil Sahoo <[email protected]>
To: Dave Page <[email protected]>
Cc: [email protected]
Subject: Re: Regarding feature #6841
Date: Thu, 18 Apr 2024 19:55:56 +0530
Message-ID: <CAO+oWtA13KM+jmWm+MkGbmLps2dh3B06mEZu6-PQjZ0ip7+G6g@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozieNmgfoGFq0G0Mxy+bu2Ct6hK9goZA3xtVJm9EaK6HA@mail.gmail.com>
References: <CAO+oWtBxAaDxdPOkcf=bTU0D6sDogX_az4SgN-5zKZt-9G=2xQ@mail.gmail.com>
	<CA+OCxozieNmgfoGFq0G0Mxy+bu2Ct6hK9goZA3xtVJm9EaK6HA@mail.gmail.com>

Hi Dave,
We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from
the editor through a tree called syntaxTree and by using some logic we
extracted the statements which have semicolon in it and also added some
extra logic to break the whole query on next of next line as empty or if
comments are there.

Using all this logic we got the individual queries and checked where our
cursor is in editor and checked with the query and through this we got the
actual query at cursor position.

For example,

   1. if the cursor is at starting or ending position or anywhere in
   between a query with semicolon or without semicolon, that can be single
   line or multi line then the query gets extracted.
   2. if the cursor is at starting or ending position or anywhere in
   between a comment that can be single line or multi line then the comment
   gets extracted.
   3. if the cursor is at a position where the previous line has a query
   then that query gets extracted.

For the anonymous block containing multiple queries, code mirror gives the
statements differently. That is an incomplete query we can say, so the
query tool gives error. We can say some limitations are there with Code
Mirror.

Please let me know if you have any questions on this.

Regards
Anil
--

<http://www.enterprisedb.com;

*Anil Sahoo*

Software Engineer

www.enterprisedb.com

Power to Postgres

<https://www.linkedin.com/company/edbpostgres;
<https://twitter.com/edbpostgres?lang=en;
<https://www.facebook.com/EDBpostgres;
<https://www.instagram.com/EDBpostgres/;


On Thu, Apr 18, 2024 at 2:24 PM Dave Page <[email protected]> wrote:

> Hi
>
> On Wed, 17 Apr 2024 at 15:08, Anil Sahoo <[email protected]>
> wrote:
>
>> Hi Hackers,
>>
>> This feature is about executing a query at the cursor position. And that
>> query can be a one line or multiline. I have assigned a play icon button
>> and F5 as the keyboard shortcut for the Execute Query feature, and for
>> Execute Script, Playlist icon button and Alt+F5(Others),Option+F5(Mac) as
>> keyboard shortcut.
>>
>> As now the query can run at cursor position, so for user convenience I am
>> showing the current query just beside the Data Output toolbar. And on hover
>> of the text, it will show the whole query as a tooltip. This query text
>> will be available for both Execute Script and Execute Query.
>>
>> I have made the UI change for the feature #6841
>> <https://github.com/pgadmin-org/pgadmin4/issues/6841;.
>>
>> Please provide your suggestions and feedback if these changes look okay
>> to you.
>>
>
> How is this parsing the query to figure out the correct text to send to
> the server? For example, I notice you have no semi-colons on many of the
> queries in your test; is it breaking on newlines? What if there's a newline
> (or multiple of them) in the query string? How does it cope with an
> anonymous block containing multiple queries, or a pl/whatever function
> definition that might contain queries within its text? Or a view definition?
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
>

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Regarding feature #6841
  In-Reply-To: <CAO+oWtA13KM+jmWm+MkGbmLps2dh3B06mEZu6-PQjZ0ip7+G6g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox