Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qR5kQ-000WOE-PJ for pgadmin-hackers@arkaria.postgresql.org; Wed, 02 Aug 2023 06:54:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qR5kO-003EA5-HC for pgadmin-hackers@arkaria.postgresql.org; Wed, 02 Aug 2023 06:54:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qR5kO-003E9x-28 for pgadmin-hackers@lists.postgresql.org; Wed, 02 Aug 2023 06:54:16 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qR5kL-0005Ry-9h for pgadmin-hackers@postgresql.org; Wed, 02 Aug 2023 06:54:14 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fe07f0636bso10600633e87.1 for ; Tue, 01 Aug 2023 23:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1690959251; x=1691564051; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8ZhPOAVAOMg/CDvw0p+MjR1cb/kQ3v9MfedSPT4Jt50=; b=H+mD0FUqwrZckdI04rvQRFFxhXqeOgJPr2ZVIGvUESMfOPTlDuUjg95yPsRBPX8w25 MWQknwASrl0LCBlN5PMileDP4U12fBSyu96ipVhjqpR3Mmb9bCaUxO5lcjXZbwb4KcMy VGxZ8bZSYjSDvlOEkRjnBUB+cDBxHlQs7+lk7fG/E7WSipzYjpN2/iagAl3K52EaFivF hwy4rHX0Pp39ha8no0wcfwveVO/Agkz33gl8NZkygM6YEOl7V5gUD7+Hk9GbXI+BfxBN 6pS3CfGpaRsORq8QkKoHXv5tKHiUgQkRxJGLSRMcrwnXamcJE9o6EujGeFc4j11hl1Is C7kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690959251; x=1691564051; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ZhPOAVAOMg/CDvw0p+MjR1cb/kQ3v9MfedSPT4Jt50=; b=k1Wwb+MEq29m5xmvVKX7wQuDfEk3TYrajEZx/ER+1r+1T5CwhMSKcNZqay5tJ+zFwy 2v2jQ4lVszY4iYGePkNiXngvvKExhHjpqdmnWzR191iZ4F5Ss9Er68qqKzcNmupHAP6i GFJJn/TIC0Rb/faaw31+5ZnMiT/IfnBzo8P3h7yhn6Cdmj+QK+rPqOY+c7/MMF32N6Lt ycWteKAkQJr5fzMIxw7vafErIvRsLSBFttuDlro76I5E+DHiju11yFcVEFKhnyqomRxG O9HtO5tevbBSvJvQLm2JkaaNbRkKH/PeEdImUrb6jJAzn0Wh1It1iU8EOVk4carWPBRV kwuw== X-Gm-Message-State: ABy/qLZk9zywTUEbS5d3VnD1EB914DPVOuo9dCnuEM9aPx6tIArV9eCG rwlgoWY561afIsTKl4oxu9niYsPRxHAkPsR3mx/9dsHPvTJd3JMD X-Google-Smtp-Source: APBJJlHRAo4qneQs7ytTgSa3L7yUdqP0kl6F+6bM0r6gBHgT8z1dvQhENfNF6ODaxLuAx3dznCv1djC6MznIvgeA05c= X-Received: by 2002:a05:6512:546:b0:4f6:6b:a43b with SMTP id h6-20020a056512054600b004f6006ba43bmr3558693lfl.52.1690959251413; Tue, 01 Aug 2023 23:54:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Anil Sahoo Date: Wed, 2 Aug 2023 12:23:33 +0530 Message-ID: Subject: Re: Implement new options to the Subscription of pgAdmin 4 To: Akshay Joshi Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="00000000000082c8db0601eb2178" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000082c8db0601eb2178 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Akshay, I will be adding a help message to each control, So it will take the whole row and will be easier to understand the control as well. *Anil Sahoo* Software Engineer www.enterprisedb.com Power to Postgres On Wed, Aug 2, 2023 at 12:21=E2=80=AFPM Akshay Joshi wrote: > Hi Anil > > I would suggest getting the 'Origin' field after streaming and making two > switch controls in one row as we did in the Backup dialog. If you are > adding a help message to the switch controls then leave it as it is. > > Apart from that it looks good to me. > > On Tue, Aug 1, 2023 at 11:56=E2=80=AFAM Anil Sahoo > wrote: > >> Hi Hackers, >> >> I am currently working on the features #4805 and #6454. There are some >> new options being added to the WITH clause of subscription that are list= ed >> below. >> For PostgreSQL 14 and above: >> >> 1. binary(boolean): Specifies whether the subscription will request >> the publisher to send the data in binary format. >> 2. streaming(boolean): Specifies whether streaming of in-progress >> transactions should be enabled for this subscription. >> >> For PostgreSQL 15 and above: >> >> 1. two_phase(boolean): Specifies whether two-phase commit is enabled >> for this subscription. >> 2. disable_on_error(boolean): Specifies whether the subscription >> should be automatically disabled if any errors are detected by subscr= iption >> workers during data replication from the publisher. >> >> For PostgreSQL 16 and above: >> >> 1. password_required(boolean): Specifies whether connections to the >> publisher made as a result of this subscription must use password >> authentication. >> 2. run_as_owner(boolean): If true, all replication actions are >> performed as the subscription owner. If false, replication workers wi= ll >> perform actions on each table as the owner of that table. >> 3. origin(string): Specifies whether the subscription will request >> the publisher to only send changes that don't have an origin or send >> changes regardless of origin. >> >> Attaching the respective screenshots of the updated UI for reference. >> Please review it. >> >> Thanks >> Anil Sahoo >> >> -- >> >> >> >> *Anil Sahoo* >> >> Software Engineer >> >> www.enterprisedb.com >> >> Power to Postgres >> >> >> >> >> >> > --00000000000082c8db0601eb2178 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,
I will be adding a help message to each con= trol, So it will take the whole row and will be easier to understand the co= ntrol as well.

<= div dir=3D"ltr" style=3D"margin-left:0pt" align=3D"left">

On Wed, Aug 2, 2023 at 12:21= =E2=80=AFPM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Hi=C2=A0Anil

I would suggest getting=C2= =A0the 'Origin' field after streaming and making two switch control= s in one row as we did in the Backup dialog. If you are adding a help messa= ge to the switch controls then leave it as it is.

= Apart=C2=A0from that it looks=C2=A0good to me.

On Tue, Aug 1, 2023 at = 11:56=E2=80=AFAM Anil Sahoo <anil.sahoo@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);pa= dding-left:1ex">
Hi Hackers,
I am current= ly working on the features #4805 and #6454. There are some new options bein= g added to the WITH clause of subscription that are listed below.
For PostgreSQL 14 and above:
<= ol>
  • binary(boolean):=C2=A0Specifi= es whether the subscription will request the publisher to send the data in = binary format.
  • streamin= g(boolean):=C2=A0Specifies whether streaming of in-progress transactions sh= ould be enabled for this subscription.
    • For PostgreSQL 15 and above:
      =
    1. two_phase(boolean):=C2=A0Specifies whether tw= o-phase commit is enabled for this subscription.
    2. = disable_on_error(boolean):=C2=A0Specifies whether= the subscription should be automatically disabled if any errors are detect= ed by subscription workers during data replication from the publisher.
    = For PostgreSQL 16 and abo= ve:
    1. passwor= d_required(boolean):=C2=A0Specifies whether connections to the publisher ma= de as a result of this subscription must use password authentication.
    2. run_as_owner(boolean):=C2=A0= If true, all replication actions are performed as the subscription owner. I= f false, replication workers will perform actions on each table as the owne= r of that table.
    3. origin= (string):=C2=A0Specifies whether the subscription will request the publishe= r to only send changes that don't have an origin or send changes regard= less of origin.
    Attaching the respective screenshots of the updat= ed UI for reference. Please review it.

    =
    Thanks=
    = Anil Sahoo

    --

    = Anil Sahoo

    Software Engineer

    www.enterprisedb.com

    Power to Postgres

    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0

    <= /tr>

    Anil Sahoo

    Software Engineer

    www.enterprisedb.com

    Power to Pos= tgres

    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0

    <= /div> --00000000000082c8db0601eb2178--