Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsUtI-0001fn-Kr for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 13:08:44 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bsUtI-0008D4-6C for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 13:08:44 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bsUt4-0007iN-EO for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 13:08:30 +0000 Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bsUsx-0006XP-MJ for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 13:08:29 +0000 Received: by mail-qk0-x22b.google.com with SMTP id o68so42210579qkf.3 for ; Fri, 07 Oct 2016 06:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kaspSvTVpVUa2rJA2snpm6DClj5Xl3ABHVe+jaqWPTk=; b=ADihqWbGlLo9KKiGue0wLG7VIlTuFO1mIYth20Ogb1bJKLsTrCQYtcrsmHgGb8MIM4 4nBChnXUJPq0NcVTFfu2kHvVCqzYaIIk2IqnZE//H2Bmh0VwMW2NeAvrr7RdV1DEzxzP rLh9byjVlME/IR9ghvIMeA691GpyLcQFOdO9OHZ06Ri8P8n/PO+k3mlkSRIrXSkHEtcO shgadGh9C16YwHCxatk+ZbdX/U/zxjHF0cZApOaaFZViK32cQGcu/GYMHczVIX9gGaXY kPyVuqCWp0Thm0spoyMsx7YVFM3EsWKXj+4ZK3N8++S9mXOZAWLhq5ZNpFi/I14HY4F3 NP8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kaspSvTVpVUa2rJA2snpm6DClj5Xl3ABHVe+jaqWPTk=; b=AJ3P+lVXGZrvIv7tzFuppxnVEWrhk+AOCn3rOnY0UoY6BoHkhxqJMddk32c09BkSyO D9wsD+l8h3We8JX9WOWi0+8qpWih4jtTaPNBfOqbZmZaxp8saes8V/4We9qdEswUG+24 UMhkv+pnaMaFmY9Oij3iKz323suX/OSpZcDZHALOt8WLEDrH4uDzLSiWSpPVANZhyGgy Xp+8b9T690N8xscZhdsXaVvdeS6fBKZaAs1Sy5cPe+FTyC8y3AHDGk4CV+G7aYa8/gMC N6hvWxxoQjGtcTZrBg7Sa3Pr9HJMGYJ2kvwHhRcXAQjSuaqYm7ZlZmGgQTXrp5hjrwoy OTNQ== X-Gm-Message-State: AA6/9RmWHwmRQolv5DS6u14Q7dRtsx9mlixC/BqOGjW+ouXjXp30+gBS5tDBDrYKR3mglD0wa/etVoVouvOboUPN X-Received: by 10.55.175.1 with SMTP id y1mr18817806qke.150.1475845702676; Fri, 07 Oct 2016 06:08:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.41.68 with HTTP; Fri, 7 Oct 2016 06:08:22 -0700 (PDT) In-Reply-To: References: From: Navnath Gadakh Date: Fri, 7 Oct 2016 18:38:22 +0530 Message-ID: Subject: Re: pgAdminIV : Regression tests code cleanup To: Dave Page Cc: pgadmin-hackers , Kanchan Mohitey Content-Type: multipart/alternative; boundary=94eb2c06fb04da19b1053e461ade X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c06fb04da19b1053e461ade Content-Type: text/plain; charset=UTF-8 Thanks Dave. On Fri, Oct 7, 2016 at 6:31 PM, Dave Page wrote: > Awesome - the test suite just found it's first bug! There was a code > path that referenced a variable that hadn't been defined, added in a > patch that I committed earlier without spotting the issue. The > associated tests failed, and I pretty quickly spotted (and fixed) the > bug as a result :-D > > Patch applied! > > On Fri, Oct 7, 2016 at 1:43 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Please find the patch of test framework, which contains > > 1. Code changes (due to drop objects functionality). > > 2. Quoting for database names in drop databases. > > 3. Code changes for import errors for pickle_path and advanced_config > > variables. > > > > Run test suite by this command: > > python runtests.py > > > > Thanks. > > -- > > Regards, > > Navnath Gadakh > > > > EnterpriseDB Corporation > > The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- Regards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company --94eb2c06fb04da19b1053e461ade Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks Dave.

On Fri, Oct 7, 2016 at 6:31 PM, Dave Page <dave= .page@enterprisedb.com> wrote:
Awesome - the test suite just found it's first bug! There was a cod= e
path that referenced a variable that hadn't been defined, added in a patch that I committed earlier without spotting the issue. The
associated tests failed, and I pretty quickly spotted (and fixed) the
bug as a result :-D

Patch applied!

On Fri, Oct 7, 2016 at 1:43 PM, Navnath Gadakh
<navnath.gadakh@enter= prisedb.com> wrote:
> Hi Dave,
>=C2=A0 =C2=A0 =C2=A0Please find the patch of test framework, which cont= ains
> 1. Code changes (due to drop objects functionality).
> 2. Quoting for database names in drop databases.
> 3. Code changes for import errors for pickle_path and advanced_config<= br> > variables.
>
> Run test suite by this command:
>=C2=A0 =C2=A0python runtests.py
>
> Thanks.
> --
> Regards,
> Navnath Gadakh
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
Regards,
Navnath Gadakh

=
EnterpriseDB Corporation
The Enterprise PostgreSQL Company=


--94eb2c06fb04da19b1053e461ade--