Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfQ4G-00037p-OK for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Sep 2016 11:22:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bfQ4F-0003PH-NG for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Sep 2016 11:21:59 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bfQ41-0003As-VX for pgadmin-hackers@postgresql.org; Thu, 01 Sep 2016 11:21:46 +0000 Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bfQ3u-0004Z3-MK for pgadmin-hackers@postgresql.org; Thu, 01 Sep 2016 11:21:44 +0000 Received: by mail-qk0-x233.google.com with SMTP id l2so80837318qkf.3 for ; Thu, 01 Sep 2016 04:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+AhYd5ZX3CyhafQxT04d1pRM4XnzPl1GLiqL4ZyMFCU=; b=yk8LWCLpWok/WyAp21MJwiVFY0/Yo7A5xii72LOfUgV8y1+IbFyStawp2OOmL0XpIV 7YJaWOYA/rP9nVHCvK/UYb/d1zjyXIsNJMin+qF5vRiss+wH6g5JyQAAZm686DLj7dq7 69pUMmBiypq25N4mXW7LYN1btb8TsM3R20ZvuTKTTxhLNe6nFVBEX1vPturqKez9bvIF 4kgpsvsWyAQD6UTv0W/zv9t1KNxQW94fFgs8VJfTh//rulc68ucyEtaEjLHrawX/mMZN CdIU5xrV/2yoqxj5XGAvIkRTjmP86IXjaJboTPZohzir2K83gY00uVxDMdExT5AlGdtx rtdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+AhYd5ZX3CyhafQxT04d1pRM4XnzPl1GLiqL4ZyMFCU=; b=g6HTqVBb192vFLkU32NQls/t45X/A/vLTtIT5sWVCS5TYi6yYxu7eFAq476R76u9XH Vu2HNfKtJsH/sEdGQ6E1/WJ7VdRz+bdvyf5+eHgd2jxVDFEZIc98cU6lRNKQ5UVtzpOO x5iPkqUJM3bpqQAtv2YwAA7OWUWgC4qMIw56hlPwztYdbzUMuTZltyAcBAv/RtIf0jK0 2bEx9bO1cU68BdODXnhbrBFqLIngPdPU8fZ6vS9FopTnjX1yl6U5oWy/UqMLXmKaS9Up bOyvKYdOmhTlY1sngdJIPRaSbhDVxIQVNIJFZUU0vFJSv/olVfER9zZBkC+Sv//rpX9T 9DEg== X-Gm-Message-State: AE9vXwPrfC05hzgCuSasRAwwNo6ubgsa0MWce5OtCUa38BEhxpWdj7Sn6tOa2bEd5h5F1SEelUSTUNYwkrtowO5R X-Received: by 10.55.140.135 with SMTP id o129mr15812914qkd.2.1472728898020; Thu, 01 Sep 2016 04:21:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.41.90 with HTTP; Thu, 1 Sep 2016 04:21:37 -0700 (PDT) In-Reply-To: References: From: Navnath Gadakh Date: Thu, 1 Sep 2016 16:51:37 +0530 Message-ID: Subject: Re: pgAdmin IV : Unittest modular patch (Domains and Tables nodes) To: Dave Page Cc: pgadmin-hackers , Kanchan Mohitey Content-Type: multipart/alternative; boundary=001a114eafecd14b53053b706ab2 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114eafecd14b53053b706ab2 Content-Type: text/plain; charset=UTF-8 Sure. On Thu, Sep 1, 2016 at 4:44 PM, Dave Page wrote: > Hi > > Please separate the cleanup from the new tests. Each patch should have > just one feature/focus/fix. > > Thanks. > > On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh < > navnath.gadakh@enterprisedb.com> wrote: > >> Hello Dave, >> Object cleanup work is completed in above patch. I am working on enhanced >> summary work, once that's complete I will send the revised patch. >> >> Thanks! >> >> On Thu, Sep 1, 2016 at 3:57 PM, Dave Page >> wrote: >> >>> Per my earlier email to Priyanka, I'm not going to commit any more test >>> cases until the existing issues are resolved and the enhanced summary and >>> object cleanup work is complete, otherwise it's just taking too much time >>> unnecessarily. >>> >>> Please re-test and resubmit this patch once that work is complete. >>> >>> Thanks. >>> >>> On Tue, Aug 30, 2016 at 1:02 PM, Navnath Gadakh < >>> navnath.gadakh@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> Please find the patch API unit test cases for Domain & Tables >>>> Nodes. >>>> >>>> This patch also includes code to drop the all objects(like database, >>>> roles, tablespace & server) created during the test suite run. >>>> >>>> *To run the test suite for domain node:* >>>> python regression/runtests.py --pkg browser.server_groups.servers. >>>> databases.schemas.domains >>>> >>>> >>>> *To run the test suite for tables node:* >>>> python regression/runtests.py --pkg browser.server_groups. >>>> servers.databases.schemas.tables >>>> >>>> *To run the test suite for all nodes *(Comment the all test code in >>>> 'synonyms' node i.e. Code under 'tests' directory as its partially >>>> completed): >>>> python regression/runtests.py >>>> >>>> >>>> -- >>>> Thanks, >>>> Navnath Gadakh >>>> Software Engineer >>>> EnterpriseDB Corporation >>>> Mobile: +91 9975389878 >>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> VP, Chief Architect, Tools & Installers >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >> >> >> >> -- >> Thanks, >> Navnath Gadakh >> Software Engineer >> EnterpriseDB Corporation >> Mobile: +91 9975389878 >> >> >> > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- Thanks, Navnath Gadakh Software Engineer EnterpriseDB Corporation Mobile: +91 9975389878 --001a114eafecd14b53053b706ab2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sure.

On Thu, Sep 1, 2016 at 4:44 PM, Dave Page <= dave.page@e= nterprisedb.com> wrote:
Hi

Please separate the cleanup from the ne= w tests. Each patch should have just one feature/focus/fix.

<= /div>
Thanks.

On Thu, Sep 1, 2016 at = 12:12 PM, Navnath Gadakh <navnath.gadakh@enterprisedb.c= om> wrote:
Hello Dave,
=C2=A0 =C2=A0 Object cleanup work is completed in above pa= tch. I am working on=C2=A0enhanced summary= work, once that's complete I will send the revised patch.
=

Thanks!

On Thu, Sep 1, 2016 at 3:57 PM, Dave P= age <dave.page@enterprisedb.com> wrote:
Per my earlier email to Priyan= ka, I'm not going to commit any more test cases until the existing issu= es are resolved and the enhanced summary and object cleanup work is complet= e, otherwise it's just taking too much time unnecessarily.
Please re-test and resubmit this patch once that work is compl= ete.

Thanks.

On Tue, Aug 30, 2016 at 1:02 PM, = Navnath Gadakh <navnath.gadakh@enterprisedb.com>= wrote:
Hi Dave,<= div>=C2=A0 =C2=A0 =C2=A0 =C2=A0Please find the patch API=C2=A0unit test cas= es for Domain & Tables Nodes.

This patch also = includes code to drop the all objects(like database, roles, tablespace=C2= =A0& server) created during the test suite run.

To run the test suite=C2=A0for domain node:
=C2=A0python regression/runtests.py --pkg browser= .server_groups.servers.databases.schemas.domains

=
To run the test suite=C2=A0for tables node:
=C2=A0=C2=A0python=C2=A0regression/runtests.py=C2=A0--pkg=C2=A0browser.server_groups.servers.databases.schemas.tables

To run the test suite for all = nodes=C2=A0(Comment the=C2=A0all test code in 'synonyms' node i= .e. Code under 'tests' directory as its partially completed):
=C2=A0=C2=A0python=C2=A0regression/runtests.py


--
=
Thanks,
Navnath=C2=A0Gadakh
Software = Engineer
EnterpriseDB Corporation
Mobile: +91 9975= 389878=C2=A0





<= font color=3D"#888888">--
Dave = Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb= .com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.comTwitter: @pgsnake



--
Thanks,
=
Navnath=C2=A0Gadakh
Software Engineer
EnterpriseDB Co= rporation
Mobil= e: +91 9975389878=C2=A0





--
=
Dave Page
VP, Chief Architect, T= ools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Pos= tgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
=
=
Thanks,
Navnath= =C2=A0Gadakh
Software Engineer
EnterpriseDB Corporation
<= /font>
Mobile: +91 9975389878=C2=A0

<= /font>

=
--001a114eafecd14b53053b706ab2--