MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxowE5D0N2oq-Da+eXh4+cZMA3=GqB85-nE+YHuaACfjhbQ@mail.gmail.com>
References: 
 <CAOAJCYrcxBN2J_3dWq0Cwc82fkugzUi3NKD4jKoTKRBot=ev8w@mail.gmail.com>
 <CAOAJCYpSBXcfEC5d4Sv_=jV86m1=rKUK0tMkZFhdSHkPb=XT3A@mail.gmail.com>
 <CA+OCxowW0wjpNT-o0YF1Bg9rtD6Z7sqp35ZRUgoEguVKO4OtSw@mail.gmail.com>
 <CAOAJCYr1JwYK4x2wDYw2UVAZoXC5a0FQT7Yz1Y_Wn46kzPMmQg@mail.gmail.com>
 <CA+OCxoxqahNgLmvQqqErQZL2JS0EaQwyXkgkzvkFtGNh0OKV6w@mail.gmail.com>
 <CAOAJCYqQQ4MaudVaVwfcateuxum-W39HwRiEorhYP8zbqjxN0g@mail.gmail.com>
 <CA+OCxozZVCwB4t6hXjMeHbBV8Fx1cm_Cg1tknjWyYxLFZNYsEQ@mail.gmail.com>
 <CAFOhELes8Vu_VciiVu31wfaYtTuCFUReEF1mfNXB4nSMcTNrHA@mail.gmail.com>
 <CAOAJCYpY=u4T38s+XqQDOky10e7A_Wb_q9bbiwhx_=eF-6i-dQ@mail.gmail.com>
 <CA+OCxoxm9_f5PJVLhwrSk6bozmivv_-=o+spffXjkYk+qPDKeg@mail.gmail.com>
 <CAOAJCYpcye6nQAPB8os9vZXOhAf9wEvr6rA9i4vuZLDVrRYF0g@mail.gmail.com>
 <CA+OCxowE5D0N2oq-Da+eXh4+cZMA3=GqB85-nE+YHuaACfjhbQ@mail.gmail.com>
From: Navnath Gadakh <navnath.gadakh@enterprisedb.com>
Date: Thu, 28 Jul 2016 12:42:29 +0530
Message-ID: 
 <CAOAJCYonmDD-oqjwhJNVpWVHxyf-bTn_eJ8o7wNMr7sOOpBvkA@mail.gmail.com>
Subject: Re: pgAdmin IV : Unittest modular patch
To: Dave Page <dave.page@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Kanchan Mohitey <kanchan.mohitey@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks Dave!

On Wed, Jul 27, 2016 at 8:12 PM, Dave Page <dave.page@enterprisedb.com> wro=
te:
> Ahh, that explains it. Nice catch! It's working in both server and
> desktop modes now :-).
>
> I've committed the patch, but can you please look at the following issues:
>
> 1) When testing SMTP, the encoded password used to connect to the
> server is displayed in both the logs and stdout (the "send: 'AUTH
> PLAIN ....'" lines). Can you catch that, and replace it with *'s
> please? Sooner or later someone will reveal a password otherwise.
  Sure. I will implement in the next patch.
>
> 2) Is the test count in the summary correct when you have multiple
> servers? I think it might be resetting between servers.
     In the current code runTest() function calls only one time for
single/multiple server/s that's why it's showing same count for both
(single & multiple).
   Question: What exactly we are looking for, only count? Or we need
any more logs like for adding database, it should display in which
server (PG/PPAS) its adding database if this is the case we need a
feasibility check.

>
> 3) Please ensure that test databases that are created are also dropped
> again. I'm getting tired of deleting them manually!
    I already added delete databases in tearDown () function, But
yeah, I found two test cases where this code missed. I will add this
in the next patch.

>
> Thanks, Dave.
>
> On Wed, Jul 27, 2016 at 1:19 PM, Navnath Gadakh
> <navnath.gadakh@enterprisedb.com> wrote:
>> Hi Dave,
>>       We have reproduced the issue you mentioned in the previous
>> email. We need to skip the login related test cases when SERVER_MODE =3D
>> False in the web/config_local.py.
>>
>> Please find the revised patch for the same.
>>
>> Thanks!
>>
>>
>> On Fri, Jul 22, 2016 at 9:48 PM, Dave Page <dave.page@enterprisedb.com> =
wrote:
>>> Hi
>>>
>>> On Fri, Jul 22, 2016 at 2:22 PM, Navnath Gadakh
>>> <navnath.gadakh@enterprisedb.com> wrote:
>>>> Hi Dave,
>>>>
>>>>    Please find the attached patch for pgAdmin4 unittest(Support of API
>>>> testing with different servers i.e. PG and PPAS).
>>>>
>>>> This patch includes-
>>>>
>>>> Test framework support API testing with multiple server for this we ne=
ed to
>>>> modify test_config.json(for user it=E2=80=99s test_config.json.in) and
>>>> test_advanced_config.json(for user it=E2=80=99s test_advanced_config.j=
son.in).
>>>> Server details of PG and  PPAS are included in both .in files.
>>>>
>>>> Removed the logic of logging in  the test client on each test scenario=
(As
>>>> per Khushboo's comment in previous email).  We need this logic in test=
 cases
>>>> under =E2=80=98browser/tests/=E2=80=99 as for test scenarios like chan=
ge password and
>>>> invalid login test cases as test client should be logged out first. So=
, as
>>>> per this the code is slightly modified in =E2=80=98browser/tests/=E2=
=80=99.
>>>
>>> OK in principle, but it doesn't seem to work:
>>>
>>> This function will add the server under default server group. (Default
>>> Server Node url) ... ok
>>>
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>> FAIL: runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordT=
estCase)
>>> This function checks reset password functionality. (TestCase for
>>> Validating Empty Email)
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>>   File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_=
password.py",
>>> line 44, in runTest
>>>     'utf-8'))
>>> AssertionError: 'Recover pgAdmin 4 Password' not found in u'<!DOCTYPE
>>> HTML PUBLIC "-//W3C//DTD HTML 3.2
>>> Final//EN">\n<title>Redirecting...</title>\n<h1>Redirecting...</h1>\n<p=
>You
>>> should be redirected automatically to target URL: <a href=3D"/">/</a>.
>>> If not click the link.'
>>>
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>> FAIL: runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordT=
estCase)
>>> This function checks reset password functionality. (TestCase for
>>> Validating Invalid_Email)
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>>   File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_=
password.py",
>>> line 44, in runTest
>>>     'utf-8'))
>>> AssertionError: 'Recover pgAdmin 4 Password' not found in u'<!DOCTYPE
>>> HTML PUBLIC "-//W3C//DTD HTML 3.2
>>> Final//EN">\n<title>Redirecting...</title>\n<h1>Redirecting...</h1>\n<p=
>You
>>> should be redirected automatically to target URL: <a href=3D"/">/</a>.
>>> If not click the link.'
>>>
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>> FAIL: runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordT=
estCase)
>>> This function checks reset password functionality. (TestCase for
>>> Validating Valid_Email)
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>>   File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_=
password.py",
>>> line 44, in runTest
>>>     'utf-8'))
>>> AssertionError: 'Recover pgAdmin 4 Password' not found in u'<!DOCTYPE
>>> HTML PUBLIC "-//W3C//DTD HTML 3.2
>>> Final//EN">\n<title>Redirecting...</title>\n<h1>Redirecting...</h1>\n<p=
>You
>>> should be redirected automatically to target URL: <a href=3D"/">/</a>.
>>> If not click the link.'
>>>
>>> ----------------------------------------------------------------------
>>> Ran 26 tests in 30.109s
>>>
>>> FAILED (failures=3D3)
>>>
>>> It's very far from obvious what's wrong here (/reset looks just fine
>>> to me). How can we get more useful info out of the framework?
>>>
>>> --
>>> Dave Page
>>> VP, Chief Architect, Tools & Installers
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>
>>
>>
>> --
>> Thanks,
>> Navnath Gadakh
>> Software Engineer
>> EnterpriseDB Corporation
>> Mobile: +91 9975389878
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake


--=20
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878


--=20
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers