Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjjfv-0005wl-Em for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Sep 2016 09:06:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bjjfu-0000TU-Or for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Sep 2016 09:06:42 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bjjfe-0000EH-VV for pgadmin-hackers@postgresql.org; Tue, 13 Sep 2016 09:06:27 +0000 Received: from mail-qt0-x229.google.com ([2607:f8b0:400d:c0d::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bjjfb-0005ju-Je for pgadmin-hackers@postgresql.org; Tue, 13 Sep 2016 09:06:25 +0000 Received: by mail-qt0-x229.google.com with SMTP id 93so85704134qtg.2 for ; Tue, 13 Sep 2016 02:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=u9iQqSvKCevE02gzXFiaEW7W8K78Axk8tvyxmuEOzxI=; b=U8nowxNpb7BKKW9poqqNqwDfJZKwNlmsgxGCt7OETxTn2Htva171e7g+8xjikiD7Lq 11J/YE0EhMnmQIBmNYdLiFf1FKqSOeWfD+gysJQf7kTy0OwQ0O9aqL0NnfHe3QV5O9A+ 0mMRA4SktygUV4J44urOydwSacj4uAL8eVAMAMh43GdDnMsKRyq29xakPb4Z3lnQfqri gzHRMfTdQdBC3VggiO4DeNfoEn+Ebsi8XywI+Kz9tQ0FRFekeDgqNJypZcSSTg44Dity u4u+vrYW5dubyzCiYzTJmF31BLmHn9OtFupGXdoPlOFDUXJptddwm1ekK/x2g8f4m5Xc gLhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=u9iQqSvKCevE02gzXFiaEW7W8K78Axk8tvyxmuEOzxI=; b=QhgEvvhFbmufhsWawsJ9tCOfDCEPLkzJi94gt8zLbEbwVuCX+jS/Y6BtNL5zlo5cOC 3lGxgIId8eaeOeYR+TZThH1RCsX3FWH6EmjOB0yTtRBGG63UJZQK/ur10Ns4AOk0u8ap Erynf+XrYmlsgfkGUr/ta6AOMg80Q5o1Qi3nMUy5A/rrCuz58+YAi6bc3oEl0o4T4sQI 8OApKDiFXuUhlr7d0d7pgLBLw30Y6pEA/R63cbmnzrbOuyLqUrOr1ESE9M1OEgfbr6hs Y+z3gGBtmQti7THrK8f5HcTooTV7SfDUc8ANTzxVhyluERrHHQaU0oGz2QQEWQV+JFgt Jgxg== X-Gm-Message-State: AE9vXwOTfiNUAD4jgHEeYPvE7uTLY7IdYC+L95UwmYsamcyV5Z3b3fCseb8mUtI4kk00PN3a7YjWH5aFhccjokH+ X-Received: by 10.200.40.36 with SMTP id 33mr24739738qtq.53.1473757582359; Tue, 13 Sep 2016 02:06:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.41.114 with HTTP; Tue, 13 Sep 2016 02:06:21 -0700 (PDT) In-Reply-To: References: From: Navnath Gadakh Date: Tue, 13 Sep 2016 14:36:21 +0530 Message-ID: Subject: Re: Server specific advanced config file for testsuite To: Dave Page Cc: Kanchan Mohitey , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140e9ec2ed9ff053c5fedd4 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140e9ec2ed9ff053c5fedd4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 13, 2016 at 2:18 PM, Dave Page wrote: > BTW - I need the updated code that fixes all outstanding issues this > week please. Release is coming up fast... Yes. The enhanced test result is already completed, but before that drop objects functionality is needed to complete. Which is already done for servers & databases. So I will send a patch for these two nodes today & after that for the remaining nodes(need some modifications in existing setup & teardown for each test module) We will try to finish this work end of this week. Thanks. > > On Tue, Sep 13, 2016 at 9:48 AM, Dave Page > wrote: > > Hi > > > > On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh > > wrote: > >> Hi Dave, > >> As we know that, we are using two JSON files one is for basic > >> configuration of server(test_config.json) and second for detailed > >> configuration of server(test_advanced_config.json). > >> In test_advanced_config.json, we give detail for database, schema, > >> extension, collation etc. These details are generic I mean these > details are > >> not server specific. > >> - Do we need to allow user to give server specific details? > > > > I don't see any reason to do so. Honestly I don't see much need for > > test_advanced_config.json at all - I can't see anyone ever customising > > the tests. I certainly doubt I will. > > > >> If yes, there should be some identification(like =E2=80=98server_type= =E2=80=99, > =E2=80=98version=E2=80=99) > >> for each detail so that we can read server appropriate details. > >> We have one approach in mind, to attach 'server_type' & 'version' to > each > >> detail > >> So, modified test_advanced_config.json can be like this, > >> { > >> "add_database_data=E2=80=9D:[ > >> { > >> "conn_limit": -1, > >> =E2=80=9Cowner=E2=80=9D: =E2=80=9Cpostres=E2=80=9D, > >> . > >> . > >> . > >> . > >> =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D, > >> =E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D > >> }, > >> { > >> { > >> "conn_limit": -1, > >> =E2=80=9Cowner=E2=80=9D: =E2=80=9Centerprisedb=E2=80=9D, > >> . > >> . > >> . > >> . > >> =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cppas=E2=80=9D, > >> =E2=80=9Cversion=E2=80=9D: =E2=80=9Cppas9.6=E2=80=9D > >> } > >> }], > >> =E2=80=9Cschema_credentials=E2=80=9D: > >> [{"func_acl": [], > >> "seq_acl": [], > >> . > >> . > >> . > >> . > >> =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D, > >> =E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D > >> }] > >> . > >> . > >> . > >> . > >> . > >> } > >> > >> Any suggestions? > >> > >> For multiple server currently we used 'owner' to identify the server, > but > >> that fails if two servers have the same owner. > >> > >> > >> -- > >> Thanks, > >> Navnath Gadakh > >> Software Engineer > >> EnterpriseDB Corporation > >> Mobile: +91 9975389878 > >> > >> > > > > > > > > -- > > Dave Page > > VP, Chief Architect, Tools & Installers > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > Blog: http://pgsnake.blogspot.com > > Twitter: @pgsnake > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > --=20 Thanks, Navnath Gadakh Software Engineer EnterpriseDB Corporation Mobile: +91 9975389878 --001a1140e9ec2ed9ff053c5fedd4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

On Tue, Sep 13, 2016 at 2:18 PM, Dave Page <dave.page@enterpri= sedb.com> wrote:
BTW - I = need the updated code that fixes all outstanding issues this
week please. Release is coming up fast...
=C2=A0Yes. The e= nhanced=C2=A0test result is already completed, but before that drop objects= functionality is needed to complete. Which is already done for servers &am= p; databases. So I will send a patch for these two nodes today & after = that for the remaining nodes(need some=C2=A0modifications in=C2=A0existing= =C2=A0setup & teardown=C2=A0for each test module)

<= div>=C2=A0We will try to finish this work end of this week.

<= /div>
=C2=A0Thanks.
=C2=A0 =C2=A0
=C2=A0

On Tue, Sep 13, 2016 at 9:48 AM, Dave Page <dave.page@enterprisedb.com> wrote:
> Hi
>
> On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
> <navnath.gadakh@= enterprisedb.com> wrote:
>> Hi Dave,
>>=C2=A0 =C2=A0 =C2=A0 As we know that, we are using two JSON files o= ne is for basic
>> configuration of server(test_config.json) and second for detailed<= br> >> configuration of server(test_advanced_config.json).
>> In test_advanced_config.json, we give detail for database, schema,=
>> extension, collation etc. These details are generic I mean these d= etails are
>> not server specific.
>> - Do we need to allow user to give server specific details?
>
> I don't see any reason to do so. Honestly I don't see much nee= d for
> test_advanced_config.json at all - I can't see anyone ever customi= sing
> the tests. I certainly doubt I will.
>
>> If yes, there should be some identification(like =E2=80=98server_t= ype=E2=80=99, =E2=80=98version=E2=80=99)
>> for each detail so that we can read server appropriate details. >> We have one approach in mind, to attach 'server_type' &= ; 'version' to each
>> detail
>> So, modified test_advanced_config.json can be like this,
>> {
>> "add_database_data=E2=80=9D:[
>> {
>>=C2=A0 "conn_limit": -1,
>>=C2=A0 =E2=80=9Cowner=E2=80=9D: =E2=80=9Cpostres=E2=80=9D,
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D,
>>=C2=A0 =E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D
>> },
>> {
>> {
>>=C2=A0 "conn_limit": -1,
>>=C2=A0 =E2=80=9Cowner=E2=80=9D: =E2=80=9Centerprisedb=E2=80=9D,
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cppas=E2=80=9D,
>>=C2=A0 =E2=80=9Cversion=E2=80=9D: =E2=80=9Cppas9.6=E2=80=9D
>> }
>> }],
>> =E2=80=9Cschema_credentials=E2=80=9D:
>> [{"func_acl": [],
>>=C2=A0 =C2=A0"seq_acl": [],
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0.
>>=C2=A0 =C2=A0=E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D, >>=C2=A0 =C2=A0=E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D
>> }]
>> .
>> .
>> .
>> .
>> .
>> }
>>
>> Any suggestions?
>>
>> For multiple server currently we used 'owner' to identify = the server, but
>> that fails if two servers have the same owner.
>>
>>
>> --
>> Thanks,
>> Navnath Gadakh
>> Software Engineer
>> EnterpriseDB Corporation
>> Mobile: +91 9975389878
>>
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
=
=
Thanks,
Navnath= =C2=A0Gadakh
Software Engineer
EnterpriseDB Corporation
<= /font>
Mobile: +91 9975389878=C2=A0

<= /font>

=
--001a1140e9ec2ed9ff053c5fedd4--